From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by sourceware.org (Postfix) with ESMTPS id 66E563858C2F for ; Thu, 25 Aug 2022 13:44:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 66E563858C2F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-ed1-x52a.google.com with SMTP id b16so26196302edd.4 for ; Thu, 25 Aug 2022 06:44:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=xz5QstyN0OVsW/oiC6cE4AEUhs+rJdK1u9wELJoi1qI=; b=hk1UIoaHucWBn7F43MJhKIvj254ZV6txMRhzy2f/1IAlwrQQFvUPnMR38kQN1rhmL0 QQs1HefRq71FdKVhwL1nk3fYbq0CzQwx7jwO/FCr+KTNDDAejUzC1kFHkVkvAfYSSR4Y 7+cq/5DZSe2Mqa5ywzRjdyjwHinvlGWdY7yItHCnI7jsLB5Nh5Ux/iPa4D97WsAD+dED 0h+L98sFwocBE4j5qW3SoatW476r9RkuLIG2rXoStpnlmzcLlF4YxVpbdF40eNr4ayC/ Wk0ZSXtESxPir4KI/ZoaLsAe+8cyD9ayebih/4X7nK/q4OtkK8F7TqzjANfVqvMEN0vf 7HrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=xz5QstyN0OVsW/oiC6cE4AEUhs+rJdK1u9wELJoi1qI=; b=7CrQVqEaanvtLjLfq1VX3vv//LqXCEqveVTiNKHCUGepdymv+XsbquamCgt0+kqmQt JW44a+L5SvjkhWokOapcYpuO2PfZndnwL+y3c+M+LqCOuLaahzzmQef4qzYrXMIT/jsG b/yKlMq5+VNqWYT8PSwShpPbh425pSmeFV1M4E7r/6n0qCk86Yv1zgmx6/YAhvscm48r XHb9qYYwc9MhzG6lRbb/fO6VKJb3DKiJ2TwXDrEOhlJDP7zkrQhuAzBIaExRFfQkaLKs tCo3HHLuRUkfja+BAHvU5XxIRgLzRj0yzYGy1Ckv6qyRD8bvV9qDnU7pFtpX/A2hLion V1OQ== X-Gm-Message-State: ACgBeo3onjCY8ESrYVMsJJNeGxNCP4n9xmKi9cS2O70TKupfAnb2yADv i8sFP4o6vTWC7PCdT5x4DnmFfNOzOWcSraR0FLgm5Q== X-Google-Smtp-Source: AA6agR4TxGbAcTEUZr9dcaVD3llHq/FPXSZPHfmxAAXraANLuTBt+jejyeAYFOYrvAYSOPdlqdx//0Ja0iuT+9ATSyU= X-Received: by 2002:a05:6402:350b:b0:43e:f4be:c447 with SMTP id b11-20020a056402350b00b0043ef4bec447mr3350563edd.427.1661435069075; Thu, 25 Aug 2022 06:44:29 -0700 (PDT) MIME-Version: 1.0 References: <20220824115956.737931-1-philip.herron@embecosm.com> In-Reply-To: From: Philip Herron Date: Thu, 25 Aug 2022 14:44:17 +0100 Message-ID: Subject: Re: Rust frontend patches v2 To: "Frank Ch. Eigler" Cc: =?UTF-8?Q?Martin_Li=C5=A1ka?= , Mark Wielaard , gcc-rust@gcc.gnu.org, Gcc Patch List , Jonathan Wakely Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 25 Aug 2022 at 13:50, Frank Ch. Eigler wrote: > > Hi - > > > > 12K 0004-gccrs-Add-link-cases-testsuite.patch > > 356K 0005-gccrs-Add-general-compilation-test-cases.patch > > 132K 0006-gccrs-Add-execution-test-cases.patch > > 4.0K 0007-gccrs-Add-gcc-check-target-check-rust.patch > > 656K 0008-gccrs-Add-the-Rust-front-end-AST-data-structures.patch > > 112K 0009-gccrs-Add-Lexer-for-Rust-front-end.patch > > 504K 0010-gccrs-Add-Parser-for-Rust-front-end.patch > > 200K 0011-gccrs-Add-expansion-pass-for-the-Rust-front-end.patch > > 204K 0012-gccrs-Add-name-resolution-pass-to-the-Rust-front-end.patch > > 476K 0013-gccrs-Add-second-intermedite-representation-called-H.patch > > [...] > > Just curious whether a human reviewer expected to read through this > much content? If not, and if this structure is only for machine / > bisecting purposes, maybe they're not worth also emailing. > > - FChE That's a good point. I prefer reading this stuff on the git branch either: https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/devel/rust/master https://github.com/Rust-GCC/gccrs The first patch here is a nice isolated GCC change the rest of the patches are either pure front-end code or setting up the rust target for the test suite. The main patches I think people will be interested in are: [PATCH Rust front-end v2 01/37] Use DW_ATE_UTF for the Rust 'char' [PATCH Rust front-end v2 07/37] gccrs: Add gcc-check-target [PATCH Rust front-end v2 31/37] gccrs: Add GCC Rust front-end [PATCH Rust front-end v2 32/37] gccrs: Add config-lang.in [PATCH Rust front-end v2 33/37] gccrs: add lang-spec.h [PATCH Rust front-end v2 34/37] gccrs: add lang.opt [PATCH Rust front-end v2 35/37] gccrs: add compiler driver [PATCH Rust front-end v2 36/37] gccrs: compiler proper interface Eventually, when we clean it up, our port of the constexpr.cc from the C++ front-end might be of interest to other front-ends. --Phil