From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by sourceware.org (Postfix) with ESMTPS id C6711385841D for ; Thu, 28 Jul 2022 09:40:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C6711385841D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-ej1-x631.google.com with SMTP id mf4so2209271ejc.3 for ; Thu, 28 Jul 2022 02:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ztgu4Qa1Zs7tJHMC+N1u2Huw9tJmnZFrGunNY5cJKL0=; b=hqleToddYgKKcaQ7q79vrRvaqAaWSuv+3VP94GXCGSsMrWbz/GUXGh0l1AjrZ6M4LB YFmAyVMw6NiyI4+TJkOFkjzw0OTCXwn5WgRK81aHLxIIzUFRRYHS60WbU4/C3LRv1vRb D2jeuYJEtMHmNsJr5j0gmOhkhW5CP+jEQgIxH56DKb3y5ym3PV45E+pusBrhJqsh09eR eHXkv/fpTu38S/xinfA+BfjTvFpu+cHU1+Yx3z9Pfc4GLoAuDqBdb2kKITS4logsLR3r ON1BMOPR2/agvK1gBwKIpH1182/9I4QF78CcuKPK5hLiY1YXbOMbmfdQiDfSffC8UduB WWzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ztgu4Qa1Zs7tJHMC+N1u2Huw9tJmnZFrGunNY5cJKL0=; b=f09e1i9siLnm2zxUYPxdoLOJZUC1OxZIO5IHMHa7XGtKVxlSrNbsdY0mjS3PkyPTyI uCyLvVIsnhPMqabpNrl/OHREjAZdzYIT0YUyZwso/0IKppqpR0jbTiDKqRdJdSDtpTRL ykejxhHfR8EzXex91RS09eFwtqgeO3PBwKlSm3Lqvhw2CxQFW/oCWa2mSnw4/QOWdhcX cEXVWEjPmJ2aH0ey/M2TCVLZWRwlOKV+3HaZDW7zq1JNuNG9zv0XBLyAtkWcg3e9ZfqB ttMcIpCA5aoEm5VyRQhp+J06sgJbeh/Pq3p2tyf38skByR2T1sgvjhNvMva3sQhwpPb6 SF1A== X-Gm-Message-State: AJIora8m5icPPPnSmmBK4cs17cRnbCvy8wQqela1FRgJ7fSsCetZZqRI j/QFsBcxqoiJVYeaXVF46EtWLpnHl7UBYSE2B9L/WA== X-Google-Smtp-Source: AGRyM1vAH+bdlVl5LHM8K1WLqql6uX9PaEdQsRs1CSLEs5VX0fMaJnKED2DGdDdDfVUcxk0Ikc/fHjUJtUFQszEMWSE= X-Received: by 2002:a17:906:98d4:b0:72b:7258:dee0 with SMTP id zd20-20020a17090698d400b0072b7258dee0mr20373570ejb.57.1659001201436; Thu, 28 Jul 2022 02:40:01 -0700 (PDT) MIME-Version: 1.0 References: <20220727134040.843750-1-philip.herron@embecosm.com> <52031efabcd85759ff3bf3a4d0c6a4ff0b47128e.camel@redhat.com> In-Reply-To: <52031efabcd85759ff3bf3a4d0c6a4ff0b47128e.camel@redhat.com> From: Philip Herron Date: Thu, 28 Jul 2022 10:39:50 +0100 Message-ID: Subject: Re: Rust frontend patches v1 To: David Malcolm Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_NUMSUBJECT, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2022 09:40:04 -0000 Thanks, for confirming David. I think it was too big in the end. I was trying to figure out how to actually split that up but it seems reasonable that I can split up the front-end patches into patches for each separate pass in the compiler seems like a reasonable approach for now. --Phil On Wed, 27 Jul 2022 at 17:45, David Malcolm wrote: > > On Wed, 2022-07-27 at 14:40 +0100, herron.philip--- via Gcc-patches > wrote: > > This is the initial version 1 patch set for the Rust front-end. There > > are more changes that need to be extracted out for all the target > > hooks we have implemented. The goal is to see if we are implementing > > the target hooks information for x86 and arm. We have more patches > > for the other targets I can add in here but they all follow the > > pattern established here. > > > > Each patch is buildable on its own and rebased ontop of > > 718cf8d0bd32689192200d2156722167fd21a647. As for ensuring we keep > > attribution for all the patches we have received in the front-end > > should we create a CONTRIBUTOR's file inside the front-end folder? > > > > Note thanks to Thomas Schwinge and Mark Wielaard, we are keeping a > > branch up to date with our code on: > > https://gcc.gnu.org/git/?p=gcc.git;a=shortlog;h=refs/heads/devel/rust/master > > but this is not rebased ontop of gcc head. > > > > Let me know if I have sent these patches correctly or not, this is a > > learning experience with git send-email. > > > > [PATCH Rust front-end v1 1/4] Add skeleton Rust front-end folder > > [PATCH Rust front-end v1 2/4] Add Rust lang TargetHooks for i386 and > > [PATCH Rust front-end v1 3/4] Add Rust target hooks to ARM > > [PATCH Rust front-end v1 4/4] Add Rust front-end and associated > > FWIW it looks like patch 4 of the kit didn't make it (I didn't get a > copy and I don't see it in the archives). > > Maybe it exceeded a size limit? If so, maybe try splitting it up into > more patches. > > Dave >