From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16904 invoked by alias); 12 Dec 2017 18:51:08 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16829 invoked by uid 89); 12 Dec 2017 18:51:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,KAM_SHORT,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.2 spammy=town X-HELO: mail-wm0-f44.google.com Received: from mail-wm0-f44.google.com (HELO mail-wm0-f44.google.com) (74.125.82.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Dec 2017 18:51:01 +0000 Received: by mail-wm0-f44.google.com with SMTP id 9so608922wme.4 for ; Tue, 12 Dec 2017 10:51:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fB4F9d+jYj0O/Q0I1f1RUqkFAc8mOEkYsTg1RMoJK6I=; b=jYYdjkPODCLfS8K6ZsferxKsmHSOuEAuALkBkpCqHDZ2HfrsGcu8hf0d6GC4+5KrS9 DQHvJqdG88p/tc2PgJDvW8J4wZmDTSX/RFFWBXKbqb+8kuCGfyl6ytxWMSxXWRwF++Gp 7IiDNzor3U1NOx84jrGFMLd61usSYUyjCR3fGvX1/ohdZe0/rMB9CcMcbuXGaKvJPBj5 4FP25XVVWgSymcxtcTskjbkuxloYPjs7nfTs+7op3Q3RHQ/2FGorPX+ieIyr2wC5TKku yMZfYfyB0bOO4av+UoH2+pZYzv3do/MFANSEB6Oo7HtDxjcy0O5RoL/Tp12eidPoa129 tLBA== X-Gm-Message-State: AKGB3mLhUBOtjnbs+7nSODX/DbIPUaU7q66ewfQdGmta2mNecjutzaj3 LZ1biZb79nd8Zyk2YKFH4CviMJDfZzot2SDWk96fag== X-Google-Smtp-Source: ACJfBouQ7zwCzaKgnoLhBMOdk4cSJ4W6vtPmc+MHg9ItYsey21ihzINdXF+bhh1XWfvmWe3ce7Y4z3Oa4xU0FZPn+zs= X-Received: by 10.80.211.18 with SMTP id g18mr4256608edh.279.1513104659259; Tue, 12 Dec 2017 10:50:59 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.152.131 with HTTP; Tue, 12 Dec 2017 10:50:58 -0800 (PST) In-Reply-To: References: <87376dlcb9.fsf_-_@immunant.com> <87r2t7j584.fsf@immunant.com> From: Stephen Crane Date: Tue, 12 Dec 2017 18:51:00 -0000 Message-ID: Subject: Re: [PATCH] [GOLD] Add plugin API for processing plugin-added input files To: Sriraman Tallam Cc: Cary Coutant , Binutils , GCC Patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00762.txt.bz2 Thank you so much. I just added documentation for the new hook to https://gcc.gnu.org/wiki/whopr/driver so that should finish off this feature. I'm happy to fix any bugs that might crop up related to this hook, of course. I don't follow the binutils list closely, so I apologize in advance if I miss any issues related to this feature. Just CC me explicitly and I'll jump on it. Thanks, - stephen On Mon, Dec 11, 2017 at 3:03 PM, Sriraman Tallam wrote: > On Mon, Dec 11, 2017 at 2:16 PM, Stephen Crane wrote: >> Thanks for committing the GCC portion and following up on this. I had >> been meaning to write and ask. I don't have commit privs for binutils, >> so either you or Cary will have to commit the binutils patch as well, >> if it's not too much trouble. I think much has changed to need a >> rebase? > > I just committed your patch. I had to make one very minor change to > plugin_new_section_layout.c to compile, move the loop initialization > declaration outside as that is not allowed on C. I tested the patch. > > Thanks > Sri > >> >> Thanks, >> Stephen >> >> On Mon, Dec 11, 2017 at 2:10 PM, Sriraman Tallam wrote: >>> On Thu, Nov 9, 2017 at 9:04 PM, Cary Coutant wrote: >>>>> include/ChangeLog: >>>>> 2017-11-09 Stephen Crane >>>>> >>>>> * plugin-api.h: Add new plugin hook to allow processing of input >>>>> files added by a plugin. >>>>> (ld_plugin_new_input_handler): New funcion hook type. >>>>> (ld_plugin_register_new_input): New interface. >>>>> (LDPT_REGISTER_NEW_INPUT_HOOK): New enum val. >>>>> (tv_register_new_input): New member. >>>>> >>>>> >>>>> gold/ChangeLog: >>>>> 2017-11-09 Stephen Crane >>>>> >>>>> * plugin.cc (Plugin::load): Include hooks for register_new_input >>>>> in transfer vector. >>>>> (Plugin::new_input): New function. >>>>> (register_new_input): New function. >>>>> (Plugin_manager::claim_file): Call Plugin::new_input if in >>>>> replacement phase. >>>>> * plugin.h (Plugin::set_new_input_handler): New function. >>>>> * testsuite/plugin_new_section_layout.c: New plugin to test >>>>> new_input plugin API. >>>>> * testsuite/plugin_final_layout.sh: Add new input test. >>>>> * testsuite/Makefile.am (plugin_layout_new_file): New test case. >>>>> * testsuite/Makefile.in: Regenerate. >>>> >>>> These are OK. Thanks! >>>> >>>> Sri, I'm out of town through 11/18, and won't be able to commit the >>>> include/ patch to GCC before Stage 1 ends. Can you take care of it? >>>> (If not, I'll take care of it when I get back -- it was approved >>>> during Stage 1, so I think it's OK to commit early in Stage 3, >>>> especially since it's nothing but new declarations.) >>> >>> Stephen, I was looking at binutils and realized this patch has not >>> been committed yet. I only committed the GCC portion, plugin-api.h. >>> >>> Thanks >>> Sri >>> >>>> >>>> -cary