From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31694 invoked by alias); 14 Feb 2014 17:38:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31679 invoked by uid 89); 14 Feb 2014 17:38:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-ig0-f172.google.com Received: from mail-ig0-f172.google.com (HELO mail-ig0-f172.google.com) (209.85.213.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 14 Feb 2014 17:38:18 +0000 Received: by mail-ig0-f172.google.com with SMTP id k19so1260300igc.5 for ; Fri, 14 Feb 2014 09:38:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=EtfDWW6YLjwwPG54b7yg6m5m1U1q/AxuO4Ub+PzxC4A=; b=dhH5PJvvTfXPwl2rKyqZL7gvM3gFs8pn2ECe1J/fEshMbqmqGucrXuTL70gC3k7ymI 4BOwDw07NkdAV38UMdU72bKXEtRRg8qtarni4n+u+u7uwmW1BFAX9y4CT6prT5vOWfwr ++XkthUkhxcQbS+SXNVEbRG/Y1/KNIpmF4NyrL2jyDKrid3Z2E+7SL9w2BCbKVlFgrsT BDcrMbTxb+HXU3M1w0KS5sM7Bv5M3GqS8bPOCRVZl+GDGKX90i3KsCW95g0IjXX9lMeC EOG4nfxv2BdkcB+R8Tos9qfCBMqPBKmwuuao8NCx5VMVZfrYu/VgUDRk7p8VxhL3IQjP qF3g== X-Gm-Message-State: ALoCoQkCRlTTjgqk38z5lJhlXFAcdP5mlh8V7b+U4T1twx6d41DI0mfl8USGnj8G5X8HdwO0RKhdr9jAAYbPYchLKlQiId6vJXNBdJJpepJDyhdutmlidABN7KD+SeXPI6oTMAh+ubDUZWTV0Xcnn20JyRCzd7PBeqFEou5I/XZDUFXHx5HG65uKt6uaSP3eb8kwthIHYjy1LPpran6MVmrtIZ8jdTrP0A== X-Received: by 10.50.137.100 with SMTP id qh4mr3987360igb.4.1392399497009; Fri, 14 Feb 2014 09:38:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.240.3 with HTTP; Fri, 14 Feb 2014 09:37:56 -0800 (PST) In-Reply-To: References: From: Roland McGrath Date: Fri, 14 Feb 2014 17:38:00 -0000 Message-ID: Subject: Re: [PATCH] x86: Use ud2 assembly mnemonic when available. To: Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 X-SW-Source: 2014-02/txt/msg00936.txt.bz2 On Thu, Feb 13, 2014 at 10:58 PM, Uros Bizjak wrote: > You forgot to tell us how the patch tested... Right. It's a pretty obviously harmless change. I tested that the configure check passes with binutils-2.22, and eyeball'd a -S compile of a trivial function calling __builtin_trap() to see it uses the mnemonic. I don't have ready access to an assembler that does not support the mnemonic, so I simulated the negative case by momentarily hacking configure to try 'ud2x' instead of 'ud2' and verified that this configure check failed and that for the same trivial function it then emits '.value 0x0b0f' as before. > OK for mainline and release branches. Committed to trunk and 4.8. Thanks, Roland