From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5277 invoked by alias); 7 Aug 2014 13:18:58 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5249 invoked by uid 89); 7 Aug 2014 13:18:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-yh0-f42.google.com Received: from mail-yh0-f42.google.com (HELO mail-yh0-f42.google.com) (209.85.213.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Thu, 07 Aug 2014 13:18:51 +0000 Received: by mail-yh0-f42.google.com with SMTP id a41so2941079yho.29 for ; Thu, 07 Aug 2014 06:18:49 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.236.14.34 with SMTP id c22mr4548606yhc.97.1407417529491; Thu, 07 Aug 2014 06:18:49 -0700 (PDT) Received: by 10.170.85.194 with HTTP; Thu, 7 Aug 2014 06:18:49 -0700 (PDT) In-Reply-To: <53E24E47.2090803@grosser.es> References: <53E24E47.2090803@grosser.es> Date: Thu, 07 Aug 2014 13:18:00 -0000 Message-ID: Subject: Re: [GSoC] Elimination of CLooG library installation dependency From: Roman Gareev To: Tobias Grosser Cc: Mircea Namolaru , gcc-patches@gcc.gnu.org Content-Type: multipart/mixed; boundary=089e013a29dae57bac050009edab X-SW-Source: 2014-08/txt/msg00807.txt.bz2 --089e013a29dae57bac050009edab Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 4966 > To commit 2), I would like you to run a wider set of tests (e.g., the LLVM > test suite). If this passes successful, we should give a headsup on the G= CC > mailing list and ask other people to try the new isl support. > If now bugs have found, we switch. I've tested the modified version of Graphite using the LLVM test suite and found out regression only in two test cases: /llvm-test-suite/MultiSource/Benchmarks/ASC_Sequoia/CrystalMk/Crystal_Chole= sky.c, /llvm-test suite/MultiSource/Benchmarks/Bullet Compilation of /llvm-test-suite/MultiSource/Benchmarks/ASC_Sequoia/CrystalM= k/Crystal_Cholesky.c produces the following error message: /home/roman/llvm-test-suite/MultiSource/Benchmarks/ASC_Sequoia/CrystalMk/Cr= ystal_Cholesky.c /home/roman/llvm-test-suite/MultiSource/Benchmarks/Bullet Crystal_Cholesky.c: In function =E2=80=98Crystal_Cholesky=E2=80=99: Crystal_Cholesky.c:16:6: internal compiler error: in operator[], at vec.h:7= 36 void Crystal_Cholesky(int nSlip, ^ 0xf1d080 vec::operator[](unsigned int) /home/roman/sec_trunk/gcc/gcc/vec.h:736 0xf1d080 vec::operator[](unsigned int) /home/roman/sec_trunk/gcc/gcc/vec.h:1202 0xf1d080 build_iv_mapping /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:608 0xf1d080 translate_isl_ast_node_user /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:644 0xf1d080 translate_isl_ast /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:734 0xf1c7d0 translate_isl_ast_for_loop /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:441 0xf1c7d0 translate_isl_ast_node_for /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:580 0xf1c7d0 translate_isl_ast /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:727 0xf1c3e0 translate_isl_ast_node_block /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:669 0xf1c3e0 translate_isl_ast /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:738 0xf1c3e0 translate_isl_ast_node_block /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:669 0xf1c3e0 translate_isl_ast /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:738 0xf1c3e0 translate_isl_ast_node_block /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:669 0xf1c3e0 translate_isl_ast /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:738 0xf1c3e0 translate_isl_ast_node_block /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:669 0xf1c3e0 translate_isl_ast /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:738 0xf1c3e0 translate_isl_ast_node_block /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:669 0xf1c3e0 translate_isl_ast /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:738 0xf1c7d0 translate_isl_ast_for_loop /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:441 0xf1c7d0 translate_isl_ast_node_for /home/roman/sec_trunk/gcc/gcc/graphite-isl-ast-to-gimple.c:580 It is caused by the wrong index of the iv_map (its value is 12), which is greater than its size (its value is equal to loop->num =3D 8 plus one). I think that we should use the value of number_of_loops for the size of the iv_map (the attached patch implements this), because it is proven to be robust. What do you think about this? The second error is produced by the executable, which is successfully compiled by /llvm-test-suite/MultiSource/Benchmarks/Bullet: =E2=80=9CSegmentation fault (core dumped)=E2=80=9D. I've used gdb to print = stack trace: Segmentation fault (core dumped) ore was generated by `./bullet.simple'. Program terminated with signal 11, Segmentation fault. #0 upcast (colObj=3D0x0) at /home/roman/llvm-test-suite/MultiSource/Benchmarks/Bullet/include/Bu= lletDynamics/Dynamics/btRigidBody.h:170 170 if (colObj->getInternalType()=3D=3DbtCollisionObject::CO_RIGID_BODY) (gdb) bt #0 upcast (colObj=3D0x0) at /home/roman/llvm-test-suite/MultiSource/Benchmarks/Bullet/include/Bu= lletDynamics/Dynamics/btRigidBody.h:170 #1 saveKinematicState (timeStep=3D, this=3D) at /home/roman/llvm-test-suite/MultiSource/Benchmarks/Bullet/btDiscrete= DynamicsWorld.cpp:113 #2 btDiscreteDynamicsWorld::stepSimulation (this=3D0x14a6ca0, timeStep=3D0.0166666675, maxSubSteps=3D1, fixedTimeStep=3D0.0166666675) at /home/roman/llvm-test-suite/MultiSource/Benchmarks/Bullet/btDiscrete= DynamicsWorld.cpp:333 #3 0x0000000000401ed8 in BenchmarkDemo::clientMoveAndDisplay ( this=3D0x7fff90475840) at /home/roman/llvm-test-suite/MultiSource/Benchmarks/Bullet/BenchmarkD= emo.cpp:232 #4 0x0000000000401bd2 in main (argc=3D, argv=3D) at /home/roman/llvm-test-suite/MultiSource/Benchmarks/Bullet/main.cpp:63 The executable is produced by compilation of 317 files. That's why I think that it is be better to temporary postpone the consideration. What do you think about this? --=20 Cheers, Roman Gareev. --089e013a29dae57bac050009edab Content-Type: text/plain; charset=US-ASCII; name="ChangeLog_entry.txt" Content-Disposition: attachment; filename="ChangeLog_entry.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hyk3ywud0 Content-length: 322 MjAxNC0wOC0wNyAgUm9tYW4gR2FyZWV2ICA8Z2FyZWV2cm9tYW5AZ21haWwu Y29tPgoKW2djYy9dCgoJKiBncmFwaGl0ZS1pc2wtYXN0LXRvLWdpbXBsZS5j OgoJKHRyYW5zbGF0ZV9pc2xfYXN0X25vZGVfdXNlcik6IFVzZSBuYl9sb29w cyBpbnN0ZWFkIG9mIGxvb3AtPm51bSArIDEuCgpbZ2NjL3Rlc3RzdWl0ZV0K CgkqIGdjYy5kZy9ncmFwaGl0ZS9pc2wtYXN0LWdlbi11c2VyLTEuYzogTmV3 IHRlc3RjYXNlLgo= --089e013a29dae57bac050009edab Content-Type: text/plain; charset=US-ASCII; name="patch.txt" Content-Disposition: attachment; filename="patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hyk3ywum1 Content-length: 3551 SW5kZXg6IGdjYy9ncmFwaGl0ZS1pc2wtYXN0LXRvLWdpbXBsZS5jCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIGdjYy9ncmFwaGl0ZS1pc2wtYXN0LXRv LWdpbXBsZS5jCShyZXZpc2lvbiAyMTM2OTApCisrKyBnY2MvZ3JhcGhpdGUt aXNsLWFzdC10by1naW1wbGUuYwkod29ya2luZyBjb3B5KQpAQCAtNjMyLDkg KzYzMiw5IEBACiAgIGdjY19hc3NlcnQgKEdCQl9CQiAoZ2JiKSAhPSBFTlRS WV9CTE9DS19QVFJfRk9SX0ZOIChjZnVuKSAmJgogCSAgICAgICJUaGUgZW50 cnkgYmxvY2sgc2hvdWxkIG5vdCBldmVuIGFwcGVhciB3aXRoaW4gYSBzY29w Iik7CiAKLSAgbG9vcF9wIGxvb3AgPSBnYmJfbG9vcCAoZ2JiKTsKLSAgaXZf bWFwLmNyZWF0ZSAobG9vcC0+bnVtICsgMSk7Ci0gIGl2X21hcC5zYWZlX2dy b3dfY2xlYXJlZCAobG9vcC0+bnVtICsgMSk7CisgIGludCBuYl9sb29wcyA9 IG51bWJlcl9vZl9sb29wcyAoY2Z1bik7CisgIGl2X21hcC5jcmVhdGUgKG5i X2xvb3BzKTsKKyAgaXZfbWFwLnNhZmVfZ3Jvd19jbGVhcmVkIChuYl9sb29w cyk7CiAKICAgYnVpbGRfaXZfbWFwcGluZyAoaXZfbWFwLCBnYmIsIHVzZXJf ZXhwciwgaXAsIFNDT1BfUkVHSU9OIChwYmItPnNjb3ApKTsKICAgaXNsX2Fz dF9leHByX2ZyZWUgKHVzZXJfZXhwcik7CkluZGV4OiBnY2MvdGVzdHN1aXRl L2djYy5kZy9ncmFwaGl0ZS9pc2wtYXN0LWdlbi11c2VyLTEuYwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBnY2MvdGVzdHN1aXRlL2djYy5kZy9ncmFw aGl0ZS9pc2wtYXN0LWdlbi11c2VyLTEuYwkocmV2aXNpb24gMCkKKysrIGdj Yy90ZXN0c3VpdGUvZ2NjLmRnL2dyYXBoaXRlL2lzbC1hc3QtZ2VuLXVzZXIt MS5jCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNjMgQEAKKy8qIHsgZGct ZG8gY29tcGlsZSB9ICovCisvKiB7IGRnLW9wdGlvbnMgIi1PMiAtZmdyYXBo aXRlLWlkZW50aXR5IC1mZ3JhcGhpdGUtY29kZS1nZW5lcmF0b3I9aXNsIiB9 ICovCisKKyNpbmNsdWRlIDxzdGRpby5oPgorI2luY2x1ZGUgPHN0ZGxpYi5o PgorCitzdGF0aWMgY29uc3QgaW50ICBNU19YVEFMX05TTElQX01BWCA9IDEy OworCisvLy0tLS0tLS0tLS0tLS0tIAorLy8gIHRlc3QgQ2hvbGVza3kgc29s dmVyIG9uIG1hdHJpeAorLy8tLS0tLS0tLS0tLS0tLSAKK3ZvaWQgQ3J5c3Rh bF9DaG9sZXNreShpbnQgblNsaXAsICAKKyAgICAgICAgICAgICAgICAgICAg ICBkb3VibGUgYVtNU19YVEFMX05TTElQX01BWF1bTVNfWFRBTF9OU0xJUF9N QVhdLAorICAgICAgICAgICAgICAgICAgICAgIGRvdWJsZSByW01TX1hUQUxf TlNMSVBfTUFYXSwKKyAgICAgICAgICAgICAgICAgICAgICBkb3VibGUgZ1tN U19YVEFMX05TTElQX01BWF0pCit7CisgICBpbnQgaSwgaiwgazsKKyAgIGRv dWJsZSBmZG90OworCisgICAKKyAgICAgIC8qIHRyYW5zZmVyIHJocyB0byBz b2x1dGlvbiB2ZWN0b3IgdG8gcHJlc2VydmUgcmhzICovCisgICBmb3IgKCBp ID0gMDsgaSA8IG5TbGlwOyBpKyspIGdbaV0gPSByW2ldOworICAgICAgCisg ICAgICAvKiBtYXRyaXggcmVkdWN0aW9uICovCisgICBmb3IgKCBpID0gMTsg aSA8IG5TbGlwOyBpKyspCisgICAgICBhW2ldWzBdID0gYVtpXVswXSAvIGFb MF1bMF07CisKKworICAgZm9yICggaSA9IDE7IGkgPCBuU2xpcDsgaSsrKXsK KyAgICAgIGZkb3QgPSAwLjA7CisgICAgICBmb3IgKCBrID0gMDsgayA8IGk7 IGsrKykKKyAgICAgICAgIGZkb3QgKz0gYVtpXVtrXSAqIGFba11baV07Cisg ICAgICBhW2ldW2ldID0gYVtpXVtpXSAtIGZkb3Q7CisgICAgICBmb3IgKCBq ID0gaSsxOyBqIDwgblNsaXA7IGorKyl7CisgICAgICAgICBmZG90ID0gMC4w OworICAgICAgICAgZm9yICggayA9IDA7IGsgPCBpOyBrKyspCisgICAgICAg ICAgICBmZG90ICs9IGFbaV1ba10gKiBhW2tdW2pdOworICAgICAgICAgYVtp XVtqXSA9IGFbaV1bal0gLSBmZG90OworICAgICAgICAgZmRvdCA9IDAuMDsK KyAgICAgICAgIGZvciAoIGsgPSAwOyBrIDwgaTsgaysrKQorICAgICAgICAg ICAgZmRvdCArPSBhW2pdW2tdICogYVtrXVtpXTsKKyAgICAgICAgIGFbal1b aV0gPSAoIGFbal1baV0gLSBmZG90KSAvIGFbaV1baV07CisgICAgICB9Cisg ICB9CisKKyAgIAorICAgICAgLyogZm9yd2FyZCByZWR1Y3Rpb24gb2YgUkhT ICovCisgICBmb3IgKCBpID0gMTsgaSA8IG5TbGlwOyBpKysgKXsKKyAgICAg IGZvciAoIGsgPSAwOyBrIDwgaTsgaysrKQorICAgICAgICAgZ1tpXSA9IGdb aV0gLSBhW2ldW2tdICogZ1trXTsKKyAgIH0gCisgICAKKyAgICAgIC8qIGJh Y2sgc3Vic3RpdHV0aW9uICovCisgICBnW25TbGlwLTFdID0gZ1tuU2xpcC0x XSAvIGFbblNsaXAtMV1bblNsaXAtMV07CisgICBmb3IgKCBpID0gblNsaXAg LSAyOyBpID49IDA7IGk9aS0xKXsKKyAgICAgIGZvciAoIGsgPSBpKzE7IGsg PCBuU2xpcDsgaysrKQorICAgICAgICAgZ1tpXSA9IGdbaV0gLSBhW2ldW2td Kmdba107CisgICAgICBnW2ldID0gZ1tpXSAvIGFbaV1baV07CisgICB9Cit9 CisKKworCg== --089e013a29dae57bac050009edab--