On Tue, 25 Sep 2018 at 00:58, Iain Buclaw wrote: > > On 24 September 2018 at 20:28, Mike Stump wrote: > > On Sep 21, 2018, at 2:38 PM, Iain Buclaw wrote: > >> > >> On 21 September 2018 at 22:54, Mike Stump wrote: > >>> On Sep 17, 2018, at 5:36 PM, Iain Buclaw wrote: > >>>> > >>>> This patch adds part of the D2 testsuite, which includes D source code > >>>> files that are considered compilable; files that are considered > >>>> uncompilable, but should not ICE; and files that should execute on > >>>> targets with crash or assertion failures. > >>> > >>> Ok. [ not needed, you can self-review things like this no problem ] > >>> > >>> I see you are sneaking in Alice in Wonderland... > >>> > >> > >> I had forgotten about that test. I recall another project written in > >> D (Dustmite) ran into some trouble with Debian due to the Project > >> Gutenberg small print, which they ended up removing. > >> > >> The "small print" section in the text file says: > >> > >> DISTRIBUTION UNDER "PROJECT GUTENBERG-tm" > >> You may distribute copies of this etext electronically, or by > >> disk, book or any other medium if you either delete this > >> "Small Print!" and all other references to Project Gutenberg, > >> or: > >> [...] > >> > >> I'll look into convincing upstream to also do the same. > > > > Oh, if you know of any reason why a file cannot be distributed, you cannot check that in ever. So, you must resolve any outstanding issues before committing. So, if Gutenberg has restrictions on distribution, you have to resolve those first, before it hit git. > > > > If it had hit git, please either remove such for now until resolved, or resolve any issues. Thanks. > > As I said a day later, I've pushed the removal of in upstream and have > propagated it down. Thanks for noticing though, had you not mentioned > Alice, I would not have had remembered the trouble Dustmite had with > Debian in the first place. > Attaching the diff to the original, rather than the whole patch again. Only other change apart from noted small print removal is supporting a COMPILED_IMPORTS option in test sources. Regards -- Iain ---