From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64163 invoked by alias); 7 Dec 2018 19:12:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 64150 invoked by uid 89); 7 Dec 2018 19:12:09 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,GIT_PATCH_2,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Envelope-From:sk:ibuclaw, H*F:U*ibuclaw X-HELO: mail-qk1-f181.google.com Received: from mail-qk1-f181.google.com (HELO mail-qk1-f181.google.com) (209.85.222.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Dec 2018 19:12:07 +0000 Received: by mail-qk1-f181.google.com with SMTP id q70so3059422qkh.6 for ; Fri, 07 Dec 2018 11:12:07 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Iain Buclaw Date: Fri, 07 Dec 2018 19:12:00 -0000 Message-ID: Subject: Re: Pass GDCFLAGS and CCASFLAGS to libphobos subdirs To: ro@cebitec.uni-bielefeld.de Cc: gcc-patches Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-12/txt/msg00499.txt.bz2 On Fri, 7 Dec 2018 at 14:30, Rainer Orth wrote: > > When trying to rebuild libphobos with -g3 -O0 for better debugging, I > noticed that GDCFLAGS weren't passed down as expected. It turned out > that they are missing from AM_MAKEFLAGS. After I fixed this, the only > file still compiled with -g -O2 was libdruntime/core/threadasm.S, so I > added CCASFLAGS, too. > > Tested on i386-pc-solaris2.11. Ok for mainline? > > Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University > > > 2018-12-06 Rainer Orth > > * Makefile.am (AM_MAKEFLAGS): Pass CCASFLAGS, GDCFLAGS. > * Makefile.in: Regenerate. > Thanks, looks good to me. -- Iain