From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18174 invoked by alias); 25 Apr 2017 16:50:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18114 invoked by uid 89); 25 Apr 2017 16:50:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=x0a, (unknown) X-HELO: mail-vk0-f43.google.com Received: from mail-vk0-f43.google.com (HELO mail-vk0-f43.google.com) (209.85.213.43) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Apr 2017 16:50:28 +0000 Received: by mail-vk0-f43.google.com with SMTP id k4so55819041vki.1 for ; Tue, 25 Apr 2017 09:50:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=s69d+no9CQJSoRPuJueFCgbc1sN9JwMj9+4cKVXgkhQ=; b=cCgsqO3aAmrtb78EwV5Dyuk7UWpvV3TCPGvY3MXog/ChIWEvhTlRBF2tFslEfQW/lD PAURWo9brKgXwyq/ZuADOIgoX9VEdJPdpTSeO5YkAuLXXI87pXx3U3H7PHbhn9WzL9FK 4M7puH99zMr9BSFxuhvBmV+f/WTchTbB5eI3Ztv4OHa0j76yD2IgYcmVCi5LMEtETo8w 4Plb3vsXw31ZMxtlU2MxsCeEazzZB5I4fHlEFtVW8353qbUNtDwD9YGbM96bODnfD43S 8S2mM7/a3FLxP0sSDmwwUwwJuXlYKcy4LXsp38OFb0EqKStuh11CBOtpPHNXge2h0dwM QnUQ== X-Gm-Message-State: AN3rC/6/tOTLKhnAZh3vzbGGvBfwxPrGKDyW58SHkGYbGmMMrEDcCRyf uu3NLJiQdFjhGUN3/cY7WC1HY5dHTg== X-Received: by 10.31.216.135 with SMTP id p129mr546401vkg.22.1493139028819; Tue, 25 Apr 2017 09:50:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.41.142 with HTTP; Tue, 25 Apr 2017 09:50:27 -0700 (PDT) In-Reply-To: References: From: Iain Buclaw Date: Tue, 25 Apr 2017 16:59:00 -0000 Message-ID: Subject: Re: [PATCH 4/7] [D] libiberty: Remove wrongly spec'd mangle rule for encoded integers. To: gcc-patches Content-Type: multipart/mixed; boundary=001a114ef9b26a296c054e008512 X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg01244.txt.bz2 --001a114ef9b26a296c054e008512 Content-Type: text/plain; charset=UTF-8 Content-length: 526 On 20 April 2017 at 20:58, Iain Buclaw wrote: > > Hmm, it seems like D compilers until 3 years ago infact used to mangle > in this way. Better keep it around then for a little while longer for > compatibility. I'll follow-up with an amendment which doesn't remove > the cases, instead adding an explanatory comment on why it's present, > but still fixing up the coverage tests anyway, as they should try to > reflect as close to actual mangling as possible. > > -- > Iain. Attaching patch v2. --- --001a114ef9b26a296c054e008512 Content-Type: text/x-patch; charset=US-ASCII; name="04-demangle-value-integers-2.patch" Content-Disposition: attachment; filename="04-demangle-value-integers-2.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j1xsf2e50 Content-length: 4462 QXV0aG9yOiBJYWluIEJ1Y2xhdyA8aWJ1Y2xhd0BnZGNwcm9qZWN0Lm9yZz4K RGF0ZTogICBUdWUgQXByIDI1IDE4OjQzOjM1IDIwMTcgKzAyMDAKCiAgICBs aWJpYmVydHkvQ2hhbmdlTG9nOgogICAgCiAgICAyMDE3LTA0LTE1ICBJYWlu IEJ1Y2xhdyAgPGlidWNsYXdAZ2RjcHJvamVjdC5vcmc+CiAgICAKICAgIAkq IGQtZGVtYW5nbGUuYyAoZGxhbmdfdmFsdWUpOiBGaXggY29tbWVudCB0byBj bGFyaWZ5IHdoeSBjYXNlcyBmb3IKCWRpZ2l0cyBhcmUgcmVxdWlyZWQuCiAg ICAJKiB0ZXN0c3VpdGUvZC1kZW1hbmdsZS1leHBlY3RlZDogVXBkYXRlIGlu dGVnZXIgdmFsdWUgdGVzdHMuCgpkaWZmIC0tZ2l0IGEvbGliaWJlcnR5L2Qt ZGVtYW5nbGUuYyBiL2xpYmliZXJ0eS9kLWRlbWFuZ2xlLmMKaW5kZXggMTI0 NTdmMC4uMzI2MzNmNSAxMDA2NDQKLS0tIGEvbGliaWJlcnR5L2QtZGVtYW5n bGUuYworKysgYi9saWJpYmVydHkvZC1kZW1hbmdsZS5jCkBAIC0xMjQ0LDYg KzEyNDQsMTAgQEAgZGxhbmdfdmFsdWUgKHN0cmluZyAqZGVjbCwgY29uc3Qg Y2hhciAqbWFuZ2xlZCwgY29uc3QgY2hhciAqbmFtZSwgY2hhciB0eXBlKQog ICAgICAgaWYgKCptYW5nbGVkIDwgJzAnIHx8ICptYW5nbGVkID4gJzknKQog CXJldHVybiBOVUxMOwogICAgICAgLyogRmFsbCB0aHJvdWdoICovCisKKyAg ICAvKiBUaGVyZSByZWFsbHkgc2hvdWxkIGFsd2F5cyBiZSBhbiBgaScgYmVm b3JlIGVuY29kZWQgbnVtYmVycywgYnV0IHRoZXJlCisgICAgICAgd2Fzbid0 IGluIGVhcmx5IHZlcnNpb25zIG9mIEQyLCBzbyB0aGlzIGNhc2UgcmFuZ2Ug bXVzdCByZW1haW4gZm9yCisgICAgICAgYmFja3dhcmRzIGNvbXBhdGliaWxp dHkuICAqLwogICAgIGNhc2UgJzAnOiBjYXNlICcxJzogY2FzZSAnMic6IGNh c2UgJzMnOiBjYXNlICc0JzoKICAgICBjYXNlICc1JzogY2FzZSAnNic6IGNh c2UgJzcnOiBjYXNlICc4JzogY2FzZSAnOSc6CiAgICAgICBtYW5nbGVkID0g ZGxhbmdfcGFyc2VfaW50ZWdlciAoZGVjbCwgbWFuZ2xlZCwgdHlwZSk7CmRp ZmYgLS1naXQgYS9saWJpYmVydHkvdGVzdHN1aXRlL2QtZGVtYW5nbGUtZXhw ZWN0ZWQgYi9saWJpYmVydHkvdGVzdHN1aXRlL2QtZGVtYW5nbGUtZXhwZWN0 ZWQKaW5kZXggMDRkMzlmNC4uNjE2Y2YwZiAxMDA2NDQKLS0tIGEvbGliaWJl cnR5L3Rlc3RzdWl0ZS9kLWRlbWFuZ2xlLWV4cGVjdGVkCisrKyBiL2xpYmli ZXJ0eS90ZXN0c3VpdGUvZC1kZW1hbmdsZS1leHBlY3RlZApAQCAtNjUwLDM1 ICs2NTAsMzUgQEAgX0Q4ZGVtYW5nbGUxM19fVDR0ZXN0VlBpblp2CiBkZW1h bmdsZS50ZXN0IShudWxsKQogIwogLS1mb3JtYXQ9ZGxhbmcKLV9EOGRlbWFu Z2xlMTRfX1Q0dGVzdFZnMTIzWnYKK19EOGRlbWFuZ2xlMTVfX1Q0dGVzdFZn aTEyM1p2CiBkZW1hbmdsZS50ZXN0ISgxMjMpCiAjCiAtLWZvcm1hdD1kbGFu ZwotX0Q4ZGVtYW5nbGUxNF9fVDR0ZXN0VmkxMjNadgorX0Q4ZGVtYW5nbGUx NV9fVDR0ZXN0VmlpMTIzWnYKIGRlbWFuZ2xlLnRlc3QhKDEyMykKICMKIC0t Zm9ybWF0PWRsYW5nCi1fRDhkZW1hbmdsZTE0X19UNHRlc3RWczEyM1p2Citf RDhkZW1hbmdsZTE1X19UNHRlc3RWc2kxMjNadgogZGVtYW5nbGUudGVzdCEo MTIzKQogIwogLS1mb3JtYXQ9ZGxhbmcKLV9EOGRlbWFuZ2xlMTRfX1Q0dGVz dFZoMTIzWnYKK19EOGRlbWFuZ2xlMTVfX1Q0dGVzdFZoaTEyM1p2CiBkZW1h bmdsZS50ZXN0ISgxMjN1KQogIwogLS1mb3JtYXQ9ZGxhbmcKLV9EOGRlbWFu Z2xlMTRfX1Q0dGVzdFZrMTIzWnYKK19EOGRlbWFuZ2xlMTVfX1Q0dGVzdFZr aTEyM1p2CiBkZW1hbmdsZS50ZXN0ISgxMjN1KQogIwogLS1mb3JtYXQ9ZGxh bmcKLV9EOGRlbWFuZ2xlMTRfX1Q0dGVzdFZ0MTIzWnYKK19EOGRlbWFuZ2xl MTVfX1Q0dGVzdFZ0aTEyM1p2CiBkZW1hbmdsZS50ZXN0ISgxMjN1KQogIwog LS1mb3JtYXQ9ZGxhbmcKLV9EOGRlbWFuZ2xlMTRfX1Q0dGVzdFZsMTIzWnYK K19EOGRlbWFuZ2xlMTVfX1Q0dGVzdFZsaTEyM1p2CiBkZW1hbmdsZS50ZXN0 ISgxMjNMKQogIwogLS1mb3JtYXQ9ZGxhbmcKLV9EOGRlbWFuZ2xlMTRfX1Q0 dGVzdFZtMTIzWnYKK19EOGRlbWFuZ2xlMTVfX1Q0dGVzdFZtaTEyM1p2CiBk ZW1hbmdsZS50ZXN0ISgxMjN1TCkKICMKIC0tZm9ybWF0PWRsYW5nCkBAIC02 OTgsMzUgKzY5OCwzNSBAQCBfRDhkZW1hbmdsZTE1X19UNHRlc3RWbU4xMjNa dgogZGVtYW5nbGUudGVzdCEoLTEyM3VMKQogIwogLS1mb3JtYXQ9ZGxhbmcK LV9EOGRlbWFuZ2xlMTJfX1Q0dGVzdFZiMVp2CitfRDhkZW1hbmdsZTEzX19U NHRlc3RWYmkxWnYKIGRlbWFuZ2xlLnRlc3QhKHRydWUpCiAjCiAtLWZvcm1h dD1kbGFuZwotX0Q4ZGVtYW5nbGUxMl9fVDR0ZXN0VmIwWnYKK19EOGRlbWFu Z2xlMTNfX1Q0dGVzdFZiaTBadgogZGVtYW5nbGUudGVzdCEoZmFsc2UpCiAj CiAtLWZvcm1hdD1kbGFuZwotX0Q4ZGVtYW5nbGUxM19fVDR0ZXN0VmExMFp2 CitfRDhkZW1hbmdsZTE0X19UNHRlc3RWYWkxMFp2CiBkZW1hbmdsZS50ZXN0 ISgnXHgwYScpCiAjCiAtLWZvcm1hdD1kbGFuZwotX0Q4ZGVtYW5nbGUxM19f VDR0ZXN0VmEzMlp2CitfRDhkZW1hbmdsZTE0X19UNHRlc3RWYWkzMlp2CiBk ZW1hbmdsZS50ZXN0ISgnICcpCiAjCiAtLWZvcm1hdD1kbGFuZwotX0Q4ZGVt YW5nbGUxM19fVDR0ZXN0VmE2NVp2CitfRDhkZW1hbmdsZTE0X19UNHRlc3RW YWk2NVp2CiBkZW1hbmdsZS50ZXN0ISgnQScpCiAjCiAtLWZvcm1hdD1kbGFu ZwotX0Q4ZGVtYW5nbGUxNF9fVDR0ZXN0VmExMjZadgorX0Q4ZGVtYW5nbGUx NV9fVDR0ZXN0VmFpMTI2WnYKIGRlbWFuZ2xlLnRlc3QhKCd+JykKICMKIC0t Zm9ybWF0PWRsYW5nCi1fRDhkZW1hbmdsZTE1X19UNHRlc3RWdTEwMDBadgor X0Q4ZGVtYW5nbGUxNl9fVDR0ZXN0VnVpMTAwMFp2CiBkZW1hbmdsZS50ZXN0 ISgnXHUwM2U4JykKICMKIC0tZm9ybWF0PWRsYW5nCi1fRDhkZW1hbmdsZTE3 X19UNHRlc3RWdzEwMDAwMFp2CitfRDhkZW1hbmdsZTE4X19UNHRlc3RWd2kx MDAwMDBadgogZGVtYW5nbGUudGVzdCEoJ1xVMDAwMTg2YTAnKQogIwogLS1m b3JtYXQ9ZGxhbmcKQEAgLTEwMjAsNyArMTAyMCw3IEBAIF9EOGRlbWFuZ2xl MjBfX1QyZm5WQWlBNGkxaTJpM2k0WjJmbkZadgogZGVtYW5nbGUuZm4hKFsx LCAyLCAzLCA0XSkuZm4oKQogIwogLS1mb3JtYXQ9ZGxhbmcKLV9EOGRlbWFu Z2xlMTBfX1QyZm5WaTFaMmZuRlp2CitfRDhkZW1hbmdsZTExX19UMmZuVmlp MVoyZm5GWnYKIGRlbWFuZ2xlLmZuISgxKS5mbigpCiAjCiAtLWZvcm1hdD1k bGFuZwo= --001a114ef9b26a296c054e008512--