From: Iain Buclaw <ibuclaw@gdcproject.org>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Rainer Orth <ro@cebitec.uni-bielefeld.de>,
Mike Stump <mikestump@comcast.net>,
Andrew Stubbs <ams@codesourcery.com>,
David Malcolm <dmalcolm@redhat.com>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920, take 2)
Date: Wed, 13 Feb 2019 19:08:00 -0000 [thread overview]
Message-ID: <CABOHX+dQeTmN6SGEu0FdOFYuFyB6YEiQvWqVjyTv-cBUf0V=cg@mail.gmail.com> (raw)
In-Reply-To: <20190213133748.GZ2135@tucnak>
On Wed, 13 Feb 2019 at 14:37, Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Wed, Feb 13, 2019 at 10:22:14AM +0000, Andrew Stubbs wrote:
> > On 13/02/2019 09:09, Jakub Jelinek wrote:
> > > To make it work together with doing llvm_binutils only once, the global now
> > > has multiple values
> > > 0 - disallow blank lines
> > > 1 - allow them for a single test only, reset after testing it in gcc-dg-prune
> > > 2 - allow it for all tests (llvm_binutils)
> >
> > FWIW, this scheme and patch looks good to me, although probably the meaning
> > of the numbers ought to be documented somewhere in the code.
>
> Here is an updated patch that documents it. Bootstrapped/regtested on
> x86_64-linux and i686-linux, ok for trunk?
>
I have no objections.
Iain.
next prev parent reply other threads:[~2019-02-13 19:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 9:09 [PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920) Jakub Jelinek
2019-02-13 10:22 ` Andrew Stubbs
2019-02-13 13:37 ` [PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920, take 2) Jakub Jelinek
2019-02-13 19:08 ` Iain Buclaw [this message]
2019-02-13 19:17 ` David Malcolm
2019-02-15 3:31 ` Mike Stump
2019-02-15 3:30 ` [PATCH] Fix up and improve allow_blank_lines testsuite handling (PR other/69006, PR testsuite/88920) Mike Stump
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABOHX+dQeTmN6SGEu0FdOFYuFyB6YEiQvWqVjyTv-cBUf0V=cg@mail.gmail.com' \
--to=ibuclaw@gdcproject.org \
--cc=ams@codesourcery.com \
--cc=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=mikestump@comcast.net \
--cc=ro@cebitec.uni-bielefeld.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).