From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb1-xb2d.google.com (mail-yb1-xb2d.google.com [IPv6:2607:f8b0:4864:20::b2d]) by sourceware.org (Postfix) with ESMTPS id 416B6386181B for ; Wed, 18 Oct 2023 14:42:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 416B6386181B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 416B6386181B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::b2d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697640154; cv=none; b=AqlXeJQrGYNfdkFscyNMO8pZNQ/+DWUB+HSyxqIs/47Go/ok4sTe19Jfll0eh6/D/4InNQMy0/ZgGouV5B1bOBdc/iWUh8dthy/Zk+CkZd3kRSKkZSv7zjScleYIBIubWUq1qfXbqvQygMfY1+YhAKDzLzX/5o5ScALU3LvCciY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697640154; c=relaxed/simple; bh=ZFy9b6mg2kKAXOhxBPMA2vVv415MKpR+/0HmELuMbHY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=xVpwOkXH7vXSooVwgM43C540cuTe0NeILpA8Fyfg3WXXOzz3ulrfNzMavh3v+ult0viix9SJ5ViQ9Q0WhKn3Moa2//pUM8ogXa0S7/ATKclCLTHM3e0PE0xz3QW3/VVl20vo6dJvZS967qDeMmJM+jaBe03TT4OSJOiS0q9y+Og= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-yb1-xb2d.google.com with SMTP id 3f1490d57ef6-d86249de784so1854871276.1 for ; Wed, 18 Oct 2023 07:42:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697640152; x=1698244952; darn=gcc.gnu.org; h=cc:to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=lqOPhZ9j8UhCTxGf1GmzUsjri/wTeFXdprGliYO/DcI=; b=D9PkxjCOXJiJkbSGeN6SVSq9yDEJWpwneOJmByImfEbY0yoL/gAOLfEl51SfoNiTsH kLiai64yrfLCokgCkHXP4GubdSLxTxuHHu2TYDgehyjSyOrG2fyBO8FDex5yjufjV0vR D1pWf3j9yC6PEpg+JuUABrG0NXOVih1RjJeuryz9AW6nC7aBPaqZPZzm7nEAD3T3HH3k qH3GqMzE/6dd8+dH+fMXeQM6jCkeBuPRSJL8zqDtuGcQ8/XgX/abvqyG8T06o8wj9XDB pM1+2W/bRBxuc4ySy6tyOgCu2H1HmTw89SaZaMN6F6xtaeFcTHcCWE5V30MP6iOjoTX/ 8PlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697640152; x=1698244952; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=lqOPhZ9j8UhCTxGf1GmzUsjri/wTeFXdprGliYO/DcI=; b=t00QdJVO7NaThYm5zrA2syb+QPoe5wREdQ7PAQUmU2hB2dQt2pN647GoFDwor1RiZV SUgfqU4cRQlFEJj7augLJCHqq70hYpNfdbrGbBdmC2cIbJJJ0rJr4zciEDzeRpQi+nYi WiLWhx5JNI3DUg9KU4ElVJCsne/hAlH3NdRSNKt99S/+CKFUNDS9b+nBRO5RhDRFJujx 9RYpBAY6RvT/wE4cQae2oEF7uwyBWSlL7/rUOAL3sCX8Sv7pjPWCyMX+k00Y7TNTvi1U /GPFBkvPGxJH6yQJaUOv/pcZKh+EFASmJlRFGyayxufEZYy3MrIcOQm3koteJcj8Ij+F BGWA== X-Gm-Message-State: AOJu0Yzk9A68RVSnHLNgfDRgl0RKwc8weSa+iUXZoqGsgwrGiKJyhOpz y+iWlTQbXR/i7yIiXaxnrLZJtymD+5PG1jnQy0AZ7YH7GMvmxQ== X-Google-Smtp-Source: AGHT+IGtAc0oVcFv5ThJoXmROLjmAu/d3dYHFoBOF+7R54VNUcfZdmb5I5PyT+LD2okvmOULU8VuFz0Q8zKMHlpZ1hw= X-Received: by 2002:a25:238a:0:b0:d9c:3ed7:dd8f with SMTP id j132-20020a25238a000000b00d9c3ed7dd8fmr4739088ybj.4.1697640152596; Wed, 18 Oct 2023 07:42:32 -0700 (PDT) MIME-Version: 1.0 From: David Edelsohn Date: Wed, 18 Oct 2023 10:42:21 -0400 Message-ID: Subject: Re: [PATCH v2] swap: Fix incorrect lane extraction by vec_extract() [PR106770] To: Surya Kumari Jangala Cc: Segher Boessenkool , gcc-patches@gcc.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=0.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi, Surya Thanks for working on this issue and creating a patch. It helps if you explicitly send patches to Segher and me, and copy gcc-patches. +/* Return true if insn is a non-permuting load/store. */ +static bool +non_permuting_mem_insn (swap_web_entry *insn_entry, unsigned int i) +{ + return (insn_entry[i].special_handling == SH_NOSWAP_LD || + insn_entry[i].special_handling == SH_NOSWAP_ST); +} The logical operator || should be at the beginning of the line, not the end. That also ensures correct formatting and indentation. The || should be under the "i" of insn on the line above. It also generally simplifies review to have the ChangeLog in the same order as changes in the file. The order of the files relative to the patch may not be the same, but the ChangeLog entries should be in sequential order relative to the file. This patch is okay with the logical operator formatting change. Thanks, David