From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20486 invoked by alias); 12 Jan 2015 18:28:01 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19911 invoked by uid 89); 12 Jan 2015 18:28:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-ie0-f179.google.com Received: from mail-ie0-f179.google.com (HELO mail-ie0-f179.google.com) (209.85.223.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 12 Jan 2015 18:27:58 +0000 Received: by mail-ie0-f179.google.com with SMTP id rp18so26733189iec.10 for ; Mon, 12 Jan 2015 10:27:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=pqfWkCBV9q1LjubNlqzFPFM6I/iy0P2K9SdzrHUoA5o=; b=c5DQSFqeWyXMprqpReQ9jdacHuXxHSp1+/PHrpmyuzGxkOigCnDZJyUr5oNlrDCabd UFNHAUMk47TylNPb5W/0ys9lOQJyZPJM+MMCqCUB6JvFxY3faHZY2IV9anzmqEbrAiJq aS1FYIl25aLxnocokNcr5t86Yjb6U2MzOGbSBwLeJHNjtRzEdQDZFSQN6+X3WtijvK9Z usS+sn7K93rFfPJak4U81MS2gjG3IpTrRXfydLBk3M+/rVTP2K+NYteNrXsPkYUwOOP7 q0tWQ4eBLM0YAfwUeoyiBRjeT8+O0aTgtFl2SNoIf5u6SH4PIxtkNlzLVj2Q+UEH6Azy kIug== X-Gm-Message-State: ALoCoQlB5q57LVWVLUHy8qTfbv/XYH7IdhnuDaQEnQJ2gte+RC0KTOgcUfXmxw/iEnNCeXnxixy1 X-Received: by 10.107.153.147 with SMTP id b141mr29235207ioe.49.1421087275583; Mon, 12 Jan 2015 10:27:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.64.21.193 with HTTP; Mon, 12 Jan 2015 10:27:35 -0800 (PST) In-Reply-To: <54AEE9B0.3010407@rub.de> References: <53FF0C8C.8090507@rub.de> <5411213F.1070104@rub.de> <541B5B7E.2090300@rub.de> <20140923102235.GJ2669@redhat.com> <542344CB.6050600@rub.de> <54369316.7070001@rub.de> <543F9BB8.1040503@rub.de> <54524B43.7000105@rub.de> <5463893D.50807@rub.de> <54639CC5.4050508@rub.de> <5476F20C.5010801@rub.de> <548876B5.70306@rub.de> <54A99E34.2010202@rub.de> <54AEE9B0.3010407@rub.de> From: Caroline Tice Date: Mon, 12 Jan 2015 18:32:00 -0000 Message-ID: Subject: Re: [Ping] Port of VTV for Cygwin and MinGW To: Patrick Wollgast Cc: Kai Tietz , Benjamin De Kosnik , "jwakely@redhat.com >> Jonathan Wakely" , Ian Lance Taylor , GCC Patches , libstdc++@gcc.gnu.org Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00720.txt.bz2 On Thu, Jan 8, 2015 at 12:33 PM, Patrick Wollgast wrote: > A short recap again: > > Latest patch, changelog and a test program (further information about > the program in the mail): > https://gcc.gnu.org/ml/gcc-patches/2014-11/msg03368.html > > > Approved: > * gcc/config/i386/* > * libgcc/* > * libstdc++-v3/* > * libvtv/* (Some changes made to three of these files. > Listed in 'Not approved'.) > > > Not approved: > For the following two files I added checks, if TARGET_PECOFF is defined > ( https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00815.html ) > * gcc/cp/vtable-class-hierarchy.c > * gcc/varasm.c The changes in gcc/cp/vtable-class-hierarchy.c and gcc/varasm.c both look good to me. However I am not authorized to approve stuff in this part of GCC, so I need someone with global approval rights to look at these changes and give the final OK. > > Reasons for changes in the following files stated in > https://gcc.gnu.org/ml/gcc-patches/2014-10/msg00815.html and in the mail > of the latest patch. > > Removed implementation of mprotect. > * libvtv/vtv_malloc.cc > Added extern "C" to the prototype of mprotect. > * libvtv/vtv_malloc.h > Exchanged call to TerminateProcess with call to abort in __fortify_fail. > * libvtv/vtv_rts.cc The changes in libvtv all look good to me (approved). -- Caroline Tice cmtice@google.com > > Has been removed from the most recent patch. Just listed for completeness. > * libiberty/obstack.c > > > Regards, > Patrick