From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 118402 invoked by alias); 29 Apr 2015 18:59:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 118392 invoked by uid 89); 29 Apr 2015 18:59:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mail-vn0-f45.google.com Received: from mail-vn0-f45.google.com (HELO mail-vn0-f45.google.com) (209.85.216.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 29 Apr 2015 18:59:34 +0000 Received: by vnbf190 with SMTP id f190so4563045vnb.1 for ; Wed, 29 Apr 2015 11:59:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=QKsIztB//+zIWSFDk2alWCBpYjTwyIsnJRLhjfzmqrU=; b=XQ2KUWYQGuw2wnGPT2vXml6qI2x2l4vZ0R9hvO/cAvlOH8/T0Mk2AjZJwO/a/LuPar P8Q8U8Sx9FZj1i/He6CNToheWJ61c8Bmjihow6hv3YV401UNsH3IR07PBzQ0XWOJksRm EOmmI6Z+CcRiqTA2nsHHwxEW+VKvRAqKgI1xv4M8m7nXv5PcpkkEtF6AJYt3vBPY7VN4 REKzzeG/dWsBFXB9/tI5SdA+8LPndocJS9E1CulE10Dg0YdAJc+TueRIyuBjWr1Z5kY1 NaEtdAG5vScSLKvF2F7oM+VAGuxunJrwEPJ9ljzLbKaMVwmgeoibbYOrdClVV8XlzChG bi0w== X-Gm-Message-State: ALoCoQmWtlla+P9CyuFm07c11me2358VnqL1IyFJBzfFiYg+CT4zPmxfyvo9tJmNY4Qu2cgbgJk5 X-Received: by 10.52.26.180 with SMTP id m20mr967558vdg.54.1430333972192; Wed, 29 Apr 2015 11:59:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.52.28.46 with HTTP; Wed, 29 Apr 2015 11:59:11 -0700 (PDT) In-Reply-To: References: From: Caroline Tice Date: Wed, 29 Apr 2015 19:08:00 -0000 Message-ID: Subject: Re: [PATCH] Fix size & type for cold partition names (hot-cold function partitioning) To: Uros Bizjak Cc: "gcc-patches@gcc.gnu.org" , Jeff Law , Richard Henderson Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg01919.txt.bz2 Thank you; I will work with your suggestions and try to get a new patch done soon. -- Caroline Tice cmtice@google.com On Wed, Apr 29, 2015 at 11:34 AM, Uros Bizjak wrote: > On Wed, Apr 29, 2015 at 7:47 PM, Uros Bizjak wrote: >> On Wed, Apr 29, 2015 at 7:38 PM, Caroline Tice wrote: >>> The attached patch can revert the previous patch, if that is the way >>> we should proceed on this. If you want me to apply the reversion, >>> please let me know. >>> >>> I would be happy to fix to the problem, rather than just reverting the >>> patch, but I do not have expertise in assembly language on other >>> platforms, so I would need some help, if anyone would be interested in >>> helping me? >> >> How about adding ASM_DECLARE_COLD_FUNCTION_NAME and >> ASM_DECLARE_COLD_FUNCTION_SIZE? If these are defined, they can be used >> instead, and targets are free to define them in any way. > > Something like the attached prototype RFC patch. Using this patch, > readelf -sW returns: > > Symbol table '.symtab' contains 18 entries: > Num: Value Size Type Bind Vis Ndx Name > 0: 0000000000000000 0 NOTYPE LOCAL DEFAULT UND > 1: 0000000000000000 0 SECTION LOCAL DEFAULT 1 > 2: 0000000000000000 0 SECTION LOCAL DEFAULT 3 > 3: 0000000000000000 0 SECTION LOCAL DEFAULT 4 > 4: 0000000000000000 0 SECTION LOCAL DEFAULT 5 > 5: 0000000000000000 0 SECTION LOCAL DEFAULT 6 > 6: 0000000000000000 0 SECTION LOCAL DEFAULT 8 > 7: 0000000000000000 8 FUNC LOCAL DEFAULT 6 main.cold.0 > 8: 0000000000000000 0 SECTION LOCAL DEFAULT 10 > 9: 0000000000000000 0 SECTION LOCAL DEFAULT 13 > 10: 0000000000000000 0 SECTION LOCAL DEFAULT 12 > 11: 0000000000000000 312 FUNC GLOBAL DEFAULT [: 88] 8 main > 12: 0000000000000008 160 OBJECT GLOBAL DEFAULT COM buf > 13: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND memset > 14: 0000000000000000 44 FUNC GLOBAL DEFAULT [: 88] 1 sub2 > 15: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND strcmp > 16: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND exit > 17: 0000000000000000 0 NOTYPE GLOBAL DEFAULT UND abort > > Uros.