public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...
@ 2013-08-08 22:04 Caroline Tice
  2013-08-08 22:12 ` Joseph S. Myers
  0 siblings, 1 reply; 12+ messages in thread
From: Caroline Tice @ 2013-08-08 22:04 UTC (permalink / raw)
  To: GCC Patches; +Cc: Diego Novillo, Benjamin Kosnik, Joseph S. Myers

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

The attached patch adds documentation for the --enable-vtable-verify
configure option to  install.texi.  Is this ok to commit?

-- Caroline TIce
cmtice@google.com

2013-08-08  Caroline Tice  <cmtice@google.com>

        * doc/install.texi: Add documentation for the --enable-vtable-verify
        configure option.

[-- Attachment #2: vtv-update-doc.patch --]
[-- Type: application/octet-stream, Size: 1049 bytes --]

Index: gcc/doc/install.texi
===================================================================
--- gcc/doc/install.texi	(revision 201606)
+++ gcc/doc/install.texi	(working copy)
@@ -1032,6 +1032,16 @@ and for cross builds configured with @op
 More documentation about multiarch can be found at
 @uref{http://wiki.debian.org/Multiarch}.
 
+@item --enable-vtable-verify
+Specify whether to enable or disable the vtable verification feature.
+Enabling this feature causes libstdc++ to be built with its virtual calls
+in verifiable mode.  This means that, when linked with libvtv, every
+virtual call in libstdc++ will verify the vtable pointer through which the
+call will be made before actually making the call.  If not linked with libvtv,
+the verifier will call stub functions (in libstdc++ itself) and do nothing.
+If vtable verification is disabled, then libstdc++ is not built with its
+virutal calls in verifiable mode at all.
+
 @item --disable-multilib
 Specify that multiple target
 libraries to support different target variants, calling

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...
  2013-08-08 22:04 [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option Caroline Tice
@ 2013-08-08 22:12 ` Joseph S. Myers
  2013-08-28 21:24   ` Caroline Tice
  0 siblings, 1 reply; 12+ messages in thread
From: Joseph S. Myers @ 2013-08-08 22:12 UTC (permalink / raw)
  To: Caroline Tice; +Cc: GCC Patches, Diego Novillo, Benjamin Kosnik

On Thu, 8 Aug 2013, Caroline Tice wrote:

> The attached patch adds documentation for the --enable-vtable-verify
> configure option to  install.texi.  Is this ok to commit?

Could you please answer the questions I raised in the first four 
paragraphs of <http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00427.html> at 
greater length?  This patch appears to document it just as a libstdc++ 
configure option, but as noted there it appears to affect more than 
libstdc++ (even though it would be more sensible if it *only* affected 
libstdc++, and even better if it just enabled extra multilibs).

-- 
Joseph S. Myers
joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...
  2013-08-08 22:12 ` Joseph S. Myers
@ 2013-08-28 21:24   ` Caroline Tice
  2013-09-05 20:51     ` Caroline Tice
  2013-09-06 13:47     ` Diego Novillo
  0 siblings, 2 replies; 12+ messages in thread
From: Caroline Tice @ 2013-08-28 21:24 UTC (permalink / raw)
  To: Joseph S. Myers; +Cc: GCC Patches, Diego Novillo, Benjamin Kosnik

[-- Attachment #1: Type: text/plain, Size: 1687 bytes --]

Discussion on this topic seems to have petered out.  I have removed
references to ENABLE_VTABLE_VERIFY from libvtv, as requested.  I
cannot remove them from libgcc, as they really need to be there.  I
have updated the documentation in install.texi, as requested.
Please review the attached patch, which does all of this, and let me
know if it is ok to commit.

-- Caroline Tice
cmtice@google.com

gcc ChangeLog:

2013-08-28  Caroline Tice  <cmtice@google.com>

        * doc/install.texi: Add documentation for the --enable-vtable-verify
        and the --disable-libvtv configure options.

libvtv ChangeLog:
2013-08-28  Caroline Tice  <cmtice@google.com>

        * Makefile.am: Remove #if ENABLE_VTABLE_VERIFY checks around
        definitions of SUBDIRS, libvtv_la_SOURCES and libvtv_include_HEADERS.
        * Makefile.in: Regenerate.
        * configure.ac: Remove checks and tests for --enable-vtable-verify.
        * configure: Regenerate.

On Thu, Aug 8, 2013 at 3:11 PM, Joseph S. Myers <joseph@codesourcery.com> wrote:
> On Thu, 8 Aug 2013, Caroline Tice wrote:
>
>> The attached patch adds documentation for the --enable-vtable-verify
>> configure option to  install.texi.  Is this ok to commit?
>
> Could you please answer the questions I raised in the first four
> paragraphs of <http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00427.html> at
> greater length?  This patch appears to document it just as a libstdc++
> configure option, but as noted there it appears to affect more than
> libstdc++ (even though it would be more sensible if it *only* affected
> libstdc++, and even better if it just enabled extra multilibs).
>
> --
> Joseph S. Myers
> joseph@codesourcery.com

[-- Attachment #2: vtv-update-doc.patch --]
[-- Type: application/octet-stream, Size: 3592 bytes --]

Index: libvtv/configure.ac
===================================================================
--- libvtv/configure.ac	(revision 202060)
+++ libvtv/configure.ac	(working copy)
@@ -20,18 +20,6 @@ AC_ARG_ENABLE(version-specific-runtime-l
 [version_specific_libs=no])
 AC_MSG_RESULT($version_specific_libs)
 
-# Use same top-level configure hooks in libgcc/libstdc++/libvtv.
-AC_MSG_CHECKING([for --enable-vtable-verify])
-AC_ARG_ENABLE(vtable-verify,
-[  --enable-vtable-verify    Enable vtable verification feature ],
-[case "$enableval" in
- yes) enable_vtable_verify=yes ;;
- no)  enable_vtable_verify=no ;;
- *)   enable_vtable_verify=no;;
- esac],
-[enable_vtable_verify=no])
-AC_MSG_RESULT($enable_vtable_verify)
-
 # See if supported.
 unset VTV_SUPPORTED
 AC_MSG_CHECKING([for host support for vtable verification])
@@ -41,12 +29,9 @@ AC_MSG_RESULT($VTV_SUPPORTED)
 # Decide if it's usable.
 use_vtable_verify=no
 if test "x$VTV_SUPPORTED" = "xyes"; then
-  if test "x$enable_vtable_verify" = "xyes"; then
-    use_vtable_verify=yes
-    AC_MSG_NOTICE(using vtable verification)
-  fi
+  use_vtable_verify=yes
+  AC_MSG_NOTICE(using vtable verification)
 fi 
-AM_CONDITIONAL(ENABLE_VTABLE_VERIFY, test $use_vtable_verify = yes)
 
 # Do not delete or change the following two lines.  For why, see
 # http://gcc.gnu.org/ml/libstdc++/2003-07/msg00451.html
Index: libvtv/Makefile.am
===================================================================
--- libvtv/Makefile.am	(revision 202060)
+++ libvtv/Makefile.am	(working copy)
@@ -19,11 +19,7 @@
 ## along with this library; see the file COPYING3.  If not see
 ## <http://www.gnu.org/licenses/>.
 
-if ENABLE_VTABLE_VERIFY
 SUBDIRS = testsuite
-else
-SUBDIRS = 
-endif
 
 ACLOCAL_AMFLAGS = -I .. -I ../config
 
@@ -67,13 +63,8 @@ vtv_end.c:
 	rm -f $@
 	$(LN_S) $(toplevel_srcdir)/libgcc/vtv_end.c $@
 
-if ENABLE_VTABLE_VERIFY
 libvtv_la_SOURCES = $(vtv_sources)
 libvtv_include_HEADERS = $(vtv_headers)
-else
-libvtv_la_SOURCES = 
-libvtv_include_HEADERS = 
-endif
 
 # Least ordering for dependencies mean linking w/o libstdc++ for as
 # long as the development of libvtv does not absolutely require it.
Index: gcc/doc/install.texi
===================================================================
--- gcc/doc/install.texi	(revision 202060)
+++ gcc/doc/install.texi	(working copy)
@@ -1032,6 +1032,16 @@ and for cross builds configured with @op
 More documentation about multiarch can be found at
 @uref{http://wiki.debian.org/Multiarch}.
 
+@item --enable-vtable-verify
+Specify whether to enable or disable the vtable verification feature.
+Enabling this feature causes libstdc++ to be built with its virtual calls
+in verifiable mode.  This means that, when linked with libvtv, every
+virtual call in libstdc++ will verify the vtable pointer through which the
+call will be made before actually making the call.  If not linked with libvtv,
+the verifier will call stub functions (in libstdc++ itself) and do nothing.
+If vtable verification is disabled, then libstdc++ is not built with its
+virutal calls in verifiable mode at all.
+
 @item --disable-multilib
 Specify that multiple target
 libraries to support different target variants, calling
@@ -1418,6 +1428,10 @@ support for @code{libquadmath} on system
 @item --disable-libgomp
 Specify that the run-time libraries used by GOMP should not be built.
 
+@item --disable-libvtv
+Specify that the run-time libraries used by vtable verification should
+not be built.
+
 @item --with-dwarf2
 Specify that the compiler should
 use DWARF 2 debugging information as the default.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...
  2013-08-28 21:24   ` Caroline Tice
@ 2013-09-05 20:51     ` Caroline Tice
  2013-09-06 13:47     ` Diego Novillo
  1 sibling, 0 replies; 12+ messages in thread
From: Caroline Tice @ 2013-09-05 20:51 UTC (permalink / raw)
  To: Joseph S. Myers; +Cc: GCC Patches, Diego Novillo, Benjamin Kosnik

Ping?  Could somebody please review this for me?

-- Caroline Tice
cmtice@google.com

On Wed, Aug 28, 2013 at 2:15 PM, Caroline Tice <cmtice@google.com> wrote:
> Discussion on this topic seems to have petered out.  I have removed
> references to ENABLE_VTABLE_VERIFY from libvtv, as requested.  I
> cannot remove them from libgcc, as they really need to be there.  I
> have updated the documentation in install.texi, as requested.
> Please review the attached patch, which does all of this, and let me
> know if it is ok to commit.
>
> -- Caroline Tice
> cmtice@google.com
>
> gcc ChangeLog:
>
> 2013-08-28  Caroline Tice  <cmtice@google.com>
>
>         * doc/install.texi: Add documentation for the --enable-vtable-verify
>         and the --disable-libvtv configure options.
>
> libvtv ChangeLog:
> 2013-08-28  Caroline Tice  <cmtice@google.com>
>
>         * Makefile.am: Remove #if ENABLE_VTABLE_VERIFY checks around
>         definitions of SUBDIRS, libvtv_la_SOURCES and libvtv_include_HEADERS.
>         * Makefile.in: Regenerate.
>         * configure.ac: Remove checks and tests for --enable-vtable-verify.
>         * configure: Regenerate.
>
> On Thu, Aug 8, 2013 at 3:11 PM, Joseph S. Myers <joseph@codesourcery.com> wrote:
>> On Thu, 8 Aug 2013, Caroline Tice wrote:
>>
>>> The attached patch adds documentation for the --enable-vtable-verify
>>> configure option to  install.texi.  Is this ok to commit?
>>
>> Could you please answer the questions I raised in the first four
>> paragraphs of <http://gcc.gnu.org/ml/gcc-patches/2013-08/msg00427.html> at
>> greater length?  This patch appears to document it just as a libstdc++
>> configure option, but as noted there it appears to affect more than
>> libstdc++ (even though it would be more sensible if it *only* affected
>> libstdc++, and even better if it just enabled extra multilibs).
>>
>> --
>> Joseph S. Myers
>> joseph@codesourcery.com

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...
  2013-08-28 21:24   ` Caroline Tice
  2013-09-05 20:51     ` Caroline Tice
@ 2013-09-06 13:47     ` Diego Novillo
  2013-09-06 15:28       ` Caroline Tice
  1 sibling, 1 reply; 12+ messages in thread
From: Diego Novillo @ 2013-09-06 13:47 UTC (permalink / raw)
  To: Caroline Tice; +Cc: Joseph S. Myers, GCC Patches, Benjamin Kosnik

On 2013-08-28 17:15 , Caroline Tice wrote:

>  # Least ordering for dependencies mean linking w/o libstdc++ for as
>  # long as the development of libvtv does not absolutely require it.
> Index: gcc/doc/install.texi
> ===================================================================
> --- gcc/doc/install.texi    (revision 202060)
> +++ gcc/doc/install.texi    (working copy)
> @@ -1032,6 +1032,16 @@ and for cross builds configured with @op
>  More documentation about multiarch can be found at
>  @uref{http://wiki.debian.org/Multiarch}.
>
> +@item --enable-vtable-verify
> +Specify whether to enable or disable the vtable verification feature.
> +Enabling this feature causes libstdc++ to be built with its virtual calls
> +in verifiable mode.  This means that, when linked with libvtv, every
> +virtual call in libstdc++ will verify the vtable pointer through 
> which the
> +call will be made before actually making the call.  If not linked 
> with libvtv,
> +the verifier will call stub functions (in libstdc++ itself) and do 
> nothing.
> +If vtable verification is disabled, then libstdc++ is not built with its
> +virutal calls in verifiable mode at all.

s/virutal/virtual/

Could you clarify in the docs whether --enable-vtable-verify is the 
default behaviour or not?

Why would I need --disable-vtv, if I can use --disable-vtable-verify?


OK with those changes.


Diego.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...
  2013-09-06 13:47     ` Diego Novillo
@ 2013-09-06 15:28       ` Caroline Tice
  2013-09-07 21:06         ` Paolo Carlini
  0 siblings, 1 reply; 12+ messages in thread
From: Caroline Tice @ 2013-09-06 15:28 UTC (permalink / raw)
  To: Diego Novillo; +Cc: Joseph S. Myers, GCC Patches, Benjamin Kosnik

On Fri, Sep 6, 2013 at 6:47 AM, Diego Novillo <dnovillo@google.com> wrote:
> On 2013-08-28 17:15 , Caroline Tice wrote:
>
>>  # Least ordering for dependencies mean linking w/o libstdc++ for as
>>  # long as the development of libvtv does not absolutely require it.
>> Index: gcc/doc/install.texi
>> ===================================================================
>> --- gcc/doc/install.texi    (revision 202060)
>> +++ gcc/doc/install.texi    (working copy)
>> @@ -1032,6 +1032,16 @@ and for cross builds configured with @op
>>  More documentation about multiarch can be found at
>>  @uref{http://wiki.debian.org/Multiarch}.
>>
>> +@item --enable-vtable-verify
>> +Specify whether to enable or disable the vtable verification feature.
>> +Enabling this feature causes libstdc++ to be built with its virtual calls
>> +in verifiable mode.  This means that, when linked with libvtv, every
>> +virtual call in libstdc++ will verify the vtable pointer through which
>> the
>> +call will be made before actually making the call.  If not linked with
>> libvtv,
>> +the verifier will call stub functions (in libstdc++ itself) and do
>> nothing.
>> +If vtable verification is disabled, then libstdc++ is not built with its
>> +virutal calls in verifiable mode at all.
>
>
> s/virutal/virtual/
>
> Could you clarify in the docs whether --enable-vtable-verify is the default
> behaviour or not?
>

It will not be the default, but yes I will clarify.

> Why would I need --disable-vtv, if I can use --disable-vtable-verify?
>

--disable-vtable-verify prevents  libstdc++ from being build with
verification turned on, but the libvtv library will still be built.
--disable-libvtv prevents the libvtv library from being built.
Obviously I need to add a comment like this to the documentation, so I
will.

>
> OK with those changes.
>
>
> Diego.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...
  2013-09-06 15:28       ` Caroline Tice
@ 2013-09-07 21:06         ` Paolo Carlini
  2013-09-07 21:33           ` Paolo Carlini
  2013-09-08  3:15           ` Gabriel Dos Reis
  0 siblings, 2 replies; 12+ messages in thread
From: Paolo Carlini @ 2013-09-07 21:06 UTC (permalink / raw)
  To: Caroline Tice
  Cc: Diego Novillo, Joseph S. Myers, GCC Patches, Benjamin Kosnik

-- Caroline,

something seems wrong with the patch, I can't build anymore. Something 
in libvtv/testsuite:

make[4]: Entering directory 
`/home/paolo/Gcc/svn-dirs/trunk-build/x86_64-unknown-linux-gnu/libvtv/testsuite'
Makefile:369: *** missing separator.  Stop.

Paolo.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...
  2013-09-07 21:06         ` Paolo Carlini
@ 2013-09-07 21:33           ` Paolo Carlini
  2013-09-08  3:15           ` Gabriel Dos Reis
  1 sibling, 0 replies; 12+ messages in thread
From: Paolo Carlini @ 2013-09-07 21:33 UTC (permalink / raw)
  To: Caroline Tice
  Cc: Diego Novillo, Joseph S. Myers, GCC Patches, Benjamin Kosnik

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

Hi again,

On 09/07/2013 10:41 PM, Paolo Carlini wrote:
> -- Caroline,
>
> something seems wrong with the patch, I can't build anymore. Something 
> in libvtv/testsuite:
>
> make[4]: Entering directory 
> `/home/paolo/Gcc/svn-dirs/trunk-build/x86_64-unknown-linux-gnu/libvtv/testsuite'
> Makefile:369: *** missing separator.  Stop.
basing on your committed patch, I think you simply forgot to commit the 
Makefile.* changes in libvtv/testsuite. Thus I'm going to test and 
commit as obvious the below if an x86_64-linux bootstrap succeeds again 
for me.

Thanks,
Paolo.

/////////////////////

[-- Attachment #2: p --]
[-- Type: text/plain, Size: 465 bytes --]

Index: testsuite/Makefile.am
===================================================================
--- testsuite/Makefile.am	(revision 202345)
+++ testsuite/Makefile.am	(working copy)
@@ -39,12 +39,8 @@ check-script: ${testing_script} stamp-subdir
 	-@(chmod +x ${testing_script}; \
 	${testing_script} ${libvtv_srcdir} ${libvtv_builddir})
 
-if ENABLE_VTABLE_VERIFY
 check-am:
 	$(MAKE) $(AM_MAKEFLAGS) check-script
-else
-check-am:
-endif
 
 .PHONY: check-script
 

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...
  2013-09-07 21:06         ` Paolo Carlini
  2013-09-07 21:33           ` Paolo Carlini
@ 2013-09-08  3:15           ` Gabriel Dos Reis
  2013-09-08 13:00             ` Paolo Carlini
  1 sibling, 1 reply; 12+ messages in thread
From: Gabriel Dos Reis @ 2013-09-08  3:15 UTC (permalink / raw)
  To: Paolo Carlini
  Cc: Caroline Tice, Diego Novillo, Joseph S. Myers, GCC Patches,
	Benjamin Kosnik

On Sat, Sep 7, 2013 at 3:41 PM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> -- Caroline,
>
> something seems wrong with the patch, I can't build anymore. Something in
> libvtv/testsuite:
>
> make[4]: Entering directory
> `/home/paolo/Gcc/svn-dirs/trunk-build/x86_64-unknown-linux-gnu/libvtv/testsuite'
> Makefile:369: *** missing separator.  Stop.
>
> Paolo.

Indeed.  I saw this last night.  With --disable-libvtv, I was stopped by:

/home/gdr/build/gcc/./prev-gcc/xg++ -B/home/gdr/build/gcc/./prev-gcc/
-B/home/gdr/gnu/x86_64-unknown-linux-gnu/bin/ -nostdinc++
-B/home/gdr/build/gcc/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs
-B/home/gdr/build/gcc/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs
-I/home/gdr/build/gcc/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include/x86_64-unknown-linux-gnu
-I/home/gdr/build/gcc/prev-x86_64-unknown-linux-gnu/libstdc++-v3/include
-I/home/gdr/src/gcc.svn/libstdc++-v3/libsupc++
-L/home/gdr/build/gcc/prev-x86_64-unknown-linux-gnu/libstdc++-v3/src/.libs
-L/home/gdr/build/gcc/prev-x86_64-unknown-linux-gnu/libstdc++-v3/libsupc++/.libs
-c  -DIN_GCC_FRONTEND -g -O2 -DIN_GCC   -fno-exceptions -fno-rtti
-fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings
-Wcast-qual -Wmissing-format-attribute -pedantic -Wno-long-long
-Wno-variadic-macros -Wno-overlength-strings -Werror -fno-common
-DHAVE_CONFIG_H -I. -Icp -I/home/gdr/src/gcc.svn/gcc
-I/home/gdr/src/gcc.svn/gcc/cp -I/home/gdr/src/gcc.svn/gcc/../include
-I/home/gdr/src/gcc.svn/gcc/../libcpp/include
-I/home/gdr/src/gcc.svn/gcc/../libdecnumber
-I/home/gdr/src/gcc.svn/gcc/../libdecnumber/bid -I../libdecnumber
-I/home/gdr/src/gcc.svn/gcc/../libbacktrace
/home/gdr/src/gcc.svn/gcc/cp/typeck.c -o cp/typeck.o
/home/gdr/src/gcc.svn/gcc/cp/pt.c: In function 'tree_node*
maybe_get_template_decl_from_type_decl(tree)':
/home/gdr/src/gcc.svn/gcc/cp/pt.c:7064:1: internal compiler error: in
propagate_threaded_block_debug_into, at tree-ssa-threadedge.c:623
 maybe_get_template_decl_from_type_decl (tree decl)
 ^
0x528a20 ???
../sysdeps/x86_64/start.S:123
Please submit a full bug report,
with preprocessed source if appropriate.
Please include the complete backtrace with any bug report.
See <http://gcc.gnu.org/bugs.html> for instructions.
make[3]: *** [cp/pt.o] Error 1

-- Gaby

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...
  2013-09-08  3:15           ` Gabriel Dos Reis
@ 2013-09-08 13:00             ` Paolo Carlini
  2013-09-08 13:34               ` Paolo Carlini
  0 siblings, 1 reply; 12+ messages in thread
From: Paolo Carlini @ 2013-09-08 13:00 UTC (permalink / raw)
  To: Gabriel Dos Reis
  Cc: Caroline Tice, Diego Novillo, Joseph S. Myers, GCC Patches,
	Benjamin Kosnik

Hi,

On 09/08/2013 02:26 AM, Gabriel Dos Reis wrote:
> /home/gdr/src/gcc.svn/gcc/cp/pt.c:7064:1: internal compiler error: in 
> propagate_threaded_block_debug_into, at tree-ssa-threadedge.c:623 
> maybe_get_template_decl_from_type_decl (tree decl)
Yes, this is the serious one, which of course I'm also seeing :(

Problem is, yesterday, and friday too, I did a mix of quick builds and 
real bootstraps and using old and new trees, and I can't say now which 
exact commit is the culprit. Many people are of course affected and we 
want to find the commit asap, tell the author and maybe revert it.

What would you say about the revision range?

Paolo.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...
  2013-09-08 13:00             ` Paolo Carlini
@ 2013-09-08 13:34               ` Paolo Carlini
  2013-09-08 14:00                 ` Gabriel Dos Reis
  0 siblings, 1 reply; 12+ messages in thread
From: Paolo Carlini @ 2013-09-08 13:34 UTC (permalink / raw)
  To: Gabriel Dos Reis
  Cc: Caroline Tice, Diego Novillo, Joseph S. Myers, GCC Patches,
	Benjamin Kosnik

.. it's r202296 aka bootstrap/58340, Jeff is already on it.

Paolo.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...
  2013-09-08 13:34               ` Paolo Carlini
@ 2013-09-08 14:00                 ` Gabriel Dos Reis
  0 siblings, 0 replies; 12+ messages in thread
From: Gabriel Dos Reis @ 2013-09-08 14:00 UTC (permalink / raw)
  To: Paolo Carlini
  Cc: Caroline Tice, Diego Novillo, Joseph S. Myers, GCC Patches,
	Benjamin Kosnik

On Sun, Sep 8, 2013 at 4:36 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> .. it's r202296 aka bootstrap/58340, Jeff is already on it.

Thanks for the detective work, Paolo.

-- Gaby

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2013-09-08 13:34 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-08 22:04 [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option Caroline Tice
2013-08-08 22:12 ` Joseph S. Myers
2013-08-28 21:24   ` Caroline Tice
2013-09-05 20:51     ` Caroline Tice
2013-09-06 13:47     ` Diego Novillo
2013-09-06 15:28       ` Caroline Tice
2013-09-07 21:06         ` Paolo Carlini
2013-09-07 21:33           ` Paolo Carlini
2013-09-08  3:15           ` Gabriel Dos Reis
2013-09-08 13:00             ` Paolo Carlini
2013-09-08 13:34               ` Paolo Carlini
2013-09-08 14:00                 ` Gabriel Dos Reis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).