* [PATCH] PR other/91396 Fix static link error with -fvtable-verify
@ 2019-08-12 19:34 Caroline Tice via gcc-patches
2019-08-12 23:04 ` Caroline Tice via gcc-patches
2019-08-13 8:31 ` Richard Biener
0 siblings, 2 replies; 3+ messages in thread
From: Caroline Tice via gcc-patches @ 2019-08-12 19:34 UTC (permalink / raw)
To: GCC Patches, Richard Biener; +Cc: Eric Christopher, Luis Lozano
Hi,
This patch is to fix a bug where linking with -fvtable-verify and
-static causes the linker to complain about multiple definitions of
things in the vtv_end*.o files (once from the .o file and once from
libvtv.a). (See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91396).
The fix is for the GNU_USER_TARGET_ENDFILE_SPEC to only include the
vtv_end*.o files if we're not doing static linking (and we are using
-fvtable-verify flags).
Tested this fix by verifying that the test case in the bug compiles
both with and without -static, and that there were no new regressions
in the libvtv testsuite. I'm in the process of doing a full bootstrap
build with this change. Assuming the bootstrap passes, is this ok to
commit?
Index: gcc/config/gnu-user.h
===================================================================
--- gcc/config/gnu-user.h (revision 274317)
+++ gcc/config/gnu-user.h (working copy)
@@ -73,9 +73,9 @@
GNU userspace "finalizer" file, `crtn.o'. */
#define GNU_USER_TARGET_ENDFILE_SPEC \
- "%{fvtable-verify=none:%s; \
+ "%{!static:%{fvtable-verify=none:%s; \
fvtable-verify=preinit:vtv_end_preinit.o%s; \
- fvtable-verify=std:vtv_end.o%s} \
+ fvtable-verify=std:vtv_end.o%s}} \
%{static:crtend.o%s; \
shared|static-pie|" PIE_SPEC ":crtendS.o%s; \
:crtend.o%s} " \
ChangeLog entry:
2019-08-12 Caroline Tice <cmtice@google.com>
PR other/91396
* config/gnu-user.h (GNU_USER_TARGET_ENDFILE_SPEC): Only add the
vtv_end.o or vtv_end_preinit.o files if !static.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PR other/91396 Fix static link error with -fvtable-verify
2019-08-12 19:34 [PATCH] PR other/91396 Fix static link error with -fvtable-verify Caroline Tice via gcc-patches
@ 2019-08-12 23:04 ` Caroline Tice via gcc-patches
2019-08-13 8:31 ` Richard Biener
1 sibling, 0 replies; 3+ messages in thread
From: Caroline Tice via gcc-patches @ 2019-08-12 23:04 UTC (permalink / raw)
To: GCC Patches, Richard Biener; +Cc: Eric Christopher, Luis Lozano
The bootstrap succeeded.
On Mon, Aug 12, 2019 at 11:51 AM Caroline Tice <cmtice@google.com> wrote:
>
> Hi,
>
> This patch is to fix a bug where linking with -fvtable-verify and
> -static causes the linker to complain about multiple definitions of
> things in the vtv_end*.o files (once from the .o file and once from
> libvtv.a). (See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91396).
> The fix is for the GNU_USER_TARGET_ENDFILE_SPEC to only include the
> vtv_end*.o files if we're not doing static linking (and we are using
> -fvtable-verify flags).
>
> Tested this fix by verifying that the test case in the bug compiles
> both with and without -static, and that there were no new regressions
> in the libvtv testsuite. I'm in the process of doing a full bootstrap
> build with this change. Assuming the bootstrap passes, is this ok to
> commit?
>
> Index: gcc/config/gnu-user.h
> ===================================================================
> --- gcc/config/gnu-user.h (revision 274317)
> +++ gcc/config/gnu-user.h (working copy)
> @@ -73,9 +73,9 @@
> GNU userspace "finalizer" file, `crtn.o'. */
>
> #define GNU_USER_TARGET_ENDFILE_SPEC \
> - "%{fvtable-verify=none:%s; \
> + "%{!static:%{fvtable-verify=none:%s; \
> fvtable-verify=preinit:vtv_end_preinit.o%s; \
> - fvtable-verify=std:vtv_end.o%s} \
> + fvtable-verify=std:vtv_end.o%s}} \
> %{static:crtend.o%s; \
> shared|static-pie|" PIE_SPEC ":crtendS.o%s; \
> :crtend.o%s} " \
>
> ChangeLog entry:
>
> 2019-08-12 Caroline Tice <cmtice@google.com>
>
> PR other/91396
> * config/gnu-user.h (GNU_USER_TARGET_ENDFILE_SPEC): Only add the
> vtv_end.o or vtv_end_preinit.o files if !static.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] PR other/91396 Fix static link error with -fvtable-verify
2019-08-12 19:34 [PATCH] PR other/91396 Fix static link error with -fvtable-verify Caroline Tice via gcc-patches
2019-08-12 23:04 ` Caroline Tice via gcc-patches
@ 2019-08-13 8:31 ` Richard Biener
1 sibling, 0 replies; 3+ messages in thread
From: Richard Biener @ 2019-08-13 8:31 UTC (permalink / raw)
To: Caroline Tice; +Cc: GCC Patches, Eric Christopher, Luis Lozano
[-- Attachment #1: Type: text/plain, Size: 1876 bytes --]
On Mon, 12 Aug 2019, Caroline Tice wrote:
> Hi,
>
> This patch is to fix a bug where linking with -fvtable-verify and
> -static causes the linker to complain about multiple definitions of
> things in the vtv_end*.o files (once from the .o file and once from
> libvtv.a). (See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91396).
> The fix is for the GNU_USER_TARGET_ENDFILE_SPEC to only include the
> vtv_end*.o files if we're not doing static linking (and we are using
> -fvtable-verify flags).
>
> Tested this fix by verifying that the test case in the bug compiles
> both with and without -static, and that there were no new regressions
> in the libvtv testsuite. I'm in the process of doing a full bootstrap
> build with this change. Assuming the bootstrap passes, is this ok to
> commit?
OK.
Thanks,
Richard.
> Index: gcc/config/gnu-user.h
> ===================================================================
> --- gcc/config/gnu-user.h (revision 274317)
> +++ gcc/config/gnu-user.h (working copy)
> @@ -73,9 +73,9 @@
> GNU userspace "finalizer" file, `crtn.o'. */
>
> #define GNU_USER_TARGET_ENDFILE_SPEC \
> - "%{fvtable-verify=none:%s; \
> + "%{!static:%{fvtable-verify=none:%s; \
> fvtable-verify=preinit:vtv_end_preinit.o%s; \
> - fvtable-verify=std:vtv_end.o%s} \
> + fvtable-verify=std:vtv_end.o%s}} \
> %{static:crtend.o%s; \
> shared|static-pie|" PIE_SPEC ":crtendS.o%s; \
> :crtend.o%s} " \
>
> ChangeLog entry:
>
> 2019-08-12 Caroline Tice <cmtice@google.com>
>
> PR other/91396
> * config/gnu-user.h (GNU_USER_TARGET_ENDFILE_SPEC): Only add the
> vtv_end.o or vtv_end_preinit.o files if !static.
>
--
Richard Biener <rguenther@suse.de>
SUSE Linux GmbH, Maxfeldstrasse 5, 90409 Nuernberg, Germany;
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah; HRB 21284 (AG Nürnberg)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-13 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-12 19:34 [PATCH] PR other/91396 Fix static link error with -fvtable-verify Caroline Tice via gcc-patches
2019-08-12 23:04 ` Caroline Tice via gcc-patches
2019-08-13 8:31 ` Richard Biener
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).