From: "Caroline Tice via gcc-patches" <gcc-patches@gcc.gnu.org>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: [PATCH] Fix testcase to not use vtable verification with LTO
Date: Thu, 05 Sep 2019 16:13:00 -0000 [thread overview]
Message-ID: <CABtf2+TghM2Z66QK58-gwpWFmO1mwn_Jg8Q3moeRpfP_iOAaVw@mail.gmail.com> (raw)
Yesterday I submitted a patch that disallows using vtable verfication
with LTO (they don't work
properly together), but I missed fixing the flags for one testcase.
This patch fixes that omission.
Testing: Tescase passes with this change.
Is this ok to commit?
-- Caroline
cmtice@google.com
ChangeLog entry (gcc/testsuite/ChangeLog):
2019-09-05 Caroline Tice <cmtice@google.com>
PR testsuite/91670
* g++.dg/ubsan/pr59415.C: Disable LTO, since test uses
-fvtable-verify, and the two options are no longer allowed
together.
Index: gcc/testsuite/g++.dg/ubsan/pr59415.C
===================================================================
--- gcc/testsuite/g++.dg/ubsan/pr59415.C (revision 275387)
+++ gcc/testsuite/g++.dg/ubsan/pr59415.C (working copy)
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-fsanitize=null -Wall -fvtable-verify=std" } */
+/* { dg-options "-fsanitize=null -Wall -fvtable-verify=std -fno-lto" } */
void
foo (void)
next reply other threads:[~2019-09-05 16:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 16:13 Caroline Tice via gcc-patches [this message]
2019-09-06 10:27 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABtf2+TghM2Z66QK58-gwpWFmO1mwn_Jg8Q3moeRpfP_iOAaVw@mail.gmail.com \
--to=gcc-patches@gcc.gnu.org \
--cc=cmtice@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).