From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 884 invoked by alias); 11 Oct 2012 21:50:45 -0000 Received: (qmail 870 invoked by uid 22791); 11 Oct 2012 21:50:43 -0000 X-SWARE-Spam-Status: No, hits=-5.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-la0-f47.google.com (HELO mail-la0-f47.google.com) (209.85.215.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Oct 2012 21:50:39 +0000 Received: by mail-la0-f47.google.com with SMTP id h5so1614677lam.20 for ; Thu, 11 Oct 2012 14:50:37 -0700 (PDT) Received: by 10.112.82.232 with SMTP id l8mr619262lby.104.1349992237823; Thu, 11 Oct 2012 14:50:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.42.5 with HTTP; Thu, 11 Oct 2012 14:50:17 -0700 (PDT) In-Reply-To: <20121011214412.5AC876128C@tjsboxrox.mtv.corp.google.com> References: <20121011214412.5AC876128C@tjsboxrox.mtv.corp.google.com> From: Steven Bosscher Date: Thu, 11 Oct 2012 21:53:00 -0000 Message-ID: Subject: Re: [PATCH] Reduce conservativeness in REE using machine model (issue6631066) To: Teresa Johnson Cc: reply@codereview.appspotmail.com, davidxl@google.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-10/txt/msg01160.txt.bz2 On Thu, Oct 11, 2012 at 11:44 PM, Teresa Johnson wrote: > + mode = targetm.machine_mode_from_attr_mode(insn); Nit: space between "..._mode" and "(". A test case would also be Nice To Have. Looks OK to me otherwise, but I can't approve it. Ciao! Steven