From: Steven Bosscher <stevenb.gcc@gmail.com>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: Diego Novillo <dnovillo@google.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [patch] Do not include output.h everywhere
Date: Mon, 04 Jun 2012 07:00:00 -0000 [thread overview]
Message-ID: <CABu31nNKSSBstw_M=azaoxfzxx2Vj2xXH9k4NSmSSL389-L6BQ@mail.gmail.com> (raw)
In-Reply-To: <CAFiYyc3O+6_Ftds0wj=rvYEBL0NEik00F8bRJfPSB5HS0AOrMA@mail.gmail.com>
On Fri, Jun 1, 2012 at 11:19 AM, Richard Guenther
<richard.guenther@gmail.com> wrote:
>> What about toplev.h? dump_file is defined there, after all. I don't mind
>> it in system.h, if that's not a good place for it now. The patch is OK
>> either way.
>
> I'd prefer toplev.h, too. system.h is supposed to be for system header
> inclusion (and related workarounds).
(..)
> Thus, ok with moving to toplev.h instead.
I had already committed this on Friday.
The problem with toplev.h is that it isn't included in any tree-*.c
file (except tree-dump.c and tree-optimize.c). Also, there is nothing
"top-level" about an RTL or GIMPLE pass. Perhaps I should create a new
header with all the dump and statistics stuff?
Ciao!
Steven
next prev parent reply other threads:[~2012-06-04 7:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-31 18:57 Steven Bosscher
2012-05-31 19:22 ` Diego Novillo
2012-06-01 9:19 ` Richard Guenther
2012-06-04 7:00 ` Steven Bosscher [this message]
2012-06-04 9:42 ` Richard Guenther
2012-06-04 10:58 ` Steven Bosscher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABu31nNKSSBstw_M=azaoxfzxx2Vj2xXH9k4NSmSSL389-L6BQ@mail.gmail.com' \
--to=stevenb.gcc@gmail.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).