From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76638 invoked by alias); 31 Oct 2015 21:17:38 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 76624 invoked by uid 89); 31 Oct 2015 21:17:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lb0-f176.google.com Received: from mail-lb0-f176.google.com (HELO mail-lb0-f176.google.com) (209.85.217.176) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Sat, 31 Oct 2015 21:17:36 +0000 Received: by lbbwb3 with SMTP id wb3so67414502lbb.1 for ; Sat, 31 Oct 2015 14:17:32 -0700 (PDT) X-Received: by 10.112.189.193 with SMTP id gk1mr6665370lbc.98.1446326252867; Sat, 31 Oct 2015 14:17:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.145.201 with HTTP; Sat, 31 Oct 2015 14:16:53 -0700 (PDT) In-Reply-To: <87si4sv6uw.fsf@e105548-lin.cambridge.arm.com> References: <87a8r0wqoe.fsf@e105548-lin.cambridge.arm.com> <871tccwo2g.fsf@e105548-lin.cambridge.arm.com> <87si4sv6uw.fsf@e105548-lin.cambridge.arm.com> From: Steven Bosscher Date: Sat, 31 Oct 2015 21:28:00 -0000 Message-ID: Subject: Re: Try to update dominance info in tree-call-cdce.c To: Richard Biener , GCC Patches , richard.sandiford@arm.com Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-10/txt/msg03499.txt.bz2 On Fri, Oct 30, 2015 at 2:11 PM, Richard Sandiford wrote: > Is the split_block change really so bad? IMHO: Yes. split_block just splits some basic block B into two blocks B1/B2 somewhere in the middle of B. The dominance relations between B1 and B2 are obvious and intuitive. The new flag to split_block is not. The dominance info is not updated but the loops are? Confusing, if you ask me... Your situation, where a pass knows the dominance relations will change, is unusual. The extra work to fix up the ET tree twice should be negligible anyway. Ciao! Steven