From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19393 invoked by alias); 30 Jul 2012 13:56:43 -0000 Received: (qmail 19385 invoked by uid 22791); 30 Jul 2012 13:56:43 -0000 X-SWARE-Spam-Status: No, hits=-5.0 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-lb0-f175.google.com (HELO mail-lb0-f175.google.com) (209.85.217.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Jul 2012 13:56:30 +0000 Received: by lbol5 with SMTP id l5so3558681lbo.20 for ; Mon, 30 Jul 2012 06:56:28 -0700 (PDT) Received: by 10.112.42.41 with SMTP id k9mr5369077lbl.90.1343656588613; Mon, 30 Jul 2012 06:56:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.112.45.72 with HTTP; Mon, 30 Jul 2012 06:56:08 -0700 (PDT) In-Reply-To: <501680EF.1050902@gmail.com> References: <501680EF.1050902@gmail.com> From: Steven Bosscher Date: Mon, 30 Jul 2012 14:10:00 -0000 Message-ID: Subject: Re: [PATCH] Follow-up to the last gengtype patch: handle DEF_VEC_A in gengtype To: Laurynas Biveinis Cc: gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-07/txt/msg01482.txt.bz2 On Mon, Jul 30, 2012 at 2:41 PM, Laurynas Biveinis wrote: > I only remembered to add DEF_VEC_A handlgin to gengtype.c a second after committing the previous patch [1]. > > Here it is, done as a follow up. With some luck, this will be short-lived code because of the C++ conversion. Hello Laurynas, Thanks for taking care of this. Unfortunately there seems to be a deeper problem with this PCH pointer rewriting stuff, it looks like gengtype generates code that runs in time quadratic in the GTY((length)) of a GTY array. See http://gcc.gnu.org/PR53880#c27 Could you please have a look at that problem, and see if you, with all your GTY-fu, see an easy way out? Thanks, Ciao! Steven