From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109716 invoked by alias); 9 Mar 2015 15:48:53 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 109699 invoked by uid 89); 9 Mar 2015 15:48:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-lb0-f181.google.com Received: from mail-lb0-f181.google.com (HELO mail-lb0-f181.google.com) (209.85.217.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 09 Mar 2015 15:48:52 +0000 Received: by lbjf15 with SMTP id f15so43896558lbj.2 for ; Mon, 09 Mar 2015 08:48:48 -0700 (PDT) X-Received: by 10.152.45.37 with SMTP id j5mr26824903lam.31.1425916128455; Mon, 09 Mar 2015 08:48:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.83.130 with HTTP; Mon, 9 Mar 2015 08:48:08 -0700 (PDT) In-Reply-To: References: From: Steven Bosscher Date: Mon, 09 Mar 2015 15:48:00 -0000 Message-ID: Subject: Re: [PATCH] Improve PR44563 To: Richard Biener Cc: GCC Patches , Jan Hubicka Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00475.txt.bz2 On Mon, Mar 9, 2015 at 4:12 PM, Richard Biener wrote: > ! /* This is a really poor hash function, but it is what the current code uses, > ! so I am reusing it to avoid an additional axis in testing. */ This is a bit silly as a comment, because after your patch the "current" code is the patched code. Better to reference the htab_hash_pointer function. But can't we add an inline version in hashtab.h instead? Ciao! Steven