From: Steven Bosscher <stevenb.gcc@gmail.com>
To: "Thomas Preud'homme" <thomas.preudhomme@arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, GCC, stage1] Fallback to copy-prop if constant-prop not possible
Date: Mon, 23 Mar 2015 11:57:00 -0000 [thread overview]
Message-ID: <CABu31nOgb7ixQ71nkwJRy=6XeUjQb7YohNe1CzwaJtnzmfizPQ@mail.gmail.com> (raw)
In-Reply-To: <000201d06558$acd8a130$0689e390$@arm.com>
On Mon, Mar 23, 2015 at 12:01 PM, Thomas Preud'homme wrote:
> What about the cprop_reg_p that needs to be negated? Did I miss something
> that makes it ok?
You didn't miss anything. I sent the wrong patch. The one I tested on
ppc64 also has the condition reversed:
@@ -1328,9 +1329,8 @@ implicit_set_cond_p (const_rtx cond)
if (GET_CODE (cond) != EQ && GET_CODE (cond) != NE)
return false;
- /* The first operand of COND must be a pseudo-reg. */
- if (! REG_P (XEXP (cond, 0))
- || HARD_REGISTER_P (XEXP (cond, 0)))
+ /* The first operand of COND must be a register we can propagate. */
+ if (! cprop_reg_p (XEXP (cond, 0)))
return false;
/* The second operand of COND must be a suitable constant. */
next prev parent reply other threads:[~2015-03-23 11:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-16 10:26 Thomas Preud'homme
2015-02-16 10:54 ` Richard Biener
2015-02-16 12:06 ` Steven Bosscher
2015-02-16 20:20 ` Steven Bosscher
2015-02-17 2:51 ` Thomas Preud'homme
2015-03-04 8:52 ` Thomas Preud'homme
2015-03-20 7:55 ` Steven Bosscher
2015-03-20 8:36 ` Thomas Preud'homme
2015-03-20 10:27 ` Thomas Preud'homme
2015-03-20 12:14 ` Steven Bosscher
2015-03-23 11:01 ` Thomas Preud'homme
2015-03-23 11:57 ` Steven Bosscher [this message]
2015-03-30 4:58 ` Thomas Preud'homme
2015-04-13 12:47 ` Jeff Law
2015-04-14 8:00 ` Thomas Preud'homme
2015-04-16 8:44 ` Thomas Preud'homme
2015-04-23 9:15 ` Steven Bosscher
2015-04-24 2:59 ` Jeff Law
2015-04-24 3:11 ` Thomas Preud'homme
2015-04-24 3:15 ` Jeff Law
2015-04-24 4:53 ` Thomas Preud'homme
2015-04-30 7:43 ` Bin.Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABu31nOgb7ixQ71nkwJRy=6XeUjQb7YohNe1CzwaJtnzmfizPQ@mail.gmail.com' \
--to=stevenb.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=thomas.preudhomme@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).