From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28806 invoked by alias); 5 Sep 2018 15:32:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 28785 invoked by uid 89); 5 Sep 2018 15:32:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HCc:D*comcast.net, H*Ad:D*comcast.net X-HELO: mail-oi0-f67.google.com Received: from mail-oi0-f67.google.com (HELO mail-oi0-f67.google.com) (209.85.218.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Sep 2018 15:32:16 +0000 Received: by mail-oi0-f67.google.com with SMTP id k81-v6so14390242oib.9 for ; Wed, 05 Sep 2018 08:32:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8Wlx2Hizmwi21reNumqtwJqF2yOIrMB3gU2A1iBZE3k=; b=otXC523388avBKgAs5MWXXzzURHjveogLQot1SXoxtW3h1rpnOi08S4g37IMw6KPOJ 1FDsu7vc1c+4014X6xyUMgU/ksQEdQJjU5BMGjgzMEFHkVaSuLLrKRhfKR8QWzKr4AWo vLtJz99PE1UkaRqw14VcFxhlqeB2a7DRPMAAfUYl50K/M0jiqI9tQiSgCmBd7pCV4mBE +EiGxIT6OzvIHr4d9gQMSwOaVoiQCt/IzFNG7PXGSoY/Dbnz+GmW9lMlUWJbefLP+TOh D+A+fqsUe/pRtmJbt8kp47mOzCZStX/APN759brMU/nQepKRcebxfTvXBOj3dRk2Wjfl 2BWw== MIME-Version: 1.0 References: <1466278273-7014-1-git-send-email-rep.dot.nop@gmail.com> <6a85e9fd-d74e-ed34-daac-bb919e296d7b@redhat.com> In-Reply-To: <6a85e9fd-d74e-ed34-daac-bb919e296d7b@redhat.com> From: Bernhard Reutner-Fischer Date: Wed, 05 Sep 2018 15:32:00 -0000 Message-ID: Subject: Re: [PATCH] PR52665 do not let .ident confuse assembler scan tests To: Jeff Law Cc: GCC Patches , Mike Stump , Rainer Orth Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00353.txt.bz2 On Tue, 21 Jun 2016 at 00:19, Jeff Law wrote: > > On 06/18/2016 01:31 PM, Bernhard Reutner-Fischer wrote: > > A branch with a name matching scan-assembler pattern triggers > > inappropriate FAIL. > > > > E.g. branch fixups-testsuite and > > - gcc.target/i386/pr65871-?.c (scan-assembler-not "test") > > - gcc.target/i386/pr41442.c (scan-assembler-times "test|cmp" 2) > > etc. > > > > This is a recurring problem as can be seen by some -fno-ident additions > > by commits from e.g. Michael Meissner over the years: builtins-58.c, > > powerpc/pr46728-?.c > > > > The patch below adds -fno-ident if a testcase contains one of > > scan-assembler, scan-assembler-not or scan-assembler-times. > > > > Regression tested on x86_64-unknown-linux on a fixups-testsuite branch > > where it fixes several false FAILs without regressions. > > > > gcc/testsuite/ChangeLog > > > > 2016-06-18 Bernhard Reutner-Fischer > > > > PR testsuite/52665 > > * lib/gcc-dg.exp (gcc-dg-test-1): Iterate over _required_options. > > * lib/target-supports.exp (scan-assembler_required_options, > > scan-assembler-not_required_options, > > scan-assembler-times_required_options): Add -fno-ident. > > * lib/scanasm.exp (scan-assembler-times): Fix error message. > > * c-c++-common/ident-0a.c: New test. > > * c-c++-common/ident-0b.c: New test. > > * c-c++-common/ident-1a.c: New test. > > * c-c++-common/ident-1b.c: New test. > > * c-c++-common/ident-2a.c: New test. > > * c-c++-common/ident-2b.c: New test. > > > > Ok for trunk? > > > > PS: proc force_conventional_output_for would be a bit misnomed by this, > > not sure if it should be renamed to maybe set_required_options_for or > > the like? > OK. Now applied without the rename to trunk as r264128. thanks, > > Changing force_conventional_output to set_required_options_for is > pre-approved as well. > > jeff >