[PATCH] gimple-walk.c #include TLC

[PATCH] gimple-walk.c #include TLC

[Bernhard Reutner-Fischer]

Hi there,

I noticed that gimple-walk.c has a creative list of #includes.
Furthermore, in walk_gimple_asm parse_{in,out}put_constraint was called
even if neither allows_mem, allows_reg nor is_inout were used -- i.e. if
wi is NULL -- and the return value of the constraint parsing was not
taken into account which looks wrong or at least odd. Note that several
other spots in the tree do ignore the parse_{in,out}put_constraint return
values and should be adjusted too AFAIU. Otherwise we might attempt
(and use!) to extract information from otherwise illegal constraints,
it seems?

Bootstrapped and regtested on x86_64-unknown-linux with no regressions.
Ok for trunk?

gcc/ChangeLog:

	* gimple-walk.c: Prune duplicate or unneeded includes.
	(walk_gimple_asm): Only call parse_input_constraint or
	parse_output_constraint if their findings are used.
	Honour parse_input_constraint and parse_output_constraint
	result.

diff --git a/gcc/gimple-walk.c b/gcc/gimple-walk.c
index 45ff859..53462b5 100644
--- a/gcc/gimple-walk.c
+++ b/gcc/gimple-walk.c
@@ -2,75 +2,69 @@
 
    Copyright (C) 2007-2015 Free Software Foundation, Inc.
    Contributed by Aldy Hernandez <aldyh@redhat.com>
 
 This file is part of GCC.
 
 GCC is free software; you can redistribute it and/or modify it under
 the terms of the GNU General Public License as published by the Free
 Software Foundation; either version 3, or (at your option) any later
 version.
 
 GCC is distributed in the hope that it will be useful, but WITHOUT ANY
 WARRANTY; without even the implied warranty of MERCHANTABILITY or
 FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 for more details.
 
 You should have received a copy of the GNU General Public License
 along with GCC; see the file COPYING3.  If not see
 <http://www.gnu.org/licenses/>.  */
 
 #include "config.h"
 #include "system.h"
 #include "coretypes.h"
 #include "tm.h"
 #include "hash-set.h"
-#include "machmode.h"
 #include "vec.h"
 #include "double-int.h"
 #include "input.h"
 #include "alias.h"
 #include "symtab.h"
-#include "wide-int.h"
 #include "inchash.h"
 #include "tree.h"
-#include "fold-const.h"
-#include "stmt.h"
 #include "predict.h"
 #include "hard-reg-set.h"
-#include "input.h"
 #include "function.h"
-#include "basic-block.h"
-#include "tree-ssa-alias.h"
-#include "internal-fn.h"
 #include "gimple-expr.h"
 #include "is-a.h"
+#include "tree-ssa-alias.h"
+#include "basic-block.h"
+#include "fold-const.h"
 #include "gimple.h"
 #include "gimple-iterator.h"
 #include "gimple-walk.h"
-#include "gimple-walk.h"
-#include "demangle.h"
+#include "stmt.h"
 
 /* Walk all the statements in the sequence *PSEQ calling walk_gimple_stmt
    on each one.  WI is as in walk_gimple_stmt.
 
    If walk_gimple_stmt returns non-NULL, the walk is stopped, and the
    value is stored in WI->CALLBACK_RESULT.  Also, the statement that
    produced the value is returned if this statement has not been
    removed by a callback (wi->removed_stmt).  If the statement has
    been removed, NULL is returned.
 
    Otherwise, all the statements are walked and NULL returned.  */
 
 gimple
 walk_gimple_seq_mod (gimple_seq *pseq, walk_stmt_fn callback_stmt,
 		     walk_tree_fn callback_op, struct walk_stmt_info *wi)
 {
   gimple_stmt_iterator gsi;
 
   for (gsi = gsi_start (*pseq); !gsi_end_p (gsi); )
     {
       tree ret = walk_gimple_stmt (&gsi, callback_stmt, callback_op, wi);
       if (ret)
 	{
 	  /* If CALLBACK_STMT or CALLBACK_OP return a value, WI must exist
 	     to hold it.  */
@@ -107,71 +101,76 @@ walk_gimple_seq (gimple_seq seq, walk_stmt_fn callback_stmt,
 
 /* Helper function for walk_gimple_stmt.  Walk operands of a GIMPLE_ASM.  */
 
 static tree
 walk_gimple_asm (gasm *stmt, walk_tree_fn callback_op,
 		 struct walk_stmt_info *wi)
 {
   tree ret, op;
   unsigned noutputs;
   const char **oconstraints;
   unsigned i, n;
   const char *constraint;
   bool allows_mem, allows_reg, is_inout;
 
   noutputs = gimple_asm_noutputs (stmt);
   oconstraints = (const char **) alloca ((noutputs) * sizeof (const char *));
 
   if (wi)
     wi->is_lhs = true;
 
   for (i = 0; i < noutputs; i++)
     {
       op = gimple_asm_output_op (stmt, i);
       constraint = TREE_STRING_POINTER (TREE_VALUE (TREE_PURPOSE (op)));
       oconstraints[i] = constraint;
-      parse_output_constraint (&constraint, i, 0, 0, &allows_mem, &allows_reg,
-	                       &is_inout);
       if (wi)
-	wi->val_only = (allows_reg || !allows_mem);
+	{
+	  if (parse_output_constraint (&constraint, i, 0, 0, &allows_mem,
+				       &allows_reg, &is_inout))
+	    wi->val_only = (allows_reg || !allows_mem);
+	}
       ret = walk_tree (&TREE_VALUE (op), callback_op, wi, NULL);
       if (ret)
 	return ret;
     }
 
   n = gimple_asm_ninputs (stmt);
   for (i = 0; i < n; i++)
     {
       op = gimple_asm_input_op (stmt, i);
       constraint = TREE_STRING_POINTER (TREE_VALUE (TREE_PURPOSE (op)));
-      parse_input_constraint (&constraint, 0, 0, noutputs, 0,
-			      oconstraints, &allows_mem, &allows_reg);
+
       if (wi)
 	{
-	  wi->val_only = (allows_reg || !allows_mem);
-          /* Although input "m" is not really a LHS, we need a lvalue.  */
-	  wi->is_lhs = !wi->val_only;
+	  if (parse_input_constraint (&constraint, 0, 0, noutputs, 0,
+				      oconstraints, &allows_mem, &allows_reg))
+	    {
+	      wi->val_only = (allows_reg || !allows_mem);
+	      /* Although input "m" is not really a LHS, we need a lvalue.  */
+	      wi->is_lhs = !wi->val_only;
+	    }
 	}
       ret = walk_tree (&TREE_VALUE (op), callback_op, wi, NULL);
       if (ret)
 	return ret;
     }
 
   if (wi)
     {
       wi->is_lhs = false;
       wi->val_only = true;
     }
 
   n = gimple_asm_nlabels (stmt);
   for (i = 0; i < n; i++)
     {
       op = gimple_asm_label_op (stmt, i);
       ret = walk_tree (&TREE_VALUE (op), callback_op, wi, NULL);
       if (ret)
 	return ret;
     }
 
   return NULL_TREE;
 }
 
 

[PATCH] PR target/48904 x86_64-knetbsd-gnu missing defs

[Bernhard Reutner-Fischer]

2012-09-21  H.J. Lu  <hongjiu.lu@intel.com>

	PR target/48904
	* config.gcc (x86_64-*-knetbsd*-gnu): Add i386/knetbsd-gnu64.h.
	* config/i386/knetbsd-gnu64.h: New file

Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
---

This fixes config-list.mk all-gcc for x86_64-knetbsd-gnu.
Ok for trunk?

 gcc/config.gcc                  |    2 +-
 gcc/config/i386/knetbsd-gnu64.h |   27 +++++++++++++++++++++++++++
 2 files changed, 28 insertions(+), 1 deletion(-)
 create mode 100644 gcc/config/i386/knetbsd-gnu64.h

diff --git a/gcc/config.gcc b/gcc/config.gcc
index a1df043..77ef473 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -1517,7 +1517,7 @@ x86_64-*-linux* | x86_64-*-kfreebsd*-gnu | x86_64-*-knetbsd*-gnu)
 		tm_file="${tm_file} kfreebsd-gnu.h i386/kfreebsd-gnu64.h"
 		;;
 	x86_64-*-knetbsd*-gnu)
-		tm_file="${tm_file} knetbsd-gnu.h"
+		tm_file="${tm_file} knetbsd-gnu.h i386/knetbsd-gnu64.h"
 		;;
 	esac
 	tmake_file="${tmake_file} i386/t-linux64"
diff --git a/gcc/config/i386/knetbsd-gnu64.h b/gcc/config/i386/knetbsd-gnu64.h
new file mode 100644
index 0000000..d621bbe
--- /dev/null
+++ b/gcc/config/i386/knetbsd-gnu64.h
@@ -0,0 +1,27 @@
+/* Definitions for AMD x86-64 running kNetBSD-based GNU systems with ELF format
+   Copyright (C) 2012
+   Free Software Foundation, Inc.
+
+This file is part of GCC.
+
+GCC is free software; you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation; either version 3, or (at your option)
+any later version.
+
+GCC is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with GCC; see the file COPYING3.  If not see
+<http://www.gnu.org/licenses/>.  */
+
+#define GNU_USER_LINK_EMULATION32 "elf_i386"
+#define GNU_USER_LINK_EMULATION64 "elf_x86_64"
+#define GNU_USER_LINK_EMULATIONX32 "elf32_x86_64"
+
+#define GNU_USER_DYNAMIC_LINKER32 "/lib/ld.so.1"
+#define GNU_USER_DYNAMIC_LINKER64 "/lib/ld-knetbsd-x86-64.so.1"
+#define GNU_USER_DYNAMIC_LINKERX32 "/lib/ld-knetbsd-x32.so.1"
-- 
1.7.10.4

Re: [PATCH] gimple-walk.c #include TLC

[Richard Biener]

On Wed, Apr 29, 2015 at 10:01 AM, Bernhard Reutner-Fischer
<rep.dot.nop@gmail.com> wrote:
> Hi there,
>
> I noticed that gimple-walk.c has a creative list of #includes.
> Furthermore, in walk_gimple_asm parse_{in,out}put_constraint was called
> even if neither allows_mem, allows_reg nor is_inout were used -- i.e. if
> wi is NULL -- and the return value of the constraint parsing was not
> taken into account which looks wrong or at least odd. Note that several
> other spots in the tree do ignore the parse_{in,out}put_constraint return
> values and should be adjusted too AFAIU. Otherwise we might attempt
> (and use!) to extract information from otherwise illegal constraints,
> it seems?
>
> Bootstrapped and regtested on x86_64-unknown-linux with no regressions.
> Ok for trunk?

Ok.

Thanks,
Richard.

> gcc/ChangeLog:
>
>         * gimple-walk.c: Prune duplicate or unneeded includes.
>         (walk_gimple_asm): Only call parse_input_constraint or
>         parse_output_constraint if their findings are used.
>         Honour parse_input_constraint and parse_output_constraint
>         result.
>
> diff --git a/gcc/gimple-walk.c b/gcc/gimple-walk.c
> index 45ff859..53462b5 100644
> --- a/gcc/gimple-walk.c
> +++ b/gcc/gimple-walk.c
> @@ -2,75 +2,69 @@
>
>     Copyright (C) 2007-2015 Free Software Foundation, Inc.
>     Contributed by Aldy Hernandez <aldyh@redhat.com>
>
>  This file is part of GCC.
>
>  GCC is free software; you can redistribute it and/or modify it under
>  the terms of the GNU General Public License as published by the Free
>  Software Foundation; either version 3, or (at your option) any later
>  version.
>
>  GCC is distributed in the hope that it will be useful, but WITHOUT ANY
>  WARRANTY; without even the implied warranty of MERCHANTABILITY or
>  FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
>  for more details.
>
>  You should have received a copy of the GNU General Public License
>  along with GCC; see the file COPYING3.  If not see
>  <http://www.gnu.org/licenses/>.  */
>
>  #include "config.h"
>  #include "system.h"
>  #include "coretypes.h"
>  #include "tm.h"
>  #include "hash-set.h"
> -#include "machmode.h"
>  #include "vec.h"
>  #include "double-int.h"
>  #include "input.h"
>  #include "alias.h"
>  #include "symtab.h"
> -#include "wide-int.h"
>  #include "inchash.h"
>  #include "tree.h"
> -#include "fold-const.h"
> -#include "stmt.h"
>  #include "predict.h"
>  #include "hard-reg-set.h"
> -#include "input.h"
>  #include "function.h"
> -#include "basic-block.h"
> -#include "tree-ssa-alias.h"
> -#include "internal-fn.h"
>  #include "gimple-expr.h"
>  #include "is-a.h"
> +#include "tree-ssa-alias.h"
> +#include "basic-block.h"
> +#include "fold-const.h"
>  #include "gimple.h"
>  #include "gimple-iterator.h"
>  #include "gimple-walk.h"
> -#include "gimple-walk.h"
> -#include "demangle.h"
> +#include "stmt.h"
>
>  /* Walk all the statements in the sequence *PSEQ calling walk_gimple_stmt
>     on each one.  WI is as in walk_gimple_stmt.
>
>     If walk_gimple_stmt returns non-NULL, the walk is stopped, and the
>     value is stored in WI->CALLBACK_RESULT.  Also, the statement that
>     produced the value is returned if this statement has not been
>     removed by a callback (wi->removed_stmt).  If the statement has
>     been removed, NULL is returned.
>
>     Otherwise, all the statements are walked and NULL returned.  */
>
>  gimple
>  walk_gimple_seq_mod (gimple_seq *pseq, walk_stmt_fn callback_stmt,
>                      walk_tree_fn callback_op, struct walk_stmt_info *wi)
>  {
>    gimple_stmt_iterator gsi;
>
>    for (gsi = gsi_start (*pseq); !gsi_end_p (gsi); )
>      {
>        tree ret = walk_gimple_stmt (&gsi, callback_stmt, callback_op, wi);
>        if (ret)
>         {
>           /* If CALLBACK_STMT or CALLBACK_OP return a value, WI must exist
>              to hold it.  */
> @@ -107,71 +101,76 @@ walk_gimple_seq (gimple_seq seq, walk_stmt_fn callback_stmt,
>
>  /* Helper function for walk_gimple_stmt.  Walk operands of a GIMPLE_ASM.  */
>
>  static tree
>  walk_gimple_asm (gasm *stmt, walk_tree_fn callback_op,
>                  struct walk_stmt_info *wi)
>  {
>    tree ret, op;
>    unsigned noutputs;
>    const char **oconstraints;
>    unsigned i, n;
>    const char *constraint;
>    bool allows_mem, allows_reg, is_inout;
>
>    noutputs = gimple_asm_noutputs (stmt);
>    oconstraints = (const char **) alloca ((noutputs) * sizeof (const char *));
>
>    if (wi)
>      wi->is_lhs = true;
>
>    for (i = 0; i < noutputs; i++)
>      {
>        op = gimple_asm_output_op (stmt, i);
>        constraint = TREE_STRING_POINTER (TREE_VALUE (TREE_PURPOSE (op)));
>        oconstraints[i] = constraint;
> -      parse_output_constraint (&constraint, i, 0, 0, &allows_mem, &allows_reg,
> -                              &is_inout);
>        if (wi)
> -       wi->val_only = (allows_reg || !allows_mem);
> +       {
> +         if (parse_output_constraint (&constraint, i, 0, 0, &allows_mem,
> +                                      &allows_reg, &is_inout))
> +           wi->val_only = (allows_reg || !allows_mem);
> +       }
>        ret = walk_tree (&TREE_VALUE (op), callback_op, wi, NULL);
>        if (ret)
>         return ret;
>      }
>
>    n = gimple_asm_ninputs (stmt);
>    for (i = 0; i < n; i++)
>      {
>        op = gimple_asm_input_op (stmt, i);
>        constraint = TREE_STRING_POINTER (TREE_VALUE (TREE_PURPOSE (op)));
> -      parse_input_constraint (&constraint, 0, 0, noutputs, 0,
> -                             oconstraints, &allows_mem, &allows_reg);
> +
>        if (wi)
>         {
> -         wi->val_only = (allows_reg || !allows_mem);
> -          /* Although input "m" is not really a LHS, we need a lvalue.  */
> -         wi->is_lhs = !wi->val_only;
> +         if (parse_input_constraint (&constraint, 0, 0, noutputs, 0,
> +                                     oconstraints, &allows_mem, &allows_reg))
> +           {
> +             wi->val_only = (allows_reg || !allows_mem);
> +             /* Although input "m" is not really a LHS, we need a lvalue.  */
> +             wi->is_lhs = !wi->val_only;
> +           }
>         }
>        ret = walk_tree (&TREE_VALUE (op), callback_op, wi, NULL);
>        if (ret)
>         return ret;
>      }
>
>    if (wi)
>      {
>        wi->is_lhs = false;
>        wi->val_only = true;
>      }
>
>    n = gimple_asm_nlabels (stmt);
>    for (i = 0; i < n; i++)
>      {
>        op = gimple_asm_label_op (stmt, i);
>        ret = walk_tree (&TREE_VALUE (op), callback_op, wi, NULL);
>        if (ret)
>         return ret;
>      }
>
>    return NULL_TREE;
>  }
>
>

Re: [PATCH] gimple-walk.c #include TLC

[Bernhard Reutner-Fischer]

On 29 April 2015 at 11:00, Richard Biener <richard.guenther@gmail.com> wrote:
> On Wed, Apr 29, 2015 at 10:01 AM, Bernhard Reutner-Fischer
> <rep.dot.nop@gmail.com> wrote:
>> Hi there,
>>
>> I noticed that gimple-walk.c has a creative list of #includes.
>> Furthermore, in walk_gimple_asm parse_{in,out}put_constraint was called
>> even if neither allows_mem, allows_reg nor is_inout were used -- i.e. if
>> wi is NULL -- and the return value of the constraint parsing was not
>> taken into account which looks wrong or at least odd. Note that several
>> other spots in the tree do ignore the parse_{in,out}put_constraint return
>> values and should be adjusted too AFAIU. Otherwise we might attempt
>> (and use!) to extract information from otherwise illegal constraints,
>> it seems?
>>
>> Bootstrapped and regtested on x86_64-unknown-linux with no regressions.
>> Ok for trunk?
>
> Ok.

r222569.
Thanks!

Re: [PATCH] PR target/48904 x86_64-knetbsd-gnu missing defs

[Jeff Law]

On 04/29/2015 02:01 AM, Bernhard Reutner-Fischer wrote:
> 2012-09-21  H.J. Lu  <hongjiu.lu@intel.com>
>
> 	PR target/48904
> 	* config.gcc (x86_64-*-knetbsd*-gnu): Add i386/knetbsd-gnu64.h.
> 	* config/i386/knetbsd-gnu64.h: New file
OK.  Please install on the trunk.

THanks,
Jeff

Re: [PATCH] PR target/48904 x86_64-knetbsd-gnu missing defs

[Bernhard Reutner-Fischer]

Hi,

On 30 April 2015 at 07:00, Jeff Law <law@redhat.com> wrote:
> On 04/29/2015 02:01 AM, Bernhard Reutner-Fischer wrote:
>>
>> 2012-09-21  H.J. Lu  <hongjiu.lu@intel.com>
>>
>>         PR target/48904
>>         * config.gcc (x86_64-*-knetbsd*-gnu): Add i386/knetbsd-gnu64.h.
>>         * config/i386/knetbsd-gnu64.h: New file
>
> OK.  Please install on the trunk.

hmz, according to https://www.debian.org/ports/netbsd/ the debian
knetbsd port is abandoned since about 2002.
If this is true (please confirm) then we should probably remove knetbsd from
- upstream config repo
- GCC
- binutils-gdb

instead of the above patchlet.
This would work equally well for me WRT config-list.mk builds..
[I should have checked this earlier, sorry..]
>
> THanks,
> Jeff
>

Re: [PATCH] PR target/48904 x86_64-knetbsd-gnu missing defs

[Guillem Jover]

Hi!

On Thu, 2015-04-30 at 09:58:28 +0200, Bernhard Reutner-Fischer wrote:
> On 30 April 2015 at 07:00, Jeff Law <law@redhat.com> wrote:
> > On 04/29/2015 02:01 AM, Bernhard Reutner-Fischer wrote:
> >>
> >> 2012-09-21  H.J. Lu  <hongjiu.lu@intel.com>
> >>
> >>         PR target/48904
> >>         * config.gcc (x86_64-*-knetbsd*-gnu): Add i386/knetbsd-gnu64.h.
> >>         * config/i386/knetbsd-gnu64.h: New file
> >
> > OK.  Please install on the trunk.
> 
> hmz, according to https://www.debian.org/ports/netbsd/ the debian
> knetbsd port is abandoned since about 2002.

Actually that page refers to the GNU/NetBSD port, which was based on
NetBSD's libc, the GNU/kNetBSD port (based on glibc), was started at
the same time as GNU/kFreeBSD but was short-lived and put into
hibernation to try to focus the effort on GNU/kFreeBSD. But that
has been a very long winter…

> If this is true (please confirm) then we should probably remove knetbsd from
> - upstream config repo
> - GCC
> - binutils-gdb

The difference between removing support in the toolchain and in the
upstream config repo is that for the former it will just need forward
porting the patches, but for the latter it takes a very long time and
lots of prodding to get upstream projects to update to current config.*
scripts. (In Debian we have been switching to always update the config.*
scripts at build time so it would probably not be too bad going forward
for us, but it would when using projects directly from upstream.)

Although I always find it a bit sad to remove ports support, I have the
impression the GNU/kNetBSD port is not coming to live any time soon. So
you might want to wait a bit for comments from others, perhaps someone
has been working on such port that we are not aware of, but otherwise I
think removal would be fine.

Thanks,
Guillem

Re: [PATCH] PR target/48904 x86_64-knetbsd-gnu missing defs

[Jeff Law]

On 04/30/2015 01:58 AM, Bernhard Reutner-Fischer wrote:
> Hi,
>
> On 30 April 2015 at 07:00, Jeff Law <law@redhat.com> wrote:
>> On 04/29/2015 02:01 AM, Bernhard Reutner-Fischer wrote:
>>>
>>> 2012-09-21  H.J. Lu  <hongjiu.lu@intel.com>
>>>
>>>          PR target/48904
>>>          * config.gcc (x86_64-*-knetbsd*-gnu): Add i386/knetbsd-gnu64.h.
>>>          * config/i386/knetbsd-gnu64.h: New file
>>
>> OK.  Please install on the trunk.
>
> hmz, according to https://www.debian.org/ports/netbsd/ the debian
> knetbsd port is abandoned since about 2002.
> If this is true (please confirm) then we should probably remove knetbsd from
> - upstream config repo
> - GCC
> - binutils-gdb
>
> instead of the above patchlet.
> This would work equally well for me WRT config-list.mk builds..
> [I should have checked this earlier, sorry..]
Given what Guillem indicated, I'd support removal.

It's often the case that we mark it as deprecated and issue an explicit 
error if someone tries to build the port.  That seems wise here.

jeff

Re: [PATCH] PR target/48904 x86_64-knetbsd-gnu missing defs

[Bernhard Reutner-Fischer]

On April 30, 2015 5:53:02 PM GMT+02:00, Jeff Law <law@redhat.com> wrote:
>On 04/30/2015 01:58 AM, Bernhard Reutner-Fischer wrote:
>> Hi,
>>
>> On 30 April 2015 at 07:00, Jeff Law <law@redhat.com> wrote:
>>> On 04/29/2015 02:01 AM, Bernhard Reutner-Fischer wrote:
>>>>
>>>> 2012-09-21  H.J. Lu  <hongjiu.lu@intel.com>
>>>>
>>>>          PR target/48904
>>>>          * config.gcc (x86_64-*-knetbsd*-gnu): Add
>i386/knetbsd-gnu64.h.
>>>>          * config/i386/knetbsd-gnu64.h: New file
>>>
>>> OK.  Please install on the trunk.
>>
>> hmz, according to https://www.debian.org/ports/netbsd/ the debian
>> knetbsd port is abandoned since about 2002.
>> If this is true (please confirm) then we should probably remove
>knetbsd from
>> - upstream config repo
>> - GCC
>> - binutils-gdb
>>
>> instead of the above patchlet.
>> This would work equally well for me WRT config-list.mk builds..
>> [I should have checked this earlier, sorry..]
>Given what Guillem indicated, I'd support removal.
>
>It's often the case that we mark it as deprecated and issue an explicit
>
>error if someone tries to build the port.  That seems wise here.

I will apply the abovementioned patch ASAP and let somebody else with janitorial spare cleanup cycles propose removal of
*-knetbsd-* then.
Given previous discussion in https://gcc.gnu.org/ml/gcc-patches/2015-04/msg00582.html someone may also be in a position to remove *-openbsd3-* support, FWIW.
I personally cannot take care of these due to limited (essentially non-existing ;) spare time.
Same, BTW for Ultrix support which was officially removed from GCC last cycle, IIRC -- unless config entries are meant to be sticky from a GNU tool chain support POV per design/decision?

Either way, cannot clean these up properly ATM and not familiar with those policies, so punting for now..

Cheers,
>
>jeff

Re: [PATCH] PR target/48904 x86_64-knetbsd-gnu missing defs

[Bernhard Reutner-Fischer]

On 1 May 2015 at 01:23, Trevor Saunders <tbsaunde@tbsaunde.org> wrote:
> On Thu, Apr 30, 2015 at 11:58:09PM +0200, Bernhard Reutner-Fischer wrote:
>> On April 30, 2015 5:53:02 PM GMT+02:00, Jeff Law <law@redhat.com> wrote:
>> >On 04/30/2015 01:58 AM, Bernhard Reutner-Fischer wrote:
>> >> Hi,
>> >>
>> >> On 30 April 2015 at 07:00, Jeff Law <law@redhat.com> wrote:
>> >>> On 04/29/2015 02:01 AM, Bernhard Reutner-Fischer wrote:
>> >>>>
>> >>>> 2012-09-21  H.J. Lu  <hongjiu.lu@intel.com>
>> >>>>
>> >>>>          PR target/48904
>> >>>>          * config.gcc (x86_64-*-knetbsd*-gnu): Add
>> >i386/knetbsd-gnu64.h.
>> >>>>          * config/i386/knetbsd-gnu64.h: New file
>> >>>
>> >>> OK.  Please install on the trunk.

Applied to trunk as r222903
Thanks,

Re: [PATCH] PR target/48904 x86_64-knetbsd-gnu missing defs

[Bernhard Reutner-Fischer]

Trevor,

On 1 May 2015 at 01:23, Trevor Saunders <tbsaunde@tbsaunde.org> wrote:
> On Thu, Apr 30, 2015 at 11:58:09PM +0200, Bernhard Reutner-Fischer wrote:
>> On April 30, 2015 5:53:02 PM GMT+02:00, Jeff Law <law@redhat.com> wrote:
>> >On 04/30/2015 01:58 AM, Bernhard Reutner-Fischer wrote:
>> >> Hi,
>> >>
>> >> On 30 April 2015 at 07:00, Jeff Law <law@redhat.com> wrote:
>> >>> On 04/29/2015 02:01 AM, Bernhard Reutner-Fischer wrote:
>> >>>>
>> >>>> 2012-09-21  H.J. Lu  <hongjiu.lu@intel.com>
>> >>>>
>> >>>>          PR target/48904
>> >>>>          * config.gcc (x86_64-*-knetbsd*-gnu): Add
>> >i386/knetbsd-gnu64.h.
>> >>>>          * config/i386/knetbsd-gnu64.h: New file
>> >>>
>> >>> OK.  Please install on the trunk.
>> >>
>> >> hmz, according to https://www.debian.org/ports/netbsd/ the debian
>> >> knetbsd port is abandoned since about 2002.
>> >> If this is true (please confirm) then we should probably remove
>> >knetbsd from
>> >> - upstream config repo
>> >> - GCC
>> >> - binutils-gdb
>> >>
>> >> instead of the above patchlet.
>> >> This would work equally well for me WRT config-list.mk builds..
>> >> [I should have checked this earlier, sorry..]
>> >Given what Guillem indicated, I'd support removal.
>> >
>> >It's often the case that we mark it as deprecated and issue an explicit
>> >
>> >error if someone tries to build the port.  That seems wise here.
>>
>> I will apply the abovementioned patch ASAP and let somebody else with janitorial spare cleanup cycles propose removal of
>> *-knetbsd-* then.
>> Given previous discussion in https://gcc.gnu.org/ml/gcc-patches/2015-04/msg00582.html someone may also be in a position to remove *-openbsd3-* support, FWIW.
>> I personally cannot take care of these due to limited (essentially non-existing ;) spare time.
>
> I'll try to get to it before the end of stage 1.  Its pretty easy
> really, you just add the triple you want to obsolete to the switch in
> config.gcc at about line 240, and then wait for the next release.
>
> btw thanks for cleaning up config-list.mk :)
>
>> Same, BTW for Ultrix support which was officially removed from GCC last cycle, IIRC -- unless config entries are meant to be sticky from a GNU tool chain support POV per design/decision?
>
> It looks like most of the ultrix references are in config.guess /
> config.sub / configure so from upstream repositories.  THere's a few
> references in gcc/doc/ that could probably be cleaned up, and a little
> bit of something in fixincludes I think.
>
> Trev
>
>>
>> Either way, cannot clean these up properly ATM and not familiar with those policies, so punting for now..
>>
>> Cheers,
>> >
>> >jeff
>>

GCC-6 stage1 now ended. Can you take care of some of these
deprecations now, please?
TIA,