From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92609 invoked by alias); 8 Sep 2016 15:25:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 92561 invoked by uid 89); 8 Sep 2016 15:25:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=interest X-HELO: mail-ua0-f181.google.com Received: from mail-ua0-f181.google.com (HELO mail-ua0-f181.google.com) (209.85.217.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 08 Sep 2016 15:25:29 +0000 Received: by mail-ua0-f181.google.com with SMTP id 31so43577120uao.0 for ; Thu, 08 Sep 2016 08:25:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=/uMKnmnEdnAT8s4BbEcntQDuzaswIXrrqVjK0nNP6dU=; b=ikUjTvR6gT/BeD0hANCifg+LxnjP+IM1keuEAd5FM1sh+0epi0116gg0LYkgPA8AJS RyqYotoXrgo+wJqKmCdV4sCN/jkxWpk0gdCP7ywdKmEX3KDK+HMnzMyIzra+iwK0Ixcm B+qDbYTllmorUqHl/c96UPQI4sJGI4e4Chlc2atpJywEzYPLMnxV2ScXtMlGtgs2kb5o oJXi78RgcPNedL+W7H6htqGJFf2VJbys0kbcZOAae28KDWk22+HAtn0FZbwUeXF6hnMg 2ckesxLcIndPJXGPRmpsdXTvdYECjGH5CweIsg3EYV3Q28uYb8alOKwJQt0pOTuxTM3m c1RQ== X-Gm-Message-State: AE9vXwPMCSBFosb0Wg0mG1CpmGV36xcXjqSC9bZGaWsjL013dO47Jgd1FbT856LsjvFXFlRut7CEk5bdFJ5efw== X-Received: by 10.176.7.42 with SMTP id h39mr159593uah.116.1473348321870; Thu, 08 Sep 2016 08:25:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.81.42 with HTTP; Thu, 8 Sep 2016 08:25:21 -0700 (PDT) In-Reply-To: <57D121F9.7000300@foss.arm.com> References: <57CEDD67.6010801@foss.arm.com> <57D121F9.7000300@foss.arm.com> From: Bernhard Reutner-Fischer Date: Thu, 08 Sep 2016 15:47:00 -0000 Message-ID: Subject: Re: [PATCH][v3] GIMPLE store merging pass To: Kyrill Tkachov Cc: GCC Patches , Richard Biener Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00449.txt.bz2 On 8 September 2016 at 10:31, Kyrill Tkachov wrote: > > On 07/09/16 20:03, Bernhard Reutner-Fischer wrote: >> >> On September 6, 2016 5:14:47 PM GMT+02:00, Kyrill Tkachov >> wrote: > Thanks, fixed all the above in my tree (will be retesting). > >> What about debug statements? ISTM you should skip those. >> (Isn't visited reset before entry of a pass?) > > > Yes, I'll skip debug statements. Comments in gimple.h say that the visited > property is undefined at pass boundaries, so I'd rather initialize it here. Right. > > >> Maybe I missed the bikeshedding about the name but I'd have used >> -fmerge-stores instead. > > > Wouldn't be hard to change. I can change it any point if there's a > consensus. Did you consider any relation to any of https://gcc.gnu.org/PR22141 https://gcc.gnu.org/PR23684 https://gcc.gnu.org/PR47059 https://gcc.gnu.org/PR54422 and their dups or https://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg77311.html (the -fmerge-bitfields suggestion from imgtec; maybe the testcases are of interest) thanks,