From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Douglas Rupp <douglas.b.rupp@gmail.com>,
Tristan Gingold <tgingold@free.fr>
Subject: Re: [PATCH] PR target/55143: undefined reference to `c_default_pointer_mode'
Date: Thu, 09 Apr 2015 19:57:00 -0000 [thread overview]
Message-ID: <CAC1BbcRrdGJYj=VXKwV7QkiAY+FdJBAvKn=0=892UdLqEKR=Eg@mail.gmail.com> (raw)
In-Reply-To: <20150409194135.GO19273@tucnak.redhat.com>
On 9 April 2015 at 21:41, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, Apr 09, 2015 at 09:27:34PM +0200, Bernhard Reutner-Fischer wrote:
>> gcc/ChangeLog:
>>
>> 2015-04-08 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
>>
>> PR target/55143
>> * c/c-tree.h (c_default_pointer_mode): Move declaration ...
>> * c-family/c-common.h (c_default_pointer_mode): ... here.
>> * c/c-decl.c (c_default_pointer_mode): Move definition ...
>> * c-family/c-common.c (c_default_pointer_mode): ... here.
>
> The ChangeLog is certainly wrong, as both c and c-family have their own
> ChangeLog files, so you really can't write it using ... on both sides.
So.. modulo leading tabs:
gcc/c/ChangeLog:
2015-04-09 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
PR target/55143
* c-decl.c (c_default_pointer_mode): Remove definition.
* c-tree.h (c_default_pointer_mode): Remove declaration.
gcc/c-family/ChangeLog:
2015-04-09 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
PR target/55143
* c-common.c (c_default_pointer_mode): Add definition.
* c-common.h (c_default_pointer_mode): Add declaration.
Ok for trunk?
thanks,
next prev parent reply other threads:[~2015-04-09 19:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 19:27 Bernhard Reutner-Fischer
2015-04-09 19:41 ` Jakub Jelinek
2015-04-09 19:57 ` Bernhard Reutner-Fischer [this message]
2015-04-09 20:09 ` Jakub Jelinek
2015-04-10 5:42 ` Tristan Gingold
2015-04-10 6:28 ` Jakub Jelinek
2015-04-10 7:56 ` Bernhard Reutner-Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC1BbcRrdGJYj=VXKwV7QkiAY+FdJBAvKn=0=892UdLqEKR=Eg@mail.gmail.com' \
--to=rep.dot.nop@gmail.com \
--cc=douglas.b.rupp@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=tgingold@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).