From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60195 invoked by alias); 9 Apr 2015 19:57:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60168 invoked by uid 89); 9 Apr 2015 19:57:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-la0-f48.google.com Received: from mail-la0-f48.google.com (HELO mail-la0-f48.google.com) (209.85.215.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 09 Apr 2015 19:57:33 +0000 Received: by lagv1 with SMTP id v1so97737454lag.3 for ; Thu, 09 Apr 2015 12:57:29 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.112.85.10 with SMTP id d10mr29808899lbz.62.1428609449835; Thu, 09 Apr 2015 12:57:29 -0700 (PDT) Received: by 10.152.45.3 with HTTP; Thu, 9 Apr 2015 12:57:29 -0700 (PDT) In-Reply-To: <20150409194135.GO19273@tucnak.redhat.com> References: <1428607654-16888-1-git-send-email-rep.dot.nop@gmail.com> <20150409194135.GO19273@tucnak.redhat.com> Date: Thu, 09 Apr 2015 19:57:00 -0000 Message-ID: Subject: Re: [PATCH] PR target/55143: undefined reference to `c_default_pointer_mode' From: Bernhard Reutner-Fischer To: Jakub Jelinek Cc: GCC Patches , Douglas Rupp , Tristan Gingold Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00412.txt.bz2 On 9 April 2015 at 21:41, Jakub Jelinek wrote: > On Thu, Apr 09, 2015 at 09:27:34PM +0200, Bernhard Reutner-Fischer wrote: >> gcc/ChangeLog: >> >> 2015-04-08 Bernhard Reutner-Fischer >> >> PR target/55143 >> * c/c-tree.h (c_default_pointer_mode): Move declaration ... >> * c-family/c-common.h (c_default_pointer_mode): ... here. >> * c/c-decl.c (c_default_pointer_mode): Move definition ... >> * c-family/c-common.c (c_default_pointer_mode): ... here. > > The ChangeLog is certainly wrong, as both c and c-family have their own > ChangeLog files, so you really can't write it using ... on both sides. So.. modulo leading tabs: gcc/c/ChangeLog: 2015-04-09 Bernhard Reutner-Fischer PR target/55143 * c-decl.c (c_default_pointer_mode): Remove definition. * c-tree.h (c_default_pointer_mode): Remove declaration. gcc/c-family/ChangeLog: 2015-04-09 Bernhard Reutner-Fischer PR target/55143 * c-common.c (c_default_pointer_mode): Add definition. * c-common.h (c_default_pointer_mode): Add declaration. Ok for trunk? thanks,