* [PATCH] mklog: Fallback to env author name and addr
@ 2015-04-08 19:37 Bernhard Reutner-Fischer
2015-04-08 19:45 ` Diego Novillo
0 siblings, 1 reply; 3+ messages in thread
From: Bernhard Reutner-Fischer @ 2015-04-08 19:37 UTC (permalink / raw)
To: gcc-patches; +Cc: Bernhard Reutner-Fischer, Diego Novillo, Cary Coutant
contrib/ChangeLog:
2015-04-08 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
* mklog ($name, $addr): Fallback to env author settings.
---
contrib/mklog | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/mklog b/contrib/mklog
index f7974a7..4cad351 100755
--- a/contrib/mklog
+++ b/contrib/mklog
@@ -53,9 +53,9 @@ if (-f "$conf") {
. $dot_mklog_format_msg;
}
} else {
- $name = `git config user.name`;
+ $name = `git config user.name` || $ENV{GIT_AUTHOR_NAME};
chomp($name);
- $addr = `git config user.email`;
+ $addr = `git config user.email` || $ENV{GIT_AUTHOR_EMAIL};
chomp($addr);
if (!($name && $addr)) {
--
2.1.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mklog: Fallback to env author name and addr
2015-04-08 19:37 [PATCH] mklog: Fallback to env author name and addr Bernhard Reutner-Fischer
@ 2015-04-08 19:45 ` Diego Novillo
2015-04-08 20:04 ` Bernhard Reutner-Fischer
0 siblings, 1 reply; 3+ messages in thread
From: Diego Novillo @ 2015-04-08 19:45 UTC (permalink / raw)
To: Bernhard Reutner-Fischer; +Cc: gcc-patches, Cary Coutant
On Wed, Apr 8, 2015 at 3:36 PM, Bernhard Reutner-Fischer
<rep.dot.nop@gmail.com> wrote:
> contrib/ChangeLog:
>
> 2015-04-08 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
>
> * mklog ($name, $addr): Fallback to env author settings.
This looks fine, but note that I no longer have approval rights for
patches. Code in contrib/ has looser requirements, and the patch is
clearly harmless. I would just add documentation on the GIT_AUTHOR_*
environment variables at the top of the script.
Diego.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mklog: Fallback to env author name and addr
2015-04-08 19:45 ` Diego Novillo
@ 2015-04-08 20:04 ` Bernhard Reutner-Fischer
0 siblings, 0 replies; 3+ messages in thread
From: Bernhard Reutner-Fischer @ 2015-04-08 20:04 UTC (permalink / raw)
To: Diego Novillo; +Cc: gcc-patches, Cary Coutant
On 8 April 2015 at 21:45, Diego Novillo <dnovillo@google.com> wrote:
> On Wed, Apr 8, 2015 at 3:36 PM, Bernhard Reutner-Fischer
> <rep.dot.nop@gmail.com> wrote:
>> contrib/ChangeLog:
>>
>> 2015-04-08 Bernhard Reutner-Fischer <aldot@gcc.gnu.org>
>>
>> * mklog ($name, $addr): Fallback to env author settings.
>
> This looks fine, but note that I no longer have approval rights for
yuck. I remember now, what a pity.
> patches. Code in contrib/ has looser requirements, and the patch is
> clearly harmless. I would just add documentation on the GIT_AUTHOR_*
> environment variables at the top of the script.
I'll document them, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-08 20:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-08 19:37 [PATCH] mklog: Fallback to env author name and addr Bernhard Reutner-Fischer
2015-04-08 19:45 ` Diego Novillo
2015-04-08 20:04 ` Bernhard Reutner-Fischer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).