From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-394814-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 85185 invoked by alias); 8 Apr 2015 20:04:12 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 85164 invoked by uid 89); 8 Apr 2015 20:04:12 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-la0-f45.google.com
Received: from mail-la0-f45.google.com (HELO mail-la0-f45.google.com) (209.85.215.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 08 Apr 2015 20:04:08 +0000
Received: by laat2 with SMTP id t2so67346663laa.1        for <gcc-patches@gcc.gnu.org>; Wed, 08 Apr 2015 13:04:04 -0700 (PDT)
MIME-Version: 1.0
X-Received: by 10.112.67.107 with SMTP id m11mr24776421lbt.43.1428523444563; Wed, 08 Apr 2015 13:04:04 -0700 (PDT)
Received: by 10.152.45.3 with HTTP; Wed, 8 Apr 2015 13:04:04 -0700 (PDT)
In-Reply-To: <CAD_=9DTJJvN7ag+Yzr1bn0CTdifDR0GWgpvYCK-kPrkMrAc7EQ@mail.gmail.com>
References: <1428521808-30487-1-git-send-email-rep.dot.nop@gmail.com>	<CAD_=9DTJJvN7ag+Yzr1bn0CTdifDR0GWgpvYCK-kPrkMrAc7EQ@mail.gmail.com>
Date: Wed, 08 Apr 2015 20:04:00 -0000
Message-ID: <CAC1BbcS0JaviMeCbSs4PMtXsACPKvXvb5ubaqyW2rsCgBd6dhg@mail.gmail.com>
Subject: Re: [PATCH] mklog: Fallback to env author name and addr
From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Diego Novillo <dnovillo@google.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, Cary Coutant <ccoutant@gmail.com>
Content-Type: text/plain; charset=UTF-8
X-IsSubscribed: yes
X-SW-Source: 2015-04/txt/msg00354.txt.bz2

On 8 April 2015 at 21:45, Diego Novillo <dnovillo@google.com> wrote:
> On Wed, Apr 8, 2015 at 3:36 PM, Bernhard Reutner-Fischer
> <rep.dot.nop@gmail.com> wrote:
>> contrib/ChangeLog:
>>
>> 2015-04-08  Bernhard Reutner-Fischer  <aldot@gcc.gnu.org>
>>
>>         * mklog ($name, $addr): Fallback to env author settings.
>
> This looks fine, but note that I no longer have approval rights for

yuck. I remember now, what a pity.

> patches. Code in contrib/ has looser requirements, and the patch is
> clearly harmless. I would just add documentation on the GIT_AUTHOR_*
> environment variables at the top of the script.

I'll document them, thanks!