From: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
To: Mike Stump <mikestump@comcast.net>
Cc: Uros Bizjak <ubizjak@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, testsuite]: Cleanup dumps
Date: Thu, 23 Apr 2015 08:24:00 -0000 [thread overview]
Message-ID: <CAC1BbcT+gNRhkv0B2qP4xKD+p55b1deSzdSwsuJBgEejA2k0ig@mail.gmail.com> (raw)
In-Reply-To: <CBF828DA-6601-4210-81D4-BE87F1A81E01@comcast.net>
On 1 February 2015 at 18:49, Mike Stump <mikestump@comcast.net> wrote:
> On Jan 31, 2015, at 1:55 PM, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote:
>>
>> What about the -Wcomment question?
>
> I don’t consider it linked in anyway to the patch at hand. I’m not a big fan of the default flags being much different than the flags the user normally sees. That said, would be nice to avoid this issue. The best way forward I can think of would be a wholesale change to // style comments in the test suite for all test cases that accept that language. // is standard C and C++, and by convention, I think they are fine in Objective-C and Obective-C++.
I won't do a wholesale change to C++-style comments in the testsuite
(where applicable),
that's too time-consuming.
Since you OKed the patch cited below, i suggest i apply those hunks of
the manual patch that are still relevant since i think they make sense
regardless of the auto-wipe dumpfiles stuff going in or not.
>
>> And can you help with the two ??? maybe?
>
> Which type of help?
In the last posted patch
https://gcc.gnu.org/ml/gcc-patches/2013-12/msg01749.html
there is only one question left:
+ foreach src $testcases {
+ set basename [file tail $src]
+ if { $ltrans != "" } {
+ # ??? should we use upvar 1 output_file instead of this (dup ?)
+ set stem [file rootname $basename]
+ set basename_ext [file extension $basename]
+ if {$basename_ext != ""} {
+ regsub -- {^.*\.} $basename_ext {} basename_ext
+ }
+ lappend tfiles "$stem.{$basename_ext,exe}"
+ unset basename_ext
+ } else {
+ lappend tfiles $basename
+ }
+ }
I wasn't sure if upvar 1 output_file would globally work? WDYT?
PS: IIRC someone from codesourcery meanwhile fixed the pch test
objects leftovers
so the
* lib/dg-pch.exp(pch-init): Remove pch-check objects.
is obsolete by now.
next prev parent reply other threads:[~2015-04-23 8:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 15:38 Uros Bizjak
[not found] ` <7B4175B2-2FAA-4A96-943B-06B379D03C75@gmail.com>
[not found] ` <4420E8FB-D61F-4F61-8A86-6ADE01B235E9@comcast.net>
[not found] ` <FFFCE31D-72C2-4542-9A1D-2C67E8DE07D8@gmail.com>
[not found] ` <089F97D9-DDFA-420E-8BCA-353F704B0A94@gmail.com>
2015-02-01 17:50 ` Mike Stump
2015-04-23 8:24 ` Bernhard Reutner-Fischer [this message]
2015-05-28 9:48 ` [PATCH] auto-wipe dump files, part1, manual stuff Bernhard Reutner-Fischer
2015-05-29 8:44 ` [PATCH, testsuite]: Cleanup dumps Bernhard Reutner-Fischer
2015-05-29 10:08 ` Bernhard Reutner-Fischer
2022-04-25 21:34 ` Bernhard Reutner-Fischer
2015-05-29 13:33 ` Kyrill Tkachov
2015-05-29 13:38 ` Bernhard Reutner-Fischer
2015-05-29 21:14 ` Christophe Lyon
-- strict thread matches above, loose matches on Subject: below --
2014-11-04 18:21 Uros Bizjak
2013-12-08 21:47 [PATCH, testsuite ]: " Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC1BbcT+gNRhkv0B2qP4xKD+p55b1deSzdSwsuJBgEejA2k0ig@mail.gmail.com \
--to=rep.dot.nop@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
--cc=ubizjak@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).