From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75949 invoked by alias); 23 Apr 2015 08:24:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 75936 invoked by uid 89); 23 Apr 2015 08:24:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-lb0-f179.google.com Received: from mail-lb0-f179.google.com (HELO mail-lb0-f179.google.com) (209.85.217.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Thu, 23 Apr 2015 08:24:18 +0000 Received: by lbbqq2 with SMTP id qq2so7716919lbb.3 for ; Thu, 23 Apr 2015 01:24:15 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.112.41.236 with SMTP id i12mr1497988lbl.14.1429777455376; Thu, 23 Apr 2015 01:24:15 -0700 (PDT) Received: by 10.152.45.3 with HTTP; Thu, 23 Apr 2015 01:24:15 -0700 (PDT) In-Reply-To: References: <7B4175B2-2FAA-4A96-943B-06B379D03C75@gmail.com> <4420E8FB-D61F-4F61-8A86-6ADE01B235E9@comcast.net> <089F97D9-DDFA-420E-8BCA-353F704B0A94@gmail.com> Date: Thu, 23 Apr 2015 08:24:00 -0000 Message-ID: Subject: Re: [PATCH, testsuite]: Cleanup dumps From: Bernhard Reutner-Fischer To: Mike Stump Cc: Uros Bizjak , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg01385.txt.bz2 On 1 February 2015 at 18:49, Mike Stump wrote: > On Jan 31, 2015, at 1:55 PM, Bernhard Reutner-Fischer wrote: >> >> What about the -Wcomment question? > > I don=E2=80=99t consider it linked in anyway to the patch at hand. I=E2= =80=99m not a big fan of the default flags being much different than the fl= ags the user normally sees. That said, would be nice to avoid this issue. = The best way forward I can think of would be a wholesale change to // styl= e comments in the test suite for all test cases that accept that language. = // is standard C and C++, and by convention, I think they are fine in Obje= ctive-C and Obective-C++. I won't do a wholesale change to C++-style comments in the testsuite (where applicable), that's too time-consuming. Since you OKed the patch cited below, i suggest i apply those hunks of the manual patch that are still relevant since i think they make sense regardless of the auto-wipe dumpfiles stuff going in or not. > >> And can you help with the two ??? maybe? > > Which type of help? In the last posted patch https://gcc.gnu.org/ml/gcc-patches/2013-12/msg01749.html there is only one question left: + foreach src $testcases { + set basename [file tail $src] + if { $ltrans !=3D "" } { + # ??? should we use upvar 1 output_file instead of this (dup ?) + set stem [file rootname $basename] + set basename_ext [file extension $basename] + if {$basename_ext !=3D ""} { + regsub -- {^.*\.} $basename_ext {} basename_ext + } + lappend tfiles "$stem.{$basename_ext,exe}" + unset basename_ext + } else { + lappend tfiles $basename + } + } I wasn't sure if upvar 1 output_file would globally work? WDYT? PS: IIRC someone from codesourcery meanwhile fixed the pch test objects leftovers so the * lib/dg-pch.exp(pch-init): Remove pch-check objects. is obsolete by now.