From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-x1135.google.com (mail-yw1-x1135.google.com [IPv6:2607:f8b0:4864:20::1135]) by sourceware.org (Postfix) with ESMTPS id 8CC7F3858C62 for ; Mon, 24 Jul 2023 03:28:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8CC7F3858C62 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=nevada.unr.edu Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=nevada.unr.edu Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-5839f38342fso28842237b3.0 for ; Sun, 23 Jul 2023 20:28:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nevada-unr-edu.20221208.gappssmtp.com; s=20221208; t=1690169294; x=1690774094; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=wbAQLOLDmQVIzX7YSUGZyjRJYwss1b6Tk3R54YSzcoU=; b=3OSuNrL9BRX6LHyPo4xPuYT2/8Uj1Wb87knBa9fhxCorClKXErSDMOReD3HJBKQASD Y2faJAyUwPfHUxUBqAFXzBDTt4/CxHyFyJnnjLOKdU3IdxsCgDUbYMqdDqcCuhRwDM6y 4c5fHxpTmffpLn3q3kCeyq37oaXWX2QRiDOvor/tWLJT7KkCrGDmMYpPNOvMwiDblhu4 bGO4i0okRvuBopGAk8K1tL8orl3ZNph25Wh2KX3B0bY6asJHmzQo+QxPMK3d6tR8L7LC sGuR3lgbwABO34uoujGLPHGs70mXucCMBiJ/wztL8IaTTRRVO2ejNM5Ocm3s5O7TlXg9 hQsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690169294; x=1690774094; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=wbAQLOLDmQVIzX7YSUGZyjRJYwss1b6Tk3R54YSzcoU=; b=kBQGez9BeruHylSjgvoHfYEdc9tlyTnY5TmI5VhxhAeOrBpi9Cl8RC88E030BdQjH4 raIHgIK8eVAugTWrdu6Ic+ngGijJapAcq0SEkEDZNX+4PulpzBcqNvdajOFz/naBtNDV BEXPedI+ketrYRHUS71C3o8GwvrP0bNs690BE9h0n6/8PYPz4ux5KTnwcTeWoI+ESn8b HXEqpV7JdajSa9j69UDEziX6VQgVjzDrN888AjftTFWv1lYjF0RlK64zVLqGxm3Cn8ex S62brjIJzgWoKlr1ABRhra6I4w+nGOA75QtvHJKMCPUpP7Yf7Dy/x62e+SaOFcJ+9EUT 6Rkg== X-Gm-Message-State: ABy/qLZ6DbgwFJsaYG6Xxi8jFRfpsdUxtQT+HcR6hMR4vlt2IZUyoGE4 sDhoEAcxIc5iOsPGipveFiizYwJu/O5mFtY1B+pdQF9h8eq9RbjBZGw= X-Google-Smtp-Source: APBJJlFX2QDIjZ96k4Dt6a1YAf6EdW+Mu2Do/lVv9je9W8boEAoyX66yDbzuejFuGvHhslcMGSjLda7Po+5ysM5yVwM= X-Received: by 2002:a0d:d803:0:b0:56d:d58:82b7 with SMTP id a3-20020a0dd803000000b0056d0d5882b7mr5933789ywe.23.1690169293677; Sun, 23 Jul 2023 20:28:13 -0700 (PDT) MIME-Version: 1.0 From: Deev Patel Date: Sun, 23 Jul 2023 20:28:02 -0700 Message-ID: Subject: [PATCH] libstdc++: Add missing constexpr specifier and function overloads To: gcc-patches@gcc.gnu.org Content-Type: multipart/alternative; boundary="0000000000005c3e40060133349f" X-Spam-Status: No, score=-8.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000005c3e40060133349f Content-Type: text/plain; charset="UTF-8" Hi, A couple of virtual functions in the libstdc++ format header are marked constexpr in the base class, but not in the derived class. This was causing build failures when trying to compile latest gcc libstd with clang 16 using c++20. Adding the constexpr specifier resolves the issue. 2023-07-23 Deev Patel * include/std/format: Add missing constexpr specifiers on function overloads >From ac34afa1109b4c82e5cc377f49abf55422b89529 Mon Sep 17 00:00:00 2001 From: Deev Patel Date: Sun, 23 Jul 2023 20:08:46 -0700 Subject: [PATCH] [libstdc++] Add missing constexpr specifiers on function overloads --- libstdc++-v3/include/std/format | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libstdc++-v3/include/std/format b/libstdc++-v3/include/std/format index 9710bff3c03..0c6069b2681 100644 --- a/libstdc++-v3/include/std/format +++ b/libstdc++-v3/include/std/format @@ -3554,14 +3554,14 @@ namespace __format using iterator = typename _Scanner<_CharT>::iterator; - void + constexpr void _M_on_chars(iterator __last) override { basic_string_view<_CharT> __str(this->begin(), __last); _M_fc.advance_to(__format::__write(_M_fc.out(), __str)); } - void + constexpr void _M_format_arg(size_t __id) override { using _Context = basic_format_context<_Out, _CharT>; -- 2.41.0 --0000000000005c3e40060133349f--