From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id C969C3858D28 for ; Thu, 7 Jul 2022 02:20:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C969C3858D28 Received: by mail-lf1-x135.google.com with SMTP id bu42so8954409lfb.0 for ; Wed, 06 Jul 2022 19:20:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yN9SWOYYxaY5Wk8D1OSwJVJr6DOvANBUFcfAFwKzmMA=; b=NbxHt2i//v/NflhmuxQ7EhRSXCZB0n5l4ylxsleCuv8Pf3PK9a66oy9QJ2dcBW2g6e cbSpzonZDygr77E8peUsZKvZaVQYGofxKbzeVHLGAHgj+bWSvtx3ZwPUpo3aapdtXsZR DS5+Q4NK4ep60kl6uIfvnYVrIfBUmOZZSz1ZfahH7b8qRTCZQ9AIXWjiNaqPwik4GTXp sEBPdLdU+3pJkb/X2us10zPeSOOTpaKkawZ2V9rtRFDiVfp/4eHQxnF2LrDafvA1tX1c wHJTgBAT5j3ETuK/9QDKHHQ7EnkgI58imWEwo9Y+FMFF5D+YWnxr5ae0JoXuusc+cRR0 sTcA== X-Gm-Message-State: AJIora+7/2LU2QqEzT6JTFX372dggKhnw69Z1RsWvvBB0rjJhyUbBnQS 7nGNH20uMHQypHc8JEsDFSi0gJTcgspGUfnuhbo= X-Google-Smtp-Source: AGRyM1sUAKgX1Lvrf2HlecwgyhdOuQXQENEm0fgbchrBsb4mo3C4wy7QRHb4AaKIRIq+kWoE/5C8Y6FEuEoEODCOgR4= X-Received: by 2002:a05:6512:1053:b0:481:18b4:a90 with SMTP id c19-20020a056512105300b0048118b40a90mr27397899lfb.22.1657160399943; Wed, 06 Jul 2022 19:19:59 -0700 (PDT) MIME-Version: 1.0 References: <803a0290-3909-b9c5-2461-b1740a00c63a@suse.cz> <146a46f1-3a56-48c5-386f-c15633cc6781@ispras.ru> <37b52d36-d1dd-f291-0baa-0cf670493692@suse.cz> <4e3df681-9523-4781-d324-9a6e230f495a@suse.cz> <3dc13790-a22d-c4d6-6cfe-ab9b567968ff@suse.cz> In-Reply-To: From: Rui Ueyama Date: Thu, 7 Jul 2022 10:19:48 +0800 Message-ID: Subject: Re: [PATCH 3/3] lto-plugin: implement LDPT_GET_API_VERSION To: =?UTF-8?Q?Martin_Li=C5=A1ka?= Cc: Richard Biener , Alexander Monakov , GCC Patches X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Jul 2022 02:20:04 -0000 On Mon, Jul 4, 2022 at 10:17 PM Martin Li=C5=A1ka wrote: > On 7/1/22 08:36, Richard Biener wrote: > > On Thu, Jun 30, 2022 at 10:42 AM Martin Li=C5=A1ka wro= te: > >> > >> On 6/30/22 08:43, Rui Ueyama wrote: > >>> Thanks Martin for creating this patch. > >> > >> You're welcome. > >> > >>> > >>> Here is a preliminary change for the mold side: > https://github.com/rui314/mold/commit/9ad49d1c556bc963d06cca8233535183490= de605 > < > https://github.com/rui314/mold/commit/9ad49d1c556bc963d06cca8233535183490= de605 > > > >>> > >>> Overall the API is looking fine, > >> > >> Good then! > >> > >>> though it is not clear what kind of value is expected as a linker > version. A linker version is not a single unsigned integer but something > like "1.3.0". Something like "1.3.0-rc2" can also be a linker version. So= I > don't think we can represent a linker version as a single integer. > >> > >> Well, you can use the same what we use GCC_VERSION (plugin_version): > >> > >> 1000 * MAJOR + MINOR > >> > >> Let me adjust the documentation of the API. > > > > Hmm, but then why not go back to the original suggestion merging > > linker_identifier and linker_version into > > a single string. That of course puts the burden of parsing to the > > consumer - still that's probably better > > than imposing the constraint of encoding the version in an unsigned > > integer. Alternatively easing > > parsing by separating out the version in a string would be possible as > > well (but then you'd have > > to care for 1.3.0-rc2+gitab4316174 or so, not sure what the advantage > > over putting everything in > > the identifier would be). > > I'm fine with the suggested 2 strings (linker_identifier and > linker_version). > > Does it work for you Rui? > Yes. > Cheers, > Martin > > > > > You usually cannot rely on a version anyway since distributors usually > > apply patches. > > > >> Richi: May I install the patch? > > > > Let's sort out the version thing and consider simplifying the API. > > > > Richard. > > > >> Thanks, > >> Martin > >> > >>> > >>> On Mon, Jun 20, 2022 at 9:01 PM Martin Li=C5=A1ka mliska@suse.cz>> wrote: > >>> > >>> On 6/20/22 11:35, Richard Biener wrote: > >>> > I think this is OK. Can we get buy-in from mold people? > >>> > >>> Sure, I've just pinged Rui: > >>> https://github.com/rui314/mold/issues/454#issuecomment-1160419030 > > >>> > >>> Martin > >>> > >