From: Dmitry Vyukov <dvyukov@google.com>
To: Yury Gribov <y.gribov@samsung.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Jakub Jelinek <jakub@redhat.com>,
Konstantin Serebryany <konstantin.s.serebryany@gmail.com>,
Andrey Ryabinin <a.ryabinin@samsung.com>,
Konstantin Khlebnikov <k.khlebnikov@samsung.com>
Subject: Re: [PATCH] Enable -fsanitize-recover for KASan
Date: Fri, 05 Sep 2014 08:23:00 -0000 [thread overview]
Message-ID: <CACT4Y+bHX7gFYto-TYejBf_OrCocL7Hi073FzmEb2=kO6tY-WQ@mail.gmail.com> (raw)
In-Reply-To: <54097083.8010403@samsung.com>
On Fri, Sep 5, 2014 at 12:12 PM, Yury Gribov <y.gribov@samsung.com> wrote:
> On 09/05/2014 11:32 AM, Dmitry Vyukov wrote:
>>
>> Can we do it w/o doubling number of runtime entry points?
>
>
> I didn't find a good way to achieve this. See, normal asan reporting
> functions
> have a noreturn attribute (defined in sanitizer.def) which can't be changed
> depending on cmdline flag.
I have not looked at the code in detail. But it looks weird to me that
in a general-purpose programming language we can't alter an attribute
of an in-memory object. I would expect that the attribute is just a
field in a struct describing the functionm and the field can be freely
set/reset. Is not it the case?
>> Looks like a wrong way to pass global options to runtime.
>> If we need
>> to pass several other options, number of entry points will sky rocket.
>
>
> We only need new definitions if functions look significantly different for
> compiler
> (noreturn, etc.).
>
>> I vaguely remember there are some globals that compiler uses to
>> communicate configuration (version, shadow base) to runtime.
>
>
> This would make the recovery setting global then.
> It may be desirable to have per-object (or even per-function) options (or
> maybe not).
This makes sense.
Leaving for others to chime in.
next prev parent reply other threads:[~2014-09-05 8:23 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 6:54 Yury Gribov
2014-09-05 7:32 ` Dmitry Vyukov
2014-09-05 8:12 ` Yury Gribov
2014-09-05 8:23 ` Dmitry Vyukov [this message]
2014-09-05 8:33 ` Yury Gribov
2014-09-05 9:28 ` Jakub Jelinek
2014-09-05 9:32 ` Yury Gribov
2014-09-05 9:05 ` Andrey Ryabinin
2014-09-05 9:12 ` Yury Gribov
2014-09-15 9:38 ` [PATCH][PING] " Yury Gribov
2014-09-18 10:53 ` Jakub Jelinek
2014-09-18 13:14 ` Yury Gribov
2014-09-18 23:47 ` Joseph S. Myers
2014-09-29 17:21 ` [PATCHv3][PING] " Yury Gribov
2014-09-29 17:44 ` Jakub Jelinek
2014-09-29 21:20 ` Konstantin Serebryany
2014-09-29 22:37 ` Alexey Samsonov
[not found] ` <CAGSYnCPwbgZ++2Jt2vE6-ytveSJwSQPZT5umLeKPVWsVjWzwPQ@mail.gmail.com>
2014-09-29 23:17 ` Jakub Jelinek
2014-09-29 23:26 ` Alexey Samsonov
2014-09-30 0:24 ` Konstantin Serebryany
2014-09-30 1:05 ` Alexey Samsonov
2014-09-30 1:49 ` Konstantin Serebryany
2014-09-30 5:40 ` Jakub Jelinek
2014-09-30 7:07 ` Yury Gribov
2014-09-30 17:26 ` Alexey Samsonov
2014-09-30 17:33 ` Jakub Jelinek
2014-09-30 17:36 ` Alexey Samsonov
2014-09-30 17:39 ` Jakub Jelinek
2014-10-01 23:21 ` Alexey Samsonov
2014-10-02 5:58 ` Jakub Jelinek
2014-10-03 18:54 ` Alexey Samsonov
[not found] ` <543BADAB.4090000@samsung.com>
2014-10-17 16:16 ` [PATCH] -fsanitize-recover=list Jakub Jelinek
2014-10-20 10:44 ` Yury Gribov
2014-10-22 8:05 ` Yury Gribov
2014-10-22 10:02 ` Jakub Jelinek
2014-11-18 2:50 ` Alexey Samsonov
2014-11-18 7:27 ` Jakub Jelinek
2014-11-18 8:29 ` Alexey Samsonov
2014-11-18 8:34 ` Jakub Jelinek
2014-11-18 20:25 ` Alexey Samsonov
2014-12-19 2:47 ` Alexey Samsonov
2014-12-19 8:14 ` Jakub Jelinek
[not found] ` <CAGSYnCNLoU0p3FGDwb6mMAAOWFz2Te1m7wmWD94PhcADsQs9rQ@mail.gmail.com>
2015-01-05 17:40 ` [PATCH] -f{no-sanitize,{,no-}sanitize-recover}=all support Jakub Jelinek
2015-01-05 20:32 ` Jeff Law
2015-01-05 21:40 ` Jakub Jelinek
2015-01-05 22:02 ` Jakub Jelinek
2015-01-06 9:00 ` Dodji Seketeli
2014-11-18 7:39 ` [PATCH] -fsanitize-recover=list Yury Gribov
2014-09-30 6:57 ` [PATCHv3][PING] Enable -fsanitize-recover for KASan Yury Gribov
2014-09-30 7:14 ` Yury Gribov
2014-10-23 7:15 ` [PATCHv4] " Yury Gribov
2014-10-23 7:20 ` Jakub Jelinek
2014-10-23 7:30 ` Yury Gribov
2014-10-23 9:55 ` Andrey Ryabinin
2014-10-23 10:00 ` Jakub Jelinek
2014-10-23 10:07 ` Jakub Jelinek
2014-10-23 10:24 ` Andrey Ryabinin
2014-10-23 10:27 ` Yury Gribov
2014-10-23 10:11 ` Andrey Ryabinin
2014-10-23 10:17 ` Jakub Jelinek
2014-10-23 10:38 ` Yury Gribov
2014-10-23 10:39 ` Jakub Jelinek
2014-10-23 11:12 ` Andrey Ryabinin
2014-10-24 8:37 ` Yury Gribov
2014-10-24 9:46 ` Dmitry Vyukov
2014-10-24 9:52 ` Jakub Jelinek
2014-10-24 9:56 ` Dmitry Vyukov
2014-10-24 9:59 ` Jakub Jelinek
2014-10-24 10:01 ` Yury Gribov
2014-10-24 10:21 ` Dmitry Vyukov
2014-10-28 8:46 ` [PATCH v5] " Yury Gribov
2014-10-28 9:31 ` Jakub Jelinek
2014-10-28 10:15 ` Yury Gribov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACT4Y+bHX7gFYto-TYejBf_OrCocL7Hi073FzmEb2=kO6tY-WQ@mail.gmail.com' \
--to=dvyukov@google.com \
--cc=a.ryabinin@samsung.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=k.khlebnikov@samsung.com \
--cc=konstantin.s.serebryany@gmail.com \
--cc=y.gribov@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).