From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17710 invoked by alias); 22 Nov 2011 10:37:31 -0000 Received: (qmail 17701 invoked by uid 22791); 22 Nov 2011 10:37:30 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-iy0-f175.google.com (HELO mail-iy0-f175.google.com) (209.85.210.175) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 22 Nov 2011 10:37:17 +0000 Received: by iahk25 with SMTP id k25so2191iah.20 for ; Tue, 22 Nov 2011 02:37:17 -0800 (PST) MIME-Version: 1.0 Received: by 10.50.100.232 with SMTP id fb8mr19720047igb.8.1321958237043; Tue, 22 Nov 2011 02:37:17 -0800 (PST) Received: by 10.50.236.8 with HTTP; Tue, 22 Nov 2011 02:37:16 -0800 (PST) In-Reply-To: <1321957587.15343.6.camel@e102549-lin.cambridge.arm.com> References: <4EBBD52A.6040707@arm.com> <1320948467.17411.17.camel@e102549-lin.cambridge.arm.com> <4737A960563B524DA805CA602BE04B3060291A4EDB@SC-VEXCH2.marvell.com> <1321957587.15343.6.camel@e102549-lin.cambridge.arm.com> Date: Tue, 22 Nov 2011 13:07:00 -0000 Message-ID: Subject: Re: [RFA/ARM][Patch 01/02]: Thumb2 epilogue in RTL From: Ramana Radhakrishnan To: Sameera Deshpande Cc: Xinyu Qi , "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-11/txt/msg02206.txt.bz2 >> >> Though I don't fully understand this patch, I think it is unnecessary to consider turn on Thumb2 for iwmmxt, >> because there is no chip that supports WMMX instructions with thumb2 mode. Xinyu: I seem to have mis-remembered that one of your patches was turning on Thumb2 for wMMX. > > Ramana, in that case, should I add the change you suggested in ARM RTL > epilogue patch only? The comment in Thumb2 epilogues should remain and yes - it should be added to the ARM RTL epilogue patch only. I'm also ok with that being in with a #if 0 around it but given it's in the epilogue whoever tries turning on Thumb2 for iwMMX will surely notice that in the first testrun :) I'll try and find some time later today to apply both the patches and see where I get to. cheers Ramana > > -- > > >