From: Ramana Radhakrishnan <ramana.radhakrishnan@linaro.org>
To: Xinyu Qi <xyqi@marvell.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, ARM, iWMMXt][1/5]: ARM code generic change
Date: Tue, 12 Jul 2011 22:45:00 -0000 [thread overview]
Message-ID: <CACUk7=Uei=urPFJUG5AzBV=swHkRc-tOjATXpRD+A0kbLvNXmg@mail.gmail.com> (raw)
In-Reply-To: <4737A960563B524DA805CA602BE04B306010D8E698@SC-VEXCH2.marvell.com>
On 06/07/11 11:11, Xinyu Qi wrote:
> Hi,
>
> It is the first part of iWMMXt maintenance.
>
> *config/arm/arm.c (arm_option_override):
> Enable iWMMXt with VFP. iWMMXt and NEON are incompatible. iWMMXt unsupported under Thumb-2 mode.
> (arm_expand_binop_builtin): Accept immediate op (with mode VOID)
> *config/arm/arm.md:
> Resettle include location of iwmmxt.md so that *arm_movdi and *arm_movsi_insn could be used when iWMMXt is enabled.
With the current work in trunk to handle enabled attributes and
per-alternative predicable attributes (Thanks Bernd) we should be able
to get rid of
*cond_iwmmxt_movsi_insn" in iwmmxt.md file. It's not a matter for
this patch but for a follow-up patch.
Actually we should probably do the same for the various insns that
are dotted around all over the place with final conditions that prevent
matching - atleast makes the backend description slightly smaller :).
> Add pipeline description file include.
It is enough to say
(<filename>): Include.
in the changelog entry.
The include for the pipeline description file should be with the patch
that you add this in i.e. patch #5. Please add this to MD_INCLUDES in
t-arm as well.
Also as a general note, please provide a correct Changelog entry.
This is not the format that we expect Changelog entries to be in.
Please look at the coding standards on the website for this or at
other patches submitted with respect to Changelog entries. Please fix
this for each patch in the patch stack.
cheers
Ramana
next prev parent reply other threads:[~2011-07-12 22:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-06 10:24 Xinyu Qi
2011-07-12 22:45 ` Ramana Radhakrishnan [this message]
2011-07-14 7:38 ` Xinyu Qi
2011-08-18 2:21 ` Ramana Radhakrishnan
2011-08-18 8:24 ` Xinyu Qi
2011-12-14 17:03 ` Richard Earnshaw
2011-12-22 6:39 ` Xinyu Qi
2011-12-29 6:25 ` Xinyu Qi
2012-02-03 2:03 ` Xinyu Qi
2012-03-13 8:54 ` PING: " Xinyu Qi
2012-05-29 4:13 [PATCH ARM iWMMXt 0/5] Improve iWMMXt support Matt Turner
2012-05-29 4:14 ` [PATCH ARM iWMMXt 1/5] ARM code generic change Matt Turner
2012-06-06 11:53 ` Ramana Radhakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACUk7=Uei=urPFJUG5AzBV=swHkRc-tOjATXpRD+A0kbLvNXmg@mail.gmail.com' \
--to=ramana.radhakrishnan@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=xyqi@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).