From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28074 invoked by alias); 12 Jul 2011 22:29:38 -0000 Received: (qmail 28066 invoked by uid 22791); 12 Jul 2011 22:29:37 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qw0-f47.google.com (HELO mail-qw0-f47.google.com) (209.85.216.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Jul 2011 22:29:03 +0000 Received: by qwh5 with SMTP id 5so3049293qwh.20 for ; Tue, 12 Jul 2011 15:29:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.194.138 with SMTP id dy10mr453507qab.0.1310509742460; Tue, 12 Jul 2011 15:29:02 -0700 (PDT) Received: by 10.224.2.81 with HTTP; Tue, 12 Jul 2011 15:29:02 -0700 (PDT) In-Reply-To: <4737A960563B524DA805CA602BE04B306010D8E698@SC-VEXCH2.marvell.com> References: <4737A960563B524DA805CA602BE04B306010D8E698@SC-VEXCH2.marvell.com> Date: Tue, 12 Jul 2011 22:45:00 -0000 Message-ID: Subject: Re: [PATCH, ARM, iWMMXt][1/5]: ARM code generic change From: Ramana Radhakrishnan To: Xinyu Qi Cc: "gcc-patches@gcc.gnu.org" Content-Type: text/plain; charset=ISO-8859-1 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-07/txt/msg00971.txt.bz2 On 06/07/11 11:11, Xinyu Qi wrote: > Hi, > > It is the first part of iWMMXt maintenance. > > *config/arm/arm.c (arm_option_override): > Enable iWMMXt with VFP. iWMMXt and NEON are incompatible. iWMMXt unsupported under Thumb-2 mode. > (arm_expand_binop_builtin): Accept immediate op (with mode VOID) > *config/arm/arm.md: > Resettle include location of iwmmxt.md so that *arm_movdi and *arm_movsi_insn could be used when iWMMXt is enabled. With the current work in trunk to handle enabled attributes and per-alternative predicable attributes (Thanks Bernd) we should be able to get rid of *cond_iwmmxt_movsi_insn" in iwmmxt.md file. It's not a matter for this patch but for a follow-up patch. Actually we should probably do the same for the various insns that are dotted around all over the place with final conditions that prevent matching - atleast makes the backend description slightly smaller :). > Add pipeline description file include. It is enough to say (): Include. in the changelog entry. The include for the pipeline description file should be with the patch that you add this in i.e. patch #5. Please add this to MD_INCLUDES in t-arm as well. Also as a general note, please provide a correct Changelog entry. This is not the format that we expect Changelog entries to be in. Please look at the coding standards on the website for this or at other patches submitted with respect to Changelog entries. Please fix this for each patch in the patch stack. cheers Ramana