From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28854 invoked by alias); 20 Oct 2011 09:09:31 -0000 Received: (qmail 28846 invoked by uid 22791); 20 Oct 2011 09:09:30 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qw0-f47.google.com (HELO mail-qw0-f47.google.com) (209.85.216.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 20 Oct 2011 09:09:10 +0000 Received: by qam2 with SMTP id 2so2170892qam.20 for ; Thu, 20 Oct 2011 02:09:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.61.97 with SMTP id s33mr2240673qch.51.1319101749738; Thu, 20 Oct 2011 02:09:09 -0700 (PDT) Received: by 10.229.215.207 with HTTP; Thu, 20 Oct 2011 02:09:09 -0700 (PDT) In-Reply-To: <4E9F274F.50704@mozilla.com> References: <4E9F274F.50704@mozilla.com> Date: Thu, 20 Oct 2011 09:29:00 -0000 Message-ID: Subject: Re: [Patch ARM] Fix PR target/50106 From: Ramana Radhakrishnan To: Nathan Froyd Cc: gcc-patches@gcc.gnu.org, Jakub Jelinek Content-Type: multipart/mixed; boundary=0016e651fbe0373c6604afb74f78 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg01846.txt.bz2 --0016e651fbe0373c6604afb74f78 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 646 On 19 October 2011 20:38, Nathan Froyd wrote: > On 10/19/2011 3:27 PM, Ramana Radhakrishnan wrote: >> >> Index: gcc/config/arm/arm.c >> - =A0 =A0 =A0live_regs_mask |=3D extra_mask<< =A0(size / UNITS_PER_WORD); >> + =A0 =A0 =A0live_regs_mask |=3D extra_mask<< =A0((size + 3) / UNITS_PER= _WORD); > > IIUC, wouldn't ((size + UNITS_PER_WORD - 1) / UNITS_PER_WORD) be clearer? > > -Nathan > Doh ! Yes , this is what I committed. Ramana 2011-10-20 Ramana Radhakrishnan PR target/50106 * config/arm/arm.c (thumb_unexpanded_epilogue): Handle return reg size from 1-3. --0016e651fbe0373c6604afb74f78 Content-Type: text/plain; charset=US-ASCII; name="p1.txt" Content-Disposition: attachment; filename="p1.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_gtzj3x7g0 Content-length: 712 SW5kZXg6IGdjYy9jb25maWcvYXJtL2FybS5jCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIGdjYy9jb25maWcvYXJtL2FybS5jCShyZXZpc2lvbiAxODAy MzkpCisrKyBnY2MvY29uZmlnL2FybS9hcm0uYwkod29ya2luZyBjb3B5KQpA QCAtMjE2NTIsNyArMjE2NTIsOCBAQAogICBpZiAoZXh0cmFfcG9wID4gMCkK ICAgICB7CiAgICAgICB1bnNpZ25lZCBsb25nIGV4dHJhX21hc2sgPSAoMSA8 PCBleHRyYV9wb3ApIC0gMTsKLSAgICAgIGxpdmVfcmVnc19tYXNrIHw9IGV4 dHJhX21hc2sgPDwgKHNpemUgLyBVTklUU19QRVJfV09SRCk7CisgICAgICBs aXZlX3JlZ3NfbWFzayB8PSBleHRyYV9tYXNrIDw8ICgoc2l6ZSArIFVOSVRT X1BFUl9XT1JEIC0gMSkgCisJCQkJICAgICAgIC8gVU5JVFNfUEVSX1dPUkQp OwogICAgIH0KIAogICAvKiBUaGUgcHJvbG9nIG1heSBoYXZlIHB1c2hlZCBz b21lIGhpZ2ggcmVnaXN0ZXJzIHRvIHVzZSBhcwo= --0016e651fbe0373c6604afb74f78--