From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6835 invoked by alias); 21 Oct 2011 12:45:39 -0000 Received: (qmail 6827 invoked by uid 22791); 21 Oct 2011 12:45:39 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qw0-f47.google.com (HELO mail-qw0-f47.google.com) (209.85.216.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Oct 2011 12:45:25 +0000 Received: by qam2 with SMTP id 2so3230971qam.20 for ; Fri, 21 Oct 2011 05:45:25 -0700 (PDT) MIME-Version: 1.0 Received: by 10.229.61.97 with SMTP id s33mr3217529qch.51.1319201123921; Fri, 21 Oct 2011 05:45:23 -0700 (PDT) Received: by 10.229.215.207 with HTTP; Fri, 21 Oct 2011 05:45:23 -0700 (PDT) In-Reply-To: <1318325869.2186.67.camel@e102549-lin.cambridge.arm.com> References: <1318324138.2186.40.camel@e102549-lin.cambridge.arm.com> <1318325869.2186.67.camel@e102549-lin.cambridge.arm.com> Date: Fri, 21 Oct 2011 13:30:00 -0000 Message-ID: Subject: Re: [RFA/ARM][Patch 05/05]: LDRD generation instead of POP in A15 ARM epilogue. From: Ramana Radhakrishnan To: Sameera Deshpande Cc: "gcc-patches@gcc.gnu.org" , "nickc@redhat.com" , Richard Earnshaw , "paul@codesourcery.com" , Ramana Radhakrishnan Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-10/txt/msg01971.txt.bz2 > 2011-10-11 =A0Sameera Deshpande > > > =A0 =A0 =A0 =A0* config/arm/arm.c (arm_emit_ldrd_pop): New static functio= n. > =A0 =A0 =A0 =A0 =A0(arm_expand_epilogue): Update. > =A0 =A0 =A0 =A0* config/arm/ldmstm.md (arm_ldrd_base): New pattern. > =A0 =A0 =A0 =A0 =A0(arm_ldr_with_update): Likewise. rth's comment about REG_CFA_RESTORE applies here as well. Please change that. Other than that this patch looks OK and please watch out for stylistic issues from the previous patch. Ramana > -- > > >