From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31795 invoked by alias); 27 Sep 2011 16:17:28 -0000 Received: (qmail 31784 invoked by uid 22791); 27 Sep 2011 16:17:26 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-pz0-f47.google.com (HELO mail-pz0-f47.google.com) (209.85.210.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 27 Sep 2011 16:17:07 +0000 Received: by pzk4 with SMTP id 4so19359549pzk.6 for ; Tue, 27 Sep 2011 09:17:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.33.130 with SMTP id r2mr37687704pbi.71.1317140226820; Tue, 27 Sep 2011 09:17:06 -0700 (PDT) Received: by 10.68.55.101 with HTTP; Tue, 27 Sep 2011 09:17:06 -0700 (PDT) In-Reply-To: <201109271655.38344.paul@codesourcery.com> References: <201109271655.38344.paul@codesourcery.com> Date: Tue, 27 Sep 2011 17:01:00 -0000 Message-ID: Subject: Re: RFC: ARM: Add comment enumerating emitted .eabi_attribute tags From: Ramana Radhakrishnan To: Paul Brook Cc: Nick Clifton , richard.earnshaw@arm.com, gcc-patches@gcc.gnu.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-09/txt/msg01742.txt.bz2 On 27 September 2011 16:55, Paul Brook wrote: >> Hi Nick, >> >> On 27 September 2011 15:38, Nick Clifton wrote: >> > =A0Any comments or objections to this patch ? =A0If not, I will apply = it >> > =A0next week. >> >> I've got a few objections to this patch as it stands today while I >> don't object to the motivation for it. >> >> > +/* Get the definitions of the ARM EABI Attribute tag values. =A0*/ >> > +#define BFD_ARCH_SIZE >> > +#include "elf/arm.h" >> >> Defining BFD_ARCH_SIZE appears to be a bit of a hack. I would also >> ifdef this inclusion on TARGET_AAPCS since we shouldn't really be >> caring about object attributes for non AAPCS configurations. > > TARGET_AAPCS doesn't exist. If you mean TARGET_AAPCS_BASED then this is a > runtime expression and can't be used for preprocessor conditionals. =A0Ei= ther > way I don't think we really care. =A0The important thing is that we only = emit > the .eabi_attribute directives on EABI based targets. Bah yes - you are right. > > A more important consideration is that this file does not exist. Amen. Ramana