From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6397 invoked by alias); 1 Aug 2011 15:43:30 -0000 Received: (qmail 6383 invoked by uid 22791); 1 Aug 2011 15:43:26 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from mail-qw0-f47.google.com (HELO mail-qw0-f47.google.com) (209.85.216.47) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 01 Aug 2011 15:43:11 +0000 Received: by qwh5 with SMTP id 5so3328374qwh.20 for ; Mon, 01 Aug 2011 08:43:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.211.196 with SMTP id gp4mr3466925qab.103.1312213391020; Mon, 01 Aug 2011 08:43:11 -0700 (PDT) Received: by 10.224.185.142 with HTTP; Mon, 1 Aug 2011 08:43:10 -0700 (PDT) In-Reply-To: <20110726090228.GE6925@davesworkthinkpad> References: <20110701155254.GA5242@davesworkthinkpad> <20110726085910.GA6925@davesworkthinkpad> <20110726090039.GB6925@davesworkthinkpad> <20110726090115.GC6925@davesworkthinkpad> <20110726090156.GD6925@davesworkthinkpad> <20110726090228.GE6925@davesworkthinkpad> Date: Mon, 01 Aug 2011 15:43:00 -0000 Message-ID: Subject: Re: [Patch 4/4] ARM 64 bit sync atomic operations [V2] From: Ramana Radhakrishnan To: "Dr. David Alan Gilbert" Cc: gcc-patches@gcc.gnu.org, rth@redhat.com, joseph@codesourcery.com, patches@linaro.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-08/txt/msg00063.txt.bz2 On 26 July 2011 10:02, Dr. David Alan Gilbert wr= ote: > > =A0 =A0 =A0 =A0gcc/ > =A0 =A0 =A0 =A0* config/arm/arm.c (TARGET_HAVE_DMB_MCR) MCR Not available= in Thumb1 > =A0 =A0 =A0 =A0 =A0but is available on armv6 `:' after (TARGET_HAVE_DMB_MCR) and something like `Disable for Thumb1.' instead of what's on there. > > =A0/* Nonzero if this chip implements a memory barrier via CP15. =A0*/ > -#define TARGET_HAVE_DMB_MCR =A0 =A0(arm_arch6k && ! TARGET_HAVE_DMB) > +#define TARGET_HAVE_DMB_MCR =A0 =A0(arm_arch6 && ! TARGET_HAVE_DMB \ > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0&& ! TAR= GET_THUMB1) Otherwise OK for trunk and afflicted release branches since this really is a bug fix. cheers Ramana