From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-x231.google.com (mail-lj1-x231.google.com [IPv6:2a00:1450:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id ED1B03858401; Thu, 1 Jun 2023 13:50:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED1B03858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-lj1-x231.google.com with SMTP id 38308e7fff4ca-2af2d092d7aso12207191fa.2; Thu, 01 Jun 2023 06:50:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685627422; x=1688219422; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5/snSery3GQzjZTc8/qBGSkW/aLiYMrIBpiy9Y/lQNE=; b=dwOHCSOiC68RXniyb0lzNv4IgW5CkYB+D1BJo7BPP35Fej037xef2m/b0GuAn/945S Phxd55VoTj0c4XS9rpNxXzgk68WB114ouj+bQB+ZHPHTQ4DCzFDcVlOUAml/+RejdOPH 7/zqjHhMISh2YecQKptSXz6HcSAXt5nk0irMbeKK3scoZzzvIVaZxtbsIXfC7HHQBzO6 LXVRG9+uXZBhwwVDmMiX7p+x5IOu1kfTql3/bnxUPc7uyIRoK95yLMMODvLgxODiQ183 9SGZm/30yJnEz4bnI7yYYhDd/camSumWnhr/SUuSAQSEkKYqlOc6cliETjd8OdTyCpZr 7j2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685627422; x=1688219422; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5/snSery3GQzjZTc8/qBGSkW/aLiYMrIBpiy9Y/lQNE=; b=VIRfupaJvGEcv7A0WlwPG5Aiqdyn4qCq7yVQBJQNckn1eHoBiJ6fmhmx7OmkOOq5rA 1JzpceD3Gq/8uJg43uxCAwbWlb+ItUhkURLfR4a8VSo7nyVu5+A8m7aw6R8jTX6KY/FT Lqipk1mBKe+ZgQZgRkA4q3LmxAeydN6RDICwZhfZdgJVdu8pcSgTLL7vSc57WrmM/aOZ Cnhqm3uMQZzLV3teRF768pPmwVeVbIYlQQuyOSZmOqTEuA4CdsP1lM2DxatOTvOixgZe fwe/yzSmJB3E4rcA2F3M/7/jdrX3Tv1VW1ImN2COAWD3pLPON6fgNPiYc81HWXOBp5fC zgIA== X-Gm-Message-State: AC+VfDwnJcajSXmFlVYoiHivFmwRjcm77TOJS0LjiRqkegSWEJpbkvz6 Bx0+LQvwQso1EluBXAtKaoOlU3e3EUDCLzSCF5o= X-Google-Smtp-Source: ACHHUZ7dnFQPFQT+9MotLSZ5M48yz/HuF5kcy1vo8XoieSIouUuXuQ8pRbHdPZvJQPRC8DV+zXikZFK4tx8ebOfi6jQ= X-Received: by 2002:a2e:86cf:0:b0:2a8:c75c:96cb with SMTP id n15-20020a2e86cf000000b002a8c75c96cbmr4653667ljj.1.1685627422014; Thu, 01 Jun 2023 06:50:22 -0700 (PDT) MIME-Version: 1.0 References: <01f2b9e7-14e8-12a7-c275-7e48e3bd94df@gmail.com> In-Reply-To: From: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Date: Thu, 1 Jun 2023 15:50:09 +0200 Message-ID: Subject: Re: [PATCH] Move std::search into algobase.h To: Jonathan Wakely Cc: Rainer Orth , Jonathan Wakely via Gcc-patches , "libstdc++" Content-Type: multipart/alternative; boundary="000000000000b6805a05fd11b763" X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000b6805a05fd11b763 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sorry, I had fully tested the move from bits/stl_algo.h to bits/stl_algobase.h. But it appears that the script I used to run the tests after the other move has not done what I expected. I'll provide the patch shortly. Le jeu. 1 juin 2023 =C3=A0 14:06, Jonathan Wakely a = =C3=A9crit : > > > On Thu, 1 Jun 2023 at 12:52, Rainer Orth > wrote: > >> Jonathan Wakely via Gcc-patches writes: >> >> > On Wed, 31 May 2023 at 18:39, Fran=C3=A7ois Dumont via Libstdc++ < >> > libstdc++@gcc.gnu.org> wrote: >> > >> >> libstdc++: Reduce inclusion to >> >> >> >> >> >> Move the std::search definition from stl_algo.h to stl_algobase.h and >> use >> >> the later in . >> >> >> >> For consistency also move std::__parallel::search and associated >> helpers >> >> from >> >> to so that >> >> std::__parallel::search >> >> is accessible along with std::search. >> >> >> >> libstdc++-v3/ChangeLog: >> >> >> >> * include/bits/stl_algo.h >> >> (std::__search, std::search(_FwdIt1, _FwdIt1, _FwdIt2, >> >> _FwdIt2, _BinPred)): Move... >> >> * include/bits/stl_algobase.h: ...here. >> >> * include/std/functional: Replace include by >> >> . >> >> * include/parallel/algo.h (std::__parallel::search<_FIt1, >> >> _FIt2, _BinaryPred>) >> >> (std::__parallel::__search_switch<_FIt1, _FIt2, >> >> _BinaryPred, _ItTag1, _ItTag2>): >> >> Move... >> >> * include/parallel/algobase.h: ...here. >> >> * include/std/functional: Remove and >> >> >> >> includes. Include . >> >> >> >> Tested under Linux x86_64. >> >> >> >> Ok to commit ? >> >> >> > >> > OK >> >> This seems to have caused >> >> +FAIL: 17_intro/headers/c++2011/parallel_mode.cc (test for excess errors) >> +FAIL: 17_intro/headers/c++2014/parallel_mode.cc (test for excess errors) >> >> on i386-pc-solaris2.11: >> > > I think it affects all targets. > > >> >> Excess errors: >> /var/gcc/regression/master/11.4-gcc-gas/build/i386-pc-solaris2.11/libstd= c++-v3/include/parallel/algobase.h:496: >> error: '__search_template' is not a member of '__gnu_parallel'; did you >> mean '__find_template'? >> >> Rainer >> >> -- >> >> ------------------------------------------------------------------------= ----- >> Rainer Orth, Center for Biotechnology, Bielefeld University >> >> --000000000000b6805a05fd11b763--