From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 74709382EA1E for ; Wed, 24 Aug 2022 12:15:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 74709382EA1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661343357; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YxP6dMbqCJ9ncpzaF3UKlxUF/3vE6efdZ9BRFO8tTVA=; b=JaODAiNsfl4G2A64gtfTNxkXsOnNHCoCaoFotQckHdKWHpnIorQD/86BaXT8OxUOcBk0Wu 49I5vd6sZMRaiLbwXxndc+pfGJ2nHMQIeT30CkKtU9suYPBWaw+iqxtVzRb9l82NaXjgfR qbVT6b9y9wdDms8ANQsgDguEoJWg5ZM= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-2-LKC26pQuOBijcv39dX5ezA-1; Wed, 24 Aug 2022 08:15:55 -0400 X-MC-Unique: LKC26pQuOBijcv39dX5ezA-1 Received: by mail-qv1-f70.google.com with SMTP id n17-20020ad444b1000000b00496d5b41d37so5789793qvt.6 for ; Wed, 24 Aug 2022 05:15:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=YxP6dMbqCJ9ncpzaF3UKlxUF/3vE6efdZ9BRFO8tTVA=; b=q7f7V8+geZ9jfDmI80VhA+Jgpb1uZNHCoTUO5Oq02rSfN6vJYvRY29lMdo8uW6DqxZ EtYHbZfxorB4uSRtFa5HAjr6SPF6WVY7fzicbbvIGI7RKq+yGLZJvq5ANXUgO6OmwnBL DaBU/lHKUViJ+AQmuGbgXsjXo1OsTk3GqdcuLck+WaUZ2sJpczPIHMns2r5xquAJoPA5 843KR5ARWVOO8nrR5xfBbCKYNJlIJsGMbpB3uwfMyxr2GdQ0FyjpDilAPa3W0LdlEpCy gKGw3iAHarfcTqwmK0dwN2dFbi7V3Gx12dE0JTb8B6QTBXUEZ6v1ny3VlS+wuOa2/Sh5 76vQ== X-Gm-Message-State: ACgBeo0qy1PJbEtOR4WuLF1YDnJfWzQwXf1+I8Tt/WZv3KSWvpW1JMz6 XbkcjTouDwo8Oijhh17UJzoovgLXk1+YuPJPJhOuuGj+EcYrBuYYL/p/V9w45+z3bfyWmxnIa6m dIYVFq1kr56pvCarXk+BYKAi7EoNSZjTBmA== X-Received: by 2002:ad4:5be2:0:b0:476:7e0d:815f with SMTP id k2-20020ad45be2000000b004767e0d815fmr23273877qvc.57.1661343354822; Wed, 24 Aug 2022 05:15:54 -0700 (PDT) X-Google-Smtp-Source: AA6agR5RjbKiarvs+rn+acgVqA3868/YcI6AFPAN8vfq/in/mGbrwDKG3TaLM3o3Iw5VcqQdGfjOs5Db76RKGZCvxVY= X-Received: by 2002:ad4:5be2:0:b0:476:7e0d:815f with SMTP id k2-20020ad45be2000000b004767e0d815fmr23273853qvc.57.1661343354594; Wed, 24 Aug 2022 05:15:54 -0700 (PDT) MIME-Version: 1.0 References: <20220823013500.1756466-1-ppalka@redhat.com> <20220823013500.1756466-3-ppalka@redhat.com> In-Reply-To: <20220823013500.1756466-3-ppalka@redhat.com> From: Jonathan Wakely Date: Wed, 24 Aug 2022 13:15:43 +0100 Message-ID: Subject: Re: [PATCH 3/3] libstdc++: Implement ranges::zip_view from P2321R2 To: Patrick Palka Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 23 Aug 2022 at 02:38, Patrick Palka via Libstdc++ wrote: > > Tested on 86_64-pc-linux-gnu, does this look OK for trunk? As discussed privately, please remove the #include (which is not needed, and adds declarations to the global namespace that we don't need). OK with that change, thanks. N.B. re the TODOs, we already have a constexpr abs in but it's probably not worth including that just for one function, that you've already managed without.