From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 694E23858D28 for ; Wed, 18 Jan 2023 21:47:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 694E23858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674078444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qXKRYoPCtjGqazF+2VTFdbtsLeiBbk6qHjbFnbUyNvk=; b=cTg+/f4hAvDYi/1waHBM9lGUGdKV8iwvjyiDkPupdguEqMEs1qmORVj1ye6HiZNdkjE0Xp 8p6rlgYXX4lkFvK+59zBp9h9/vuPyNIAv8MNXXm0ESQTtXK7Y5O1BcATZzpC/B0OCRlY3F Q5Wry9Yu2kvudIpHnX0jF3W9T0UueCo= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-659-h5peo-n_OS2nWh4UyIHsxg-1; Wed, 18 Jan 2023 16:47:23 -0500 X-MC-Unique: h5peo-n_OS2nWh4UyIHsxg-1 Received: by mail-lf1-f72.google.com with SMTP id q9-20020a19a409000000b004b6ee156e03so123307lfc.5 for ; Wed, 18 Jan 2023 13:47:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qXKRYoPCtjGqazF+2VTFdbtsLeiBbk6qHjbFnbUyNvk=; b=UJPzpUUW0scr/QQxP5Vsj3qZDHefzeEBG6fruX9BYoIPek4gcYHIMib27n85JEFeNg jNSeSagts/rwBPLb5VzC+qhV3RCV8IWGU4TOeLNSBLqzWGdI89r+ZR1h05IM3NpCqxt1 yeRwArcg4TKts4HhCWJwXCwEqQP8UpJwmWTdNNF3axyCa4vm1qJGyoMo7bFoCfED/QmT G6BRBIqnFV0IA8ru8Ci5rlxOfKL0UmYmzzBGqXvvZ987idyiSBJy7bhItAAQtZ5QRB5Z c4hM+g4n0QFEiDFfF7YZue/NgNOGSuWj82Y0+dwBskd8/y+ByFt/FqTIUJrKFgdc1/cd ldjw== X-Gm-Message-State: AFqh2kqAA5lj3LikakDx5WOw5Q7M5MZvQR9x1gYsu0MaGHdLYAByv0+d mRK4IxbhykMbbefRDlP481AB6K84np14k5c3Dj1EwyOUQ/b0+AqoYQdskTm7zY57y9nllCmaG16 Cdzy+GhWwd3oRZuhAVEpJxS++lVT4wVKQBg== X-Received: by 2002:a2e:8052:0:b0:27f:bf59:2a45 with SMTP id p18-20020a2e8052000000b0027fbf592a45mr482859ljg.22.1674078441616; Wed, 18 Jan 2023 13:47:21 -0800 (PST) X-Google-Smtp-Source: AMrXdXvEouKu2B0MU4SKUZxTkzkdys5XFoD8JBZyUfLIyFu4mqhFMi3OqEZt5oiEm54fe1sL1DlfUwal4moyDAlBhIg= X-Received: by 2002:a2e:8052:0:b0:27f:bf59:2a45 with SMTP id p18-20020a2e8052000000b0027fbf592a45mr482855ljg.22.1674078441224; Wed, 18 Jan 2023 13:47:21 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jonathan Wakely Date: Wed, 18 Jan 2023 21:47:09 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: testsuite: Simplify codecvt_unicode To: Dimitrij Mijoski Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 18 Jan 2023 at 19:52, Dimitrij Mijoski wrote: > > On Wed, 2023-01-18 at 18:53 +0000, Jonathan Wakely wrote: > > This doesn't compile in C++11 or C++14, because there's no guaranteed > > elision. > > I see. I just looked up in the docs and found that I need to put > --target_board=unix/-std=c++11 inside RUNTESTFLAGS to test in C++11 > mode. That's right. I have multiple options used by default, via ~/.dejagnurc $ cat ~/.dejagnurc # Need to test if $tool exists prior to the r11-551 change. if { [info exists tool] && "$tool" == "libstdc++" } { global tool_timeout set tool_timeout 50 puts "dejagnu - timeout default set to ${tool_timeout}s" set target_list { "unix{,-D_GLIBCXX_USE_CXX11_ABI=0,-std=gnu++2b,-std=gnu++11}" } } This makes the testsuite take four times as long, but increases coverage and finds issues like this one. As long as somebody runs the extended list of options now and then, we don't need them to all be run for everybody.