From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 933AB3858D32 for ; Fri, 17 Nov 2023 08:15:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 933AB3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 933AB3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700208915; cv=none; b=sGLRuG3IMkgF7SoAW1uTfqm+VmxOQ3PU3hJJpkg8tmqPBvP6lODygsTHMPC1wWvaBjFonH3ixxf8zaetaR2YtjjtEoiRni/eM+lrcZO+pIpWHexCGt1w67ANxZQiu/mgkqqSWFF19+KzJbhCrN6IiBJfycDalktxNlCw62d/Vqw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700208915; c=relaxed/simple; bh=wFmag9353dmdB0VEmxtWMzq4rLyyHCD3IUrDc5iYilw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=wNzl1PeWLaH0kWk3hnTJDfAUmGLtTDhAAHBNRwdjbPHF6cwQAbxz7czNwcTbMTeB6VxCHNKAO8ZH6TlmJhBWxtmn7KgLtYN8/P1ycwmZYG5pOP4ENOr3zaUgHg8Pz6xB80ZukgwcuYxW5QeoszDbv4ul9XGyQW2UND7KmBHvBUQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700208914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=X1aFPvTBtn4Q+JKw9djeujn+1v7GL2hn7+zCCw2KRy4=; b=Gs3ylZ4SKaLNa8vfMIBTBets4CCsfFEl6VMfiE072oklXdELcUP7EIeuV8K8I8hDYEJ0PS 83WwmcKUeWwLIHKFxfSV/oU9DwfAmWMLcOWd+BlMjL/glKjxmDSRegraqP4Bh6FPmoyRmz LzepGf+jletGzt0HTgRBjfXR4Fjktrg= Received: from mail-yw1-f197.google.com (mail-yw1-f197.google.com [209.85.128.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-526--CNwIdtUNo6qAnsiuy8Aog-1; Fri, 17 Nov 2023 03:15:12 -0500 X-MC-Unique: -CNwIdtUNo6qAnsiuy8Aog-1 Received: by mail-yw1-f197.google.com with SMTP id 00721157ae682-5be6d0a23beso13605027b3.1 for ; Fri, 17 Nov 2023 00:15:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700208912; x=1700813712; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=X1aFPvTBtn4Q+JKw9djeujn+1v7GL2hn7+zCCw2KRy4=; b=l3Qywi1cmtVYDQpdRCgpA8KhTV2qcXOyPYXMC4P1gXWLioON+cGOWyKATEcs/6+aQp MnSJqTYXPmi09qJ5d+zOwFXvOi2ubdgcEIr4O45/RVqAZ8ULvPLenBEDOcHdjTfJNr9J 0c81w5WYLdcpXY4uNxy4CWhNHBQJbERza+Th6Gb30W7OgOCYMIiu8dSGwCiUDi8LGqM3 eFED/VD+vLOV/Od3EYUkA9K9tDSgbxIIqo08xW3RF78tOJ7rmQoi2YP8uMsdi6pp0eY+ OcK8FoXlJt1A5/74ZS6EDQ+7kn8W/XyaEAsWP2N9xWah1ocn+35hatjB9d9MR+NvDJE8 AluQ== X-Gm-Message-State: AOJu0YyhquCIbq7gvx+QJCJT+H3VTRiJYdEuWyeEmNteXmQ+HtAnayLL UXLSuV68eVML12MJ70el435e6aSfqCY+jzA9x1aGVwf9+JEydhDZQzrqK9mdaqPrgi8gk2raV/o DzGGCDyilNkXL6BOqUxg4VNa+pPrjD18qFw== X-Received: by 2002:a0d:e7c5:0:b0:5c8:6a41:86c8 with SMTP id q188-20020a0de7c5000000b005c86a4186c8mr301725ywe.7.1700208911988; Fri, 17 Nov 2023 00:15:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IELRo9DtE4u9XFA/vZN4b+RYbm5yJ1tZQPuaCjY15Jea8rvNqPOIkdU5LrxqlD8rtrrUkM2dbvfDovJM4oCrFE= X-Received: by 2002:a0d:e7c5:0:b0:5c8:6a41:86c8 with SMTP id q188-20020a0de7c5000000b005c86a4186c8mr301718ywe.7.1700208911755; Fri, 17 Nov 2023 00:15:11 -0800 (PST) MIME-Version: 1.0 References: <20231116081324.1221069-1-jwakely@redhat.com> <20231117044355.43F5720420@pchp3.se.axis.com> In-Reply-To: <20231117044355.43F5720420@pchp3.se.axis.com> From: Jonathan Wakely Date: Fri, 17 Nov 2023 08:15:00 +0000 Message-ID: Subject: Re: [committed] libstdc++: Implement std::out_ptr and std::inout_ptr for C++23 [PR111667] To: Hans-Peter Nilsson Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 17 Nov 2023 at 04:44, Hans-Peter Nilsson wrote: > > > From: Jonathan Wakely > > Date: Thu, 16 Nov 2023 08:12:39 +0000 > > > PR libstdc++/111667 > > * include/Makefile.am: Add new header. > > * include/Makefile.in: Regenerate. > > * include/bits/out_ptr.h: New file. > > * include/bits/shared_ptr.h (__is_shared_ptr): Move definition > > to here ... > > * include/bits/shared_ptr_atomic.h (__is_shared_ptr): ... from > > here. > > * include/bits/shared_ptr_base.h (__shared_count): Declare > > out_ptr_t as a friend. > > (_Sp_counted_deleter, __shared_ptr): Likewise. > > * include/bits/unique_ptr.h (unique_ptr, unique_ptr): > > Declare out_ptr_t and inout_ptr_t as friends. > > (__is_unique_ptr): Define new variable template. > > * include/bits/version.def (out_ptr): Define. > > * include/bits/version.h: Regenerate. > > * include/std/memory: Include new header. > > * testsuite/20_util/smartptr.adapt/inout_ptr/1.cc: New test. > > * testsuite/20_util/smartptr.adapt/inout_ptr/2.cc: New test. > > * testsuite/20_util/smartptr.adapt/inout_ptr/shared_ptr_neg.cc: > > New test. > > * testsuite/20_util/smartptr.adapt/inout_ptr/void_ptr.cc: New > > test. > > * testsuite/20_util/smartptr.adapt/out_ptr/1.cc: New test. > > * testsuite/20_util/smartptr.adapt/out_ptr/2.cc: New test. > > * testsuite/20_util/smartptr.adapt/out_ptr/shared_ptr_neg.cc: > > New test. > > * testsuite/20_util/smartptr.adapt/out_ptr/void_ptr.cc: New > > test. > > This commit, r14-5524-gc7f6537db94f7c, exposed or caused, for several targets: > FAIL: g++.dg/modules/xtreme-header-4_b.C -std=c++2b (internal compiler error: tree check: expected class 'type', have 'declaration' (template_decl) in get_originating_module_decl, at cp/module.cc:18649) > FAIL: g++.dg/modules/xtreme-header-4_b.C -std=c++2b (test for excess errors) > FAIL: g++.dg/modules/xtreme-header-5_b.C -std=c++2b (internal compiler error: tree check: expected class 'type', have 'declaration' (template_decl) in get_originating_module_decl, at cp/module.cc:18649) > FAIL: g++.dg/modules/xtreme-header-5_b.C -std=c++2b (test for excess errors) > FAIL: g++.dg/modules/xtreme-header_b.C -std=c++2b (internal compiler error: tree check: expected class 'type', have 'declaration' (template_decl) in get_originating_module_decl, at cp/module.cc:18649) > FAIL: g++.dg/modules/xtreme-header_b.C -std=c++2b (test for excess errors) > > See PR 112580. > > (BTW, I can't tell from the archive, whether the > "Linaro-TCWG-CI" tester notified you or just sent its report > to the gcc-regression@ list.) Yes, I got a direct email too. These modules/xtreme-header tests are the gift that keeps on giving.