public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: Matthias Kretz <m.kretz@gsi.de>
Cc: gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Fix SFINAE for __is_intrinsic_type on ARM
Date: Wed, 24 May 2023 12:02:06 +0100	[thread overview]
Message-ID: <CACb0b4=Bn8LzUXkspMcKFUn0WU9Sk5wq=ZkGF1va=oa_05EabQ@mail.gmail.com> (raw)
In-Reply-To: <13148454.CDJkKcVGEf@minbar>

[-- Attachment #1: Type: text/plain, Size: 1493 bytes --]

On Wed, 24 May 2023 at 11:59, Matthias Kretz via Libstdc++ <
libstdc++@gcc.gnu.org> wrote:

> OK for master and all branches? (this issue only surfaced because of the
> new
> test)
>

OK.



>
> ------------ 8< -----------------
>
> On ARM NEON doesn't support double, so __is_intrinsic_type_v<double,
> whatever> should say false (instead of being ill-formed).
>
> Signed-off-by: Matthias Kretz <m.kretz@gsi.de>
>
> libstdc++-v3/ChangeLog:
>
>         PR libstdc++/109261
>         * include/experimental/bits/simd.h (__intrinsic_type):
>         Specialize __intrinsic_type<double, 8> and
>         __intrinsic_type<double, 16> in any case, but provide the member
>         type only with __aarch64__.
> ---
>  libstdc++-v3/include/experimental/bits/simd.h | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
>
> --
> ──────────────────────────────────────────────────────────────────────────
>  Dr. Matthias Kretz                           https://mattkretz.github.io
>  GSI Helmholtz Centre for Heavy Ion Research               https://gsi.de
>  stdₓ::simd
> ──────────────────────────────────────────────────────────────────────────

      reply	other threads:[~2023-05-24 11:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-24 10:58 Matthias Kretz
2023-05-24 11:02 ` Jonathan Wakely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACb0b4=Bn8LzUXkspMcKFUn0WU9Sk5wq=ZkGF1va=oa_05EabQ@mail.gmail.com' \
    --to=jwakely@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    --cc=m.kretz@gsi.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).