From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 16C86386F021 for ; Wed, 7 Jun 2023 15:57:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 16C86386F021 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686153460; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=eRcflBLXfJL0SXsjF/892/tal4b4442BRsgS0wFzuRA=; b=Hm+dnvBoPV+FP2z6zCfKvRm1jrLA16MPvoOZ8Ium4aqvml1Bkgz05jP7CBmFUdrqqLWv3H h+ejyaPNi47fuW+EEGXO3lKo4k7UTMcNxNdB5XsnCuon7ppi+T0rtxv+IOYh/UnZk1ZcMQ ZdRQMO9+n0sRzt0MCi2bF+2YYF5lOQM= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-76-iNHexGWUO4-Cgt8tjPHo9A-1; Wed, 07 Jun 2023 11:57:39 -0400 X-MC-Unique: iNHexGWUO4-Cgt8tjPHo9A-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2b1a69f1442so45944531fa.1 for ; Wed, 07 Jun 2023 08:57:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686153457; x=1688745457; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eRcflBLXfJL0SXsjF/892/tal4b4442BRsgS0wFzuRA=; b=jNB6jtKZGkdgmYXBIle6LWBpMZM5EgCAjyHD+d5HvA7Wvh9BegxXBlbDumTGIq7UNw Gz2QBtNIEThbdq9EqopAZuqFYqBUxlOhv1cF4UezC92bZ2K6SIF6dyWc/fp3R+gIJUpk LWTG8YRmrATwoH2evOaYsamFqgEWGG9lfKb1luJGMoc0AS5CLQOprFCU6hWVyPU00XmF lHUjjekfbkx7ZfMR4xH0EHhL9AM+lcG9v2L4ijKJEDlsCRHDmU/7YpGAXk8FzMkn8etB JvHLFV/wz2R4pHBcHLrnrc4fKLvVDtX5TrPxJwKYbzlXitEQnU26X8Xl+VKtv45DQafh ADPQ== X-Gm-Message-State: AC+VfDz06IUhgXHLcggTSHlASeND4FCdygjQBM+y/vGpKcHZY+t3IMV7 XFeZtOlbuCU/bO8i6QN852e8cvMMZu2KcnYI1ic0EjC44K2lJw/4bQdYSiic1AxS13L5YS/XVVt o5tlbl7BwljOg+vbnTFppgVvBz7RVsOPgqA== X-Received: by 2002:a2e:988e:0:b0:2b1:be57:5c0c with SMTP id b14-20020a2e988e000000b002b1be575c0cmr2567455ljj.12.1686153457736; Wed, 07 Jun 2023 08:57:37 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4dKmIjQEIG21LlOiX0SVbRwM+gAcvDeifVBgX6tCNXKRZ3qo9FbeOqImKjDem0sHzrOBFuJaHrAGK9w8/LDCo= X-Received: by 2002:a2e:988e:0:b0:2b1:be57:5c0c with SMTP id b14-20020a2e988e000000b002b1be575c0cmr2567451ljj.12.1686153457593; Wed, 07 Jun 2023 08:57:37 -0700 (PDT) MIME-Version: 1.0 References: <20230601155856.305565-1-jwakely@redhat.com> <20230607144244.A0DC120420@pchp3.se.axis.com> In-Reply-To: From: Jonathan Wakely Date: Wed, 7 Jun 2023 16:57:25 +0100 Message-ID: Subject: Re: [PATCH] libstdc++: Use AS_IF in configure.ac To: Andreas Schwab Cc: Jonathan Wakely via Gcc-patches , Hans-Peter Nilsson , libstdc++@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000e0874005fd8c312b" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000e0874005fd8c312b Content-Type: text/plain; charset="UTF-8" On Wed, 7 Jun 2023 at 16:19, Andreas Schwab wrote: > On Jun 07 2023, Jonathan Wakely via Gcc-patches wrote: > > > Let's just revert it then. The manual says we should use AS_IF, but what > we > > had previously was working well enough. I'll figure out what happened > here > > later. > > I think AS_IF is doing its job here: moving the expansion of > AC_REQUIRE'd macros out of the bodies. But many of those expansions > actually need to remain under the $GLIBCXX_IS_NATIVE conditional, so it > is not appropriate at this place. > > Ah yes, that makes sense. Thanks. --000000000000e0874005fd8c312b--