From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7DF8C3858C2C for ; Fri, 18 Mar 2022 10:47:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7DF8C3858C2C Received: from mail-yb1-f198.google.com (mail-yb1-f198.google.com [209.85.219.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-47-XX2BHVN6PC-MkasLhcz9bw-1; Fri, 18 Mar 2022 06:47:00 -0400 X-MC-Unique: XX2BHVN6PC-MkasLhcz9bw-1 Received: by mail-yb1-f198.google.com with SMTP id h16-20020a056902009000b00628a70584b2so6608099ybs.6 for ; Fri, 18 Mar 2022 03:47:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4sxvimdQshh4lXbvzTlcRNbjHKEQ7n3zAJpX1rw4G10=; b=OB21/aVetybVYTHjuadeRHNgTgQKrZqeiqTarLEB0WJ6t49KfjVKEQJua+D4VLKZrj +2Sh1hjpQmlythITYn9WHdpQlUPXK6JcmVA1fTZHhtIGnReZBVZT8OxhFcWExeN3FRed 4GR0om4pLe+10q+VkkCge1cirXAQDcbUKSBMbnweY7c1YN8jU6y+1dlqzhC3niOl1dVs z7g3VSPm8SPUO7neuJD/XZhVZF3kIPrBbb2g30zalktlipL+P0t6QFtuOhwgAx8AE5X4 3RRbNmHciZtOR9ML/vavKwSI2mskhOMgMHkyVCL2emyMWsTBycxp+6G57NEeprtDs85U jd7Q== X-Gm-Message-State: AOAM533Kn1U31keMFsFgcxorga6MuxKg5VaHI23fdISHkYZUn3KGoeZs p2dtt0S+SrGFEEbOaaNCP0akRef3aFR5nm4DVVTPJAw3wvrV2bj8Vk+siVLnc1YNrdDO3VJFLAH UUXyeZDD/s/Cy+pgHIibZbe43JkTqjdCG6Q== X-Received: by 2002:a81:71d7:0:b0:2e5:92da:3cec with SMTP id m206-20020a8171d7000000b002e592da3cecmr10134875ywc.473.1647600420317; Fri, 18 Mar 2022 03:47:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzyXauY/b+AB0YTwjuIDXK+jzXnk6a02+DaaxCneSKbaKoYyLLnA/bNlRrdqJ/llPo6KZTfKiu6+JQFEjq9pFE= X-Received: by 2002:a81:71d7:0:b0:2e5:92da:3cec with SMTP id m206-20020a8171d7000000b002e592da3cecmr10134868ywc.473.1647600420144; Fri, 18 Mar 2022 03:47:00 -0700 (PDT) MIME-Version: 1.0 References: <20220317190133.415743-1-jwakely@redhat.com> In-Reply-To: From: Jonathan Wakely Date: Fri, 18 Mar 2022 10:46:49 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Reduce header dependencies from PSTL headers [PR92546] To: Thomas Rodgers Cc: "libstdc++" , gcc Patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2022 10:47:05 -0000 On Fri, 18 Mar 2022 at 10:16, Jonathan Wakely wrote: > > On Thu, 17 Mar 2022 at 20:44, Thomas Rodgers wrote: > > > > Looks ok to me. I just am curious, does the change to src/c++17/fs_path.cc need to be part of this change (It's not obvious to me that it is related to the other changes in the patch). > > It's related. fs_path.cc uses std::array but was not including > directly, it was accidentally relying on it being there via > . After this change, doesn't include > , so doesn't include and so fs_path.cc needs to be > fixed. Pushed to trunk now.