From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D403D3858D35 for ; Wed, 8 Nov 2023 14:26:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D403D3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D403D3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699453591; cv=none; b=OZWc0h1OE6tEX0ivU+JQY+qe8FlsaRBpUtLPEhVwJCVdfJ7wdGRh6bhvO7byZ6RPzken515t2dVUfyMjMkqcLx5ZEfPiefvn+nG7SPHl/hBKzmx6H6FHRBEklV//+vz0SmX0DFjKrukbuFIuiiIwW+D7/hhS5ic2kCIGrp8Xc3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699453591; c=relaxed/simple; bh=70HOblfHZraD/OWCYBscv24HEOAITMcx53ekgCG19Cw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=lZczhCqAA26ZZbJ0WjGo/QM60r9L+GZJhkTyXuOSNWq9rw7LK8c6PUjbRv/GoukaJBayVdNhuWMZBOkeQWkv1wqO3Ec20QnRGZgX76F04G41mr6rT2Myz4BThHP+Pwvhwop5Brd7GuzydEB1D46IXV0hIyoIc3MioOmNH+5TX0U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699453590; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VH0/uQfr6oqp/zcA1wvOT6Z7D4QNxc8pmpM8+tMNDlk=; b=iaa3+cQpnGHtTMbflsKWoDqB++M4/7pE9S/lQ2mxoF3H6O+BgMqbxJvEg0BjiX7oqh6zUk QASQpMFJ5Zx7ZVTIpegelM2FnsLafqlgvxzErOGAekRkIfn1uwcAVp+3KxCUp/DsUDE3YJ ZdyNv53aILkfbhDD1BGmDvrIEKUrbqk= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-416-vhrjiPsOMn6AsHPg4qM0BQ-1; Wed, 08 Nov 2023 09:26:29 -0500 X-MC-Unique: vhrjiPsOMn6AsHPg4qM0BQ-1 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-5af9ad9341fso95026967b3.2 for ; Wed, 08 Nov 2023 06:26:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699453588; x=1700058388; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VH0/uQfr6oqp/zcA1wvOT6Z7D4QNxc8pmpM8+tMNDlk=; b=tOXr7YrCqyL4lqkdrxPuOsXo9jld7WGF6FWbIotkijoUvxZ3eQqu53rWbXUlSSTphz Bg9+yWVMF1+olrsGpi+pEIVWdBbM32DxRpi2VUBbWdswE7FP7GUmq2mna0+7A6Gbh3fE y3SscL1qMD7JAN1fqQtQslFDD9G64PeTqjIiFJ5gwUEn63OTC2nOyG+cQ7Pk/hXJWKA4 lgl9QSr7uv5aLAy5zpPwUoXbsyT7ickJWOxksLg7eflqyFHpxMXQu7B5Am7wvX6hf5KF HCRcS9zoHNqsOkk0ay+OQqtLhvQXF5M5M9+xIsc2T/QUXy8WeysignaAisVm4/AiJiMU +aBw== X-Gm-Message-State: AOJu0YxF++QGo2Strw4mjlCassW4r5mJLTHsJYYI6EFPcrS8ytVY8Gc7 mKE0y9XgAgYhSQIkiKoWACPT9XktGPxLCoCu1/KV+/xOQzDEu5rYPeGL8x8AponUkZx8fR94LUl xvLj1hEIXq9/adaHhU4dgMy3SoMgN0wSLGg== X-Received: by 2002:a0d:d790:0:b0:5a8:ee42:4aea with SMTP id z138-20020a0dd790000000b005a8ee424aeamr2014574ywd.22.1699453588776; Wed, 08 Nov 2023 06:26:28 -0800 (PST) X-Google-Smtp-Source: AGHT+IFhtsdIbkcBr9nW+PCF14YHH+oNkXpdVLo+n8HLrgKdQ27qrw4PZKzjoMOzKU/9i+kxx7n1zU9W4WQVajM6Uy4= X-Received: by 2002:a0d:d790:0:b0:5a8:ee42:4aea with SMTP id z138-20020a0dd790000000b005a8ee424aeamr2014558ywd.22.1699453588572; Wed, 08 Nov 2023 06:26:28 -0800 (PST) MIME-Version: 1.0 References: <2f5f1761-0108-4900-9926-d49fa03b066c@gmail.com> In-Reply-To: From: Jonathan Wakely Date: Wed, 8 Nov 2023 14:26:17 +0000 Message-ID: Subject: Re: [PATCH][_Hashtable] Add missing destructor call To: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= Cc: "libstdc++" , gcc-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 8 Nov 2023 at 05:39, Fran=C3=A7ois Dumont wr= ote: > > > On 07/11/2023 00:28, Jonathan Wakely wrote: > > On Mon, 6 Nov 2023 at 21:39, Fran=C3=A7ois Dumont wrote: > >> Noticed looking for other occasion to replace __try/__catch with RAII > >> helper. > >> > >> libstdc++: [_Hashtable] Add missing node destructor call > >> > >> libstdc++-v3/ChangeLog: > >> > >> * include/bits/hashtable_policy.h > >> (_Hashtable_alloc<>::_M_allocate_node): Add missing call= to > >> node destructor > >> on construct exception. > >> > >> Tested under Linux x64, ok to commit ? > > OK. > > > > Is this missing on any branches too? > Clearly all maintained branches. > > I don't think it's actually a problem, since it's a trivial destructor = anyway. > > Yes, me neither, I was only thinking about sanity checker tools when > doing this so no plan for backports. OK, that seems fine, thanks.