From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 264B93858D32 for ; Sun, 7 Jan 2024 01:00:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 264B93858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 264B93858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704589230; cv=none; b=WxCmuAizd2r5qzB6bEw/7Hm2Vt2g3fOWwJB62J5A9nOsXWe/YAi+UNdf6CCg9DMuebc82ECSWYp2cOOYlYG6pTX+opqmmP/InQN/e+vJPNCqkj74fCPPFcyWzDDl4C4TaXZZmLbvoqYFFntlRiSm+TTgod1qaVNGR9PloUqZetg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704589230; c=relaxed/simple; bh=N3bcW7lWF8UNpFx6Vy9UoR3o5s2ZZRoTbR4DTTQ+GUY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=xiVSjfxdGqa9I0FRQUFgXnTgpRrioa4ZxGGUjm2kWsdeo3nzcPy91D3bpwHL8W3vTg0aYUU4NZQdkgD8v4AYXQZOYiUG0MpEcps1cqrY0HSVLEDU//k3EQhvKdjH9inEsibaAvbA7N5YdZfeyPzpPqIxyoh8mKTRhFxxD4Ukvp4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704589219; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7ySejjNXFZCxYPZMJQWzDZrF3UG3J11gcz+UUbiEQ84=; b=EVq+R58xpZMrnZk/Paydfv5a8VVUEr4VVlSzESya96pk97m7T/+19ksnDMGENEgSAbFWx+ NpwY5yqyOZ9O9v5LlL+cPqpmHtH69dBmOBXx35g1UScp686hVO9bnTM9cPuHCX4tepuFdz +7LnCS0Xxhft0rJWHVSKYsjWQ+5lUQs= Received: from mail-yw1-f200.google.com (mail-yw1-f200.google.com [209.85.128.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-580-vhwWaQAxP0-jU5XXztIFFg-1; Sat, 06 Jan 2024 20:00:18 -0500 X-MC-Unique: vhwWaQAxP0-jU5XXztIFFg-1 Received: by mail-yw1-f200.google.com with SMTP id 00721157ae682-5e73e6a17d5so12365857b3.0 for ; Sat, 06 Jan 2024 17:00:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704589218; x=1705194018; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7ySejjNXFZCxYPZMJQWzDZrF3UG3J11gcz+UUbiEQ84=; b=UM52/MKI1Hr0jg5vQgin6QmbWG4WyDGpg5/dPlM1wOUpDl41/gnVA05e1Ar1viDHKy T8cMKCAx8sGftM/YcNWbbnTbWonSP2kF82AJcCeaeQxVczurg7FvUkUGn6tXDlkQucMY nRDO0Ts2znG1tqzOYTwywn+wJuspY9sMQgnQYQHgjteVtc5rjKIbAeWvVagu2chMcllD lNN1hr0TAALd3L8ZsSzu9VZIrr6Cy/l29YFm8aYIwTY/bPq5d+V5sBRmBpWlougDzwTM JFdXNDKDPIPcOnGS9mRjDP4jVXtjhYKOF1zU3i9ooM1XQN5ZUx2SyfSI2KAg1b6X+vDZ 7ArA== X-Gm-Message-State: AOJu0YxDXLmt66cyjRzE5tq+8n6W7x+wefWvtNhrpv2GOdr6GPq1RQHr gAnmlyqvn99NsYIByTPx2ZUe7sQoURakBFzGs3OmTPVQf84Ym0irsKR9vKYpGWsqK1iQ0FIICCy JpeCWmIs1j6YMky+dAH30cT/vI0DPqHdBKztrrKjKNg== X-Received: by 2002:a0d:cd03:0:b0:5e8:386a:6e53 with SMTP id p3-20020a0dcd03000000b005e8386a6e53mr1268313ywd.9.1704589217816; Sat, 06 Jan 2024 17:00:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IFWcwQ1pjGsxsc4NApWRplDj3gQ5IhcUgevHjk/diXjEfbHgz2DJRsFrjxFgcZQW3OJcrU6AHWgS6o4s54/Sgg= X-Received: by 2002:a0d:cd03:0:b0:5e8:386a:6e53 with SMTP id p3-20020a0dcd03000000b005e8386a6e53mr1268303ywd.9.1704589217281; Sat, 06 Jan 2024 17:00:17 -0800 (PST) MIME-Version: 1.0 References: <20231214010904.1724915-1-jwakely@redhat.com> In-Reply-To: <20231214010904.1724915-1-jwakely@redhat.com> From: Jonathan Wakely Date: Sun, 7 Jan 2024 01:00:01 +0000 Message-ID: Subject: Re: [PATCH] libstdc++: Optimize std::is_trivially_destructible_v To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pushed to trunk now. On Thu, 14 Dec 2023 at 01:09, Jonathan Wakely wrote: > > Tested x86_64-linux. > > Does this look right? Can we do it faster, or simplify it? > > -- >8 -- > > This reduces the overhead of using std::is_trivially_destructible_v and > as a result fixes some recent regressions seen with a non-default > GLIBCXX_TESTSUITE_STDS env var: > FAIL: 20_util/variant/87619.cc -std=gnu++20 (test for excess errors) > FAIL: 20_util/variant/87619.cc -std=gnu++23 (test for excess errors) > FAIL: 20_util/variant/87619.cc -std=gnu++26 (test for excess errors) > > libstdc++-v3/ChangeLog: > > * include/std/type_traits (is_trivially_destructible_v): Use > built-in directly when concepts are supported. > * testsuite/20_util/is_trivially_destructible/value_v.cc: New > test. > --- > libstdc++-v3/include/std/type_traits | 19 +++++++++ > .../is_trivially_destructible/value_v.cc | 40 +++++++++++++++++++ > 2 files changed, 59 insertions(+) > create mode 100644 libstdc++-v3/testsuite/20_util/is_trivially_destructible/value_v.cc > > diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits > index 677cd934b94..a0821347676 100644 > --- a/libstdc++-v3/include/std/type_traits > +++ b/libstdc++-v3/include/std/type_traits > @@ -3300,9 +3300,28 @@ template > inline constexpr bool is_trivially_move_assignable_v > = __is_trivially_assignable(__add_lval_ref_t<_Tp>, > __add_rval_ref_t<_Tp>); > + > +#if __cpp_concepts > +template > + inline constexpr bool is_trivially_destructible_v = false; > + > +template > + requires (!is_reference_v<_Tp>) && requires (_Tp& __t) { __t.~_Tp(); } > + inline constexpr bool is_trivially_destructible_v<_Tp> > + = __has_trivial_destructor(_Tp); > +template > + inline constexpr bool is_trivially_destructible_v<_Tp&> = true; > +template > + inline constexpr bool is_trivially_destructible_v<_Tp&&> = true; > +template > + inline constexpr bool is_trivially_destructible_v<_Tp[_Nm]> > + = is_trivially_destructible_v<_Tp>; > +#else > template > inline constexpr bool is_trivially_destructible_v = > is_trivially_destructible<_Tp>::value; > +#endif > + > template > inline constexpr bool is_nothrow_constructible_v > = __is_nothrow_constructible(_Tp, _Args...); > diff --git a/libstdc++-v3/testsuite/20_util/is_trivially_destructible/value_v.cc b/libstdc++-v3/testsuite/20_util/is_trivially_destructible/value_v.cc > new file mode 100644 > index 00000000000..7db098a2c4d > --- /dev/null > +++ b/libstdc++-v3/testsuite/20_util/is_trivially_destructible/value_v.cc > @@ -0,0 +1,40 @@ > +// { dg-do compile { target c++17 } } > +#include > +#include > + > +template > +constexpr void test_cv() > +{ > + static_assert(std::is_trivially_destructible_v > + == std::is_trivially_destructible_v); > + static_assert(std::is_trivially_destructible_v > + == std::is_trivially_destructible_v); > + static_assert(std::is_trivially_destructible_v > + == std::is_trivially_destructible_v); > +} > + > +template > +void test() > +{ > + static_assert(std::is_trivially_destructible_v == Expected); > + test_cv(); > +} > + > +void test01() > +{ > + using namespace __gnu_test; > + > + test(); > + test(); > + test(); > + test(); > + test(); > + test(); > + test(); > + test(); > + test(); > + test(); > + test(); > + test(); > + test(); > +} > -- > 2.43.0 >