From: Jonathan Wakely <jwakely@redhat.com>
To: Nathaniel Shead <nathanieloshead@gmail.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] libstdc++: Add missing functions to <cmath> [PR79700]
Date: Mon, 20 Feb 2023 12:08:38 +0000 [thread overview]
Message-ID: <CACb0b4=av=OkHKuN+911KwLezdjKtTMHmaDn1LvYQdmYAxSGNg@mail.gmail.com> (raw)
In-Reply-To: <CACEF2k63F8MgRZK0w05p4oCbP1fJx7=BzyQSzr6VMt8btvdFOQ@mail.gmail.com>
On Mon, 20 Feb 2023 at 11:57, Nathaniel Shead <nathanieloshead@gmail.com> wrote:
>
> On Mon, Feb 20, 2023 at 10:30 PM Jonathan Wakely <jwakely@redhat.com> wrote:
> >
> > On Mon, 20 Feb 2023 at 11:23, Nathaniel Shead via Libstdc++
> > <libstdc++@gcc.gnu.org> wrote:
> > >
> > > The comments on PR79700 mentioned that it was somewhat ambiguous whether
> > > these functions were supposed to exist for C++11 or not. I chose to add
> > > them there, since other resources (such as cppreference) seem to think
> > > that C++11 should be the standard these functions were introduced, and I
> > > don't know of any reason to do otherwise.
> > >
> > > Tested on x86_64-linux.
> >
> > Thanks for the patch, but this needs tests for the new declarations
> > (which are tedious to write, which is the main reason I haven't
> > already pushed my own very similar patch).
> >
>
> Ah OK, fair enough. Where should the tests go? The only tests I could
> find for the existing (non -f/l) functions was just tests for their
> existence in testsuite/26_numerics/headers/cmath/functions_std_c++17.cc
> which I just added the new functions to - I guess I'll add a new file
> here and test that all the functions can be called and give the same
> results as the relevant overloaded variants?
Yeah, that sounds great, thanks!
next prev parent reply other threads:[~2023-02-20 12:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 11:23 Nathaniel Shead
2023-02-20 11:30 ` Jonathan Wakely
2023-02-20 11:57 ` Nathaniel Shead
2023-02-20 12:08 ` Jonathan Wakely [this message]
2023-02-21 11:22 ` Nathaniel Shead
2023-04-17 8:10 ` [Ping][PATCH] " Nathaniel Shead
2023-04-18 8:47 ` Jonathan Wakely
2023-05-17 8:37 ` Nathaniel Shead
2023-05-17 9:05 ` Jonathan Wakely
2023-05-17 9:38 ` Nathaniel Shead
2023-05-17 10:07 ` Jonathan Wakely
2023-11-11 0:43 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACb0b4=av=OkHKuN+911KwLezdjKtTMHmaDn1LvYQdmYAxSGNg@mail.gmail.com' \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=nathanieloshead@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).